From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99412C433F5 for ; Fri, 15 Oct 2021 14:32:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25DB060E09 for ; Fri, 15 Oct 2021 14:32:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 25DB060E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7F21A82F03; Fri, 15 Oct 2021 16:32:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634308352; bh=Hal7bE4LtJ4QEqnkkKFTlSGctNvUt4gZEOaNKuAbl5Y=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XAlumY1tZhbdDeVrZZrpK7tUArtx9vx6ni8cPbfbMOQee8WiAZprOUHJVsd3nP/sj CoWBW6fHi6NFqgUTL+wocHDEOTtwogdzpur+sVFnnMSspIoobQIEpNd3rIAbWMfKtY qL5pbixOzT1jxJ8h8x7jKagmgoFc+TgXy9bdGTpZZiKK05FlBanBTMVwgtBltRe7xf 2z+CdpTEYo+EniUWw0xa3M4w9rbDQXj2ApwOflOclI3ud0amZeQ7Ad+SB9GW2NGxgU wRHqjz9hCKOKpDTUeNJoVHZfIMndrkTMrWYREWcTe+u+EQ1yKRQtkrYVPnBweufxpk wfxR+tDMAQR+A== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D124C82F03 for ; Fri, 15 Oct 2021 16:32:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634308350; bh=Hal7bE4LtJ4QEqnkkKFTlSGctNvUt4gZEOaNKuAbl5Y=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=pO55meLo8Qc24cjEH7+LelVKofstduY9L+gHNFCghsqyAzqhdJMOE0tIfzZKseIUx Cjr8EoK0zQ7LUeOjOfhgw5maBYolQaRK4gWSd8BEUN6FOsjSN7GKn0IeZAvFvU+NIG ulnO0A3lzjRKQMeprYDtelw6+Vk6rCssu5PAsZwG+rglOgR4KP+sjn5K9CHh0kglQg MzbeunQye2SLvQxt8T51/MZFEVCSeU0ftXilORFxFm5dkUQ7QHP3gFUtdgwS5d2XWd 5hGVu+a3nt1HyX4yXGlnY74OwaZyevqHFHoRXlKNmWN/ugemmv2rURvqg1KARdTZb/ 6OQONEOHkxhDg== Received: by janitor.denx.de (Postfix, from userid 108) id 81C6CA01C8; Fri, 15 Oct 2021 16:32:30 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id A9F55A009B; Fri, 15 Oct 2021 16:32:25 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 887231E0F1B; Fri, 15 Oct 2021 16:32:25 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Heinrich Schuchardt , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Thu, 14 Oct 2021 12:22:54 -0600." Date: Fri, 15 Oct 2021 16:32:25 +0200 Message-ID: <3341802.1634308345@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon Glass, In message <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It would be better if we could just type the script into a > text file and have it included by U-Boot. > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file in a board//env > directory called .env (or common.env if you want the same > environment for all boards). Argh... did you bother to read my comments? Apparently not. Thus: NAKed by: Wolfgang Denk I really think your fixed filename proposal does not work well in reality. The file name should be Kconfig configurable. See [1] for details. [1] https://lists.denx.de/pipermail/u-boot/2021-October/462668.html Thanks. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "There's always been Tower of Babel sort of bickering inside Unix, but this is the most extreme form ever. This means at least several years of confusion." - Bill Gates, founder and chairman of Microsoft, about the Open Systems Foundation