U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Kathpalia, Tanmay" <tanmay.kathpalia@altera.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	U-Boot Mailing List <u-boot@lists.u-boot-project.org>
Cc: Jens Wiklander <jens.wiklander@oss.qualcomm.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Sai Sree Kartheek Adivi <s-adivi@ti.com>,
	Alexander Heinisch <alexander.heinisch@siemens.com>,
	Peng Fan <peng.fan@nxp.com>,
	Jaehoon Chung <jh80.chung@samsung.com>
Subject: Re: [PATCH 3/4] mmc: Call back to optee after a successful mmc_init
Date: Sun, 23 Aug 2026 20:18:15 +0530	[thread overview]
Message-ID: <334f6456-6765-4cf9-b005-1668fdb6960f@altera.com> (raw)
In-Reply-To: <a95292a0b1dc11096c34916c020173f1671c492b.1787304541.git.jan.kiszka@siemens.com>

Hi Jan,

On 21-08-2026 14:59, Jan Kiszka wrote:
> From: Jan Kiszka<jan.kiszka@siemens.com>
>
> This is needed to that OP-TEE can re-enumerate services which need RPMB
> access that may have become available now.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
> CC: Peng Fan<peng.fan@nxp.com>
> CC: Jaehoon Chung<jh80.chung@samsung.com>
> ---
>   drivers/mmc/mmc.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 670e92ee12b..2463e50cd3c 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -27,6 +27,7 @@
>   #include <linux/list.h>
>   #include <linux/printk.h>
>   #include <div64.h>
> +#include <tee/optee.h>

The include is unconditional while the call is not.

>   #include "mmc_private.h"
>   
>   #define DEFAULT_CMD6_TIMEOUT_MS  500
> @@ -3168,6 +3169,9 @@ int mmc_init(struct mmc *mmc)
>   				mmc->cfg->name);
>   	}
>   
> +	if (CONFIG_IS_ENABLED(OPTEE) && mmc->capacity_rpmb > 0)

It will fail to link when OPTEE=y and SUPPORT_EMMC_RPMB=n. Add
SUPPORT_EMMC_RPMB (or stub the symbol when RPMB is off).

> +		optee_rpmb_available();
> +
>   	return err;
>   }
>   

  reply	other threads:[~2026-08-23 14:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  9:28 [PATCH 0/4] optee: Add support for enumerating RPMB-dependent services Jan Kiszka
2026-08-21  9:28 ` [PATCH 1/4] tee: optee: Add support for enumerating services that only need RPMB Jan Kiszka
2026-08-23 14:31   ` Kathpalia, Tanmay
2026-08-23 18:32     ` Jan Kiszka
2026-08-23 19:09       ` Kathpalia, Tanmay
2026-08-23 19:37         ` Jan Kiszka
2026-08-21  9:28 ` [PATCH 2/4] tee: optee: Do not warn about TEE_ERROR_STORAGE_NOT_AVAILABLE Jan Kiszka
2026-08-23 14:39   ` Kathpalia, Tanmay
2026-08-21  9:29 ` [PATCH 3/4] mmc: Call back to optee after a successful mmc_init Jan Kiszka
2026-08-23 14:48   ` Kathpalia, Tanmay [this message]
2026-08-21  9:29 ` [PATCH 4/4] mmc: Make "MMC Device not found" a debug output Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=334f6456-6765-4cf9-b005-1668fdb6960f@altera.com \
    --to=tanmay.kathpalia@altera.com \
    --cc=alexander.heinisch@siemens.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=jens.wiklander@oss.qualcomm.com \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=s-adivi@ti.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox