From: Stefan Bruens <stefan.bruens@rwth-aachen.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] usb: dwc2: determine TT hub address and port for split transactions
Date: Thu, 17 Dec 2015 04:16:28 +0100 [thread overview]
Message-ID: <3364487.y0b5h7sQeW@pebbles.site> (raw)
In-Reply-To: <5670D7CC.1060308@wwwdotorg.org>
On Tuesday 15 December 2015 20:17:32 Stephen Warren wrote:
> On 12/12/2015 09:17 PM, Stefan Br?ns wrote:
> > Start split and complete split tokens need the hub address and the
> > downstream port of the first HS hub (device view).
> > Code copied from host/ehci_hcd.c
>
> Rather than cut/paste this, shouldn't you create a common function that
> can be shared between all users?
Good idea, as the code is also duplicated in musb-new.
Any suggestions where to put the new function? For CONFIG_DM_USB there is
usb_uclass.c. Move it into usb_uclass.c and leave the non DM variants in place
(same name, but declared static)?
Kind regards,
Stefan
--
Stefan Br?ns / Bergstra?e 21 / 52062 Aachen
home: +49 241 53809034 mobile: +49 151 50412019
work: +49 2405 49936-424
next prev parent reply other threads:[~2015-12-17 3:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 4:17 [U-Boot] [PATCH 0/6] usb: dwc2: add SPLIT transaction support Stefan Brüns
2015-12-13 4:17 ` [U-Boot] [PATCH 1/6] usb: dwc2: avoid out of bounds access Stefan Brüns
2015-12-13 4:41 ` Marek Vasut
2015-12-16 2:58 ` Stephen Warren
2015-12-16 10:29 ` Marek Vasut
2015-12-17 1:44 ` Stefan Bruens
2015-12-13 4:17 ` [U-Boot] [PATCH 2/6] usb: dwc2: Handle NAK during CONTROL DATA and STATUS stage Stefan Brüns
2015-12-13 4:46 ` Marek Vasut
2015-12-16 3:07 ` Stephen Warren
2015-12-17 3:09 ` Stefan Bruens
2015-12-13 4:17 ` [U-Boot] [PATCH 3/6] usb: dwc2: determine TT hub address and port for split transactions Stefan Brüns
2015-12-13 4:43 ` Marek Vasut
2015-12-16 3:17 ` Stephen Warren
2015-12-17 3:16 ` Stefan Bruens [this message]
2015-12-18 1:11 ` [U-Boot] [PATCH] usb: Move determination of TT hub address/port into seperate function Stefan Brüns
2015-12-18 2:35 ` Marek Vasut
2015-12-18 10:00 ` Hans de Goede
2015-12-19 17:17 ` Stefan Bruens
2015-12-19 18:27 ` Hans de Goede
2015-12-19 20:16 ` [U-Boot] [PATCH 1/2 v2] " Stefan Brüns
2015-12-19 20:16 ` [U-Boot] [PATCH 2/2 v2] usb: musb: Fix hub port number for SPLIT transactions Stefan Brüns
2015-12-21 19:33 ` Hans de Goede
2015-12-21 20:27 ` Marek Vasut
2015-12-21 23:02 ` Stefan Bruens
2015-12-21 23:08 ` Marek Vasut
2015-12-19 20:26 ` [U-Boot] [PATCH 1/2 v3] usb: Move determination of TT hub address/port into seperate function Stefan Brüns
2015-12-20 19:12 ` Hans de Goede
2015-12-21 19:32 ` Hans de Goede
2015-12-13 4:17 ` [U-Boot] [PATCH 4/6] usb: dwc2: add helper function for setting SPLIT HC registers Stefan Brüns
2015-12-13 4:44 ` Marek Vasut
2015-12-16 3:19 ` Stephen Warren
2015-12-13 4:17 ` [U-Boot] [PATCH 5/6] usb: dwc2: add support for SPLIT transactions Stefan Brüns
2015-12-13 4:48 ` Marek Vasut
2015-12-16 3:36 ` Stephen Warren
2015-12-20 0:17 ` Stefan Bruens
2015-12-20 0:41 ` Marek Vasut
2015-12-13 4:17 ` [U-Boot] [PATCH 6/6] usb: dwc2: remove no longer used wait_for_chhltd() Stefan Brüns
2015-12-13 4:48 ` Marek Vasut
2015-12-16 3:36 ` Stephen Warren
2015-12-13 4:41 ` [U-Boot] [PATCH 0/6] usb: dwc2: add SPLIT transaction support Marek Vasut
2015-12-16 2:53 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3364487.y0b5h7sQeW@pebbles.site \
--to=stefan.bruens@rwth-aachen.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox