public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] SPL: omap4: Reduce the maximum size of SPL to 32K bytes.
Date: Wed, 28 Sep 2011 13:48:21 +0530	[thread overview]
Message-ID: <338515a4292d756280d495825be3aa6b@mail.gmail.com> (raw)
In-Reply-To: <9C8383B7-E2BA-45A6-BE9A-151DF50AD7E6@googlemail.com>

Hi Andreas Bie?mann,

>-----Original Message-----
>From: Andreas Bie?mann [mailto:andreas.devel at googlemail.com]
>Sent: Wednesday, September 28, 2011 1:39 PM
>To: sricharan
>Cc: u-boot at lists.denx.de; aneesh at ti.com
>Subject: Re: [U-Boot] [PATCH 2/2] SPL: omap4: Reduce the maximum size of
>SPL to 32K bytes.
>
>Dear sricharan,
>
>Am 27.09.2011 um 13:43 schrieb sricharan:
>
>> The maximum size of SPL is set to 38K bytes.
>> But the maximum size of SPL cannot exceed 32k bytes in
>> case of HS devices. So restrict the size to 32k bytes
>> for compatability with both HS/GP devices.
>>
>> Signed-off-by: sricharan <r.sricharan@ti.com>
>> ---
>> include/configs/omap4_common.h |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/omap4_common.h
>b/include/configs/omap4_common.h
>> index e10ab00..7346934 100644
>> --- a/include/configs/omap4_common.h
>> +++ b/include/configs/omap4_common.h
>> @@ -246,7 +246,7 @@
>> /* Defines for SPL */
>> #define CONFIG_SPL
>> #define CONFIG_SPL_TEXT_BASE		0x40304350
>
>can you please add one line commenting why we use 32k here?
>
Sure, I will add this comment.
>> -#define CONFIG_SPL_MAX_SIZE		(38 * 1024)
>> +#define CONFIG_SPL_MAX_SIZE		(32 * 1024)
>
>best regards
>
>Andreas Bie?mann

      reply	other threads:[~2011-09-28  8:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 11:43 [U-Boot] [PATCH 0/2] SPL: omap4: Fix boot crash in HS devices sricharan
2011-09-27 11:43 ` [U-Boot] [PATCH 1/2] U-Boot/SPL: omap4: Make ddr pre-calculated timings as default sricharan
2011-09-27 11:43 ` [U-Boot] [PATCH 2/2] SPL: omap4: Reduce the maximum size of SPL to 32K bytes sricharan
2011-09-28  8:08   ` Andreas Bießmann
2011-09-28  8:18     ` Sricharan R [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=338515a4292d756280d495825be3aa6b@mail.gmail.com \
    --to=r.sricharan@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox