From: Roger Quadros <rogerq@kernel.org>
To: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL
Date: Thu, 29 Sep 2022 10:02:54 +0300 [thread overview]
Message-ID: <33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org> (raw)
In-Reply-To: <CAPnjgZ1a9xQg3Uu4U5Hdr4=QBc=rPeCP532oopcant_-eHCZMg@mail.gmail.com>
Hi Simon,
On 28/09/2022 19:27, Simon Glass wrote:
> Hi Roger,
>
> On Wed, 28 Sept 2022 at 06:12, Roger Quadros <rogerq@kernel.org> wrote:
>>
>> We will need ti-gpmc driver for SPL. Allow memory drivers
>> do be built for SPL.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> scripts/Makefile.spl | 1 +
>> 1 file changed, 1 insertion(+)
>
> Please can you use the existing drivers/ram directory?
The ti-gpmc driver is not actually a RAM only controller. Although it can support SRAM.
It is a more general purpose controller that can support different peripherals.
It is similar to the drivers already existing in the divers/memory directory.
I was just trying to keep the file layout similar to that in the Linux kernel.
Do you still see a problem with it?
>
>>
>> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
>> index 3bafeb4fe9..110076b22f 100644
>> --- a/scripts/Makefile.spl
>> +++ b/scripts/Makefile.spl
>> @@ -114,6 +114,7 @@ libs-$(CONFIG_PARTITIONS) += disk/
>> endif
>>
>> libs-y += drivers/
>> +libs-y += drivers/memory/
>> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/dwc3/
>> libs-$(CONFIG_SPL_USB_GADGET) += drivers/usb/cdns3/
>> libs-y += dts/
>> --
>> 2.17.1
>>
>
> Regards,
> Simon
cheers,
-roger
next prev parent reply other threads:[~2022-09-29 7:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 12:11 [u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver Roger Quadros
2022-09-28 12:11 ` [u-boot][PATCH 1/3] scripts: Makefile.spl: Enable memory drivers to be built for SPL Roger Quadros
2022-09-28 16:27 ` Simon Glass
2022-09-29 7:02 ` Roger Quadros [this message]
2022-09-29 17:51 ` Tom Rini
2022-09-29 18:06 ` Simon Glass
2022-09-30 12:47 ` Roger Quadros
2022-09-30 13:28 ` Simon Glass
2022-09-30 14:00 ` Tom Rini
2022-09-30 20:17 ` Roger Quadros
2022-09-30 23:48 ` Simon Glass
2022-10-01 8:37 ` Roger Quadros
2022-10-03 1:10 ` Simon Glass
2022-09-28 12:11 ` [u-boot][PATCH 2/3] dt/bindings: memory: Add bindings for TI GPMC driver Roger Quadros
2022-09-28 12:11 ` [u-boot][PATCH 3/3] memory: Add " Roger Quadros
2022-09-29 17:51 ` [u-boot][PATCH 0/3] Introduce TI GPMC memory controller driver Tom Rini
2022-09-30 12:42 ` Roger Quadros
2022-09-30 12:44 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33934f40-f11a-9384-e6fe-968a5a48f0bb@kernel.org \
--to=rogerq@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox