public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
Date: Tue, 11 Dec 2018 07:25:07 +0100	[thread overview]
Message-ID: <3396602.VQmpVtay8p@phil> (raw)
In-Reply-To: <CF6EF305-5A57-44EC-A3FF-434EAD3238FE@theobroma-systems.com>

Hi Philipp,

Am Dienstag, 11. Dezember 2018, 00:12:40 CET schrieb Philipp Tomsich:
> + Heiko
> 
> > On 10.12.2018, at 01:56, Tom Rini <trini@konsulko.com> wrote:
> > 
> > On Mon, Dec 10, 2018 at 01:38:36AM +0100, Philipp Tomsich wrote:
> >> Tom,
> >> 
> >> On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
> >>> 
> >>> On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> >>>>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> >>>>> fdt relocation, so the initramfs works out of box.
> >>>>> 
> >>>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>>>> ---
> >>>>> 
> >>>>> include/configs/rv1108_common.h | 4 +++-
> >>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>>> 
> >>>> 
> >>>> Applied to u-boot-rockchip, thanks!
> >>> 
> >>> Ugh, sorry for not spotting this sooner.  Please don't disable
> >>> fdt/initrd relocation and instead use bootm_size.
> >> 
> >> Thanks for spotting this (just in time).
> >> I’ll drop it and rerun Travis for tomorrow’s PR.
> > 
> > Thanks.  And you might want to audit the rest of rockchip (and no, my
> > own house isn't 100% in order) as it looks like in general at least
> > you're using fdt_high to (good) set an upper bound but I think
> > bootm_size is more robust as we can set that and it covers fdt and
> > initrd if present (which not all rk3xxx_common.h are setting).
> 
> We may have a problem on rk3188 and rk3288 configurations. While I can
> convert these to bootm_size, I would have to do so blindly, as I don’t have
> any boards.
> 
> @Heiko: you have added the fdt_high and initrd_high in rk3188_common.h,
> do you have more info and would you have able to test this changed to
> bootm_size instead?

I think I more or less only copied that from rk3288 (adjusted for actual
ram-location) and I'm of course able to test changes you want to do on
rk3188 [Though only starting from thursday].

Heiko

  reply	other threads:[~2018-12-11  6:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 13:49 [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs Otavio Salvador
2018-12-06 13:46 ` Philipp Tomsich
2018-12-06 23:00   ` Otavio Salvador
2018-12-06 23:03     ` Philipp Tomsich
2018-12-10  0:01 ` [U-Boot] " Philipp Tomsich
2018-12-10  0:28   ` Tom Rini
2018-12-10  0:38     ` Philipp Tomsich
2018-12-10  0:56       ` Tom Rini
2018-12-10 23:12         ` Philipp Tomsich
2018-12-11  6:25           ` Heiko Stuebner [this message]
2018-12-10 12:01     ` Otavio Salvador
2018-12-10 12:23       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3396602.VQmpVtay8p@phil \
    --to=heiko@sntech.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox