From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F632C433F5 for ; Fri, 7 Oct 2022 12:39:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75E8E84E80; Fri, 7 Oct 2022 14:39:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DH4CRN5i"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08D9B84E8E; Fri, 7 Oct 2022 14:39:37 +0200 (CEST) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 64D1384E7B for ; Fri, 7 Oct 2022 14:39:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pj1-x1032.google.com with SMTP id gf8so4310401pjb.5 for ; Fri, 07 Oct 2022 05:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eMwmQssX4v1ROCsOVE0qk1ZKp78Kt2O4VPwx0Mkt1GI=; b=DH4CRN5iGlxU9MbVMjdWEkchKSji/TKjn8kz3anKAWkbGvY60SFa2KlafatKNuMAeS xljZ+RKINMACVRB/HFXLkn2m2WfvnA5loLbcjQA1dZG/kXbLnRck6NlI4GZFov9rsFWD frUqs4nAwt/5nag/eZloOOnpzInH+HVvWUeTK+ae2LEjoM0FfUKV8y8ldr6fIthQDAQd ezfRu+cPRPKQOoV3M5FmqcATUCTOpff2ggkSfL8kpkK+OOi64LJ4w1g9Rh0ifWXM9sFq ZtWCfA56wOIDULDt1IcCdYlM3nBZUWGZPJtKFGmZPbkUO9nN8XWZvvtNpmM9F9ZM8AF8 tlog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eMwmQssX4v1ROCsOVE0qk1ZKp78Kt2O4VPwx0Mkt1GI=; b=MJBfZ69yhl8mUmPsiecSCfGDvAIIa+EvXKRqbZy3XiRvfRdEnZTZrSTvWlpdtAultd VqJp/3GR1Ih3KWi9RKnCdcYvxqoW59iwG+ftZRlGcaBaqxCuuXACmnqzFLSjvt/eYxCj K6PVcWSN4ZZB2aORf3fKbNmj2a8vM33aGRy2K84xNcI37opd1k0elLacbw1V0HjrvVth 0HOMggfwetnhbiaO2c8oP7u0UCJ8iSa1maOaWnn+d0CL2n1n9CbN+dKn2Xgp0Ld+uxfV Q6q/guV1IvaNqWahX9ZFCjrY8q9odTFK7TuUdp5caMV4n3sIgXD88+MZ3ruvCY8/I62B D7JQ== X-Gm-Message-State: ACrzQf1L3v5vNjrHPlRzsBcyaDTzrdeY6YI/kfpGqnFvA8gu6JV8Ew6A dAVEI3H84cBrbwf31Wz5fQ4= X-Google-Smtp-Source: AMsMyM4m0m75zmFRz/IFS0rr4yAbRleax9qV3V/jX6Pp5AHGqhtfLMj2CoU3NKsLARZPphAm9m7opQ== X-Received: by 2002:a17:90b:4c02:b0:20a:7d26:149 with SMTP id na2-20020a17090b4c0200b0020a7d260149mr16673346pjb.134.1665146372694; Fri, 07 Oct 2022 05:39:32 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id n6-20020a17090a4e0600b0020ad26fa65dsm1354829pjh.56.2022.10.07.05.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 05:39:32 -0700 (PDT) Message-ID: <342911fe-0f22-178e-d44e-c2d3bd7d9ead@gmail.com> Date: Fri, 7 Oct 2022 21:39:29 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] mmc: Fix static checker warnings Content-Language: en-US To: Venkatesh Yadav Abbarapu , u-boot@lists.denx.de Cc: peng.fan@nxp.com, jh80.chung@samsung.com, git@xilinx.com References: <20220929045249.23842-1-venkatesh.abbarapu@amd.com> From: Jaehoon Chung In-Reply-To: <20220929045249.23842-1-venkatesh.abbarapu@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/29/22 13:52, Venkatesh Yadav Abbarapu wrote: > Correct pointer dereferencing check to be more consistent. > > Eliminate the below smatch warning: > drivers/mmc/mmc.c:3118 mmc_init_device() > warn: variable dereferenced before check 'm' (see line 3116) > > Signed-off-by: Venkatesh Yadav Abbarapu Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/mmc/mmc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 0b7c0be8cb..210703ea46 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -3113,10 +3113,12 @@ int mmc_init_device(int num) > } > > m = mmc_get_mmc_dev(dev); > - m->user_speed_mode = MMC_MODES_END; /* Initialising user set speed mode */ > - > if (!m) > return 0; > + > + /* Initialising user set speed mode */ > + m->user_speed_mode = MMC_MODES_END; > + > if (m->preinit) > mmc_start_init(m); >