Re: [PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file

Wolfgang Denk
2021-10-18T12:11:58Z

Dear Simon,

In message <20211015183321.v7.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote:
>
> Add a feature that brings in a .env file associated with the board
> config, if present. To use it, create a file in a board/<vendor>/env
> directory called <board>.env (or common.env if you want the same
> environment for all boards).

The cover letter does not mention a separate "env" directory - and
do we really need it? I will almost always contain just a single
file - so env/<board>.env is an just unnecessary complication.

> Also support += to allow variables to be appended to. This is needed when
> using the preprocessor.
...
> - Explain why variables starting with _ , and / are not supported
...
> - Move use of += to this patch
> - Explain that environment variables may not end in +

I feel all these restrictions should also be mentioned in the commit
message, not only in the code.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Command, n.:
Statement presented by a human and accepted by a computer
in such a manner as to make the human feel as if he is in control.