From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2125C433FE for ; Mon, 18 Oct 2021 12:11:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 356436128A for ; Mon, 18 Oct 2021 12:11:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 356436128A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E908833F2; Mon, 18 Oct 2021 14:11:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634559116; bh=oEr2x3/HTMtBO7oHOf/3PBdoGHpOprrbXWgPy0xdC/I=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=riQvBdLPmcEk7iBW8VA6/0Lh1j1Os03uR5wfvseKKmFx5ul3MMch8xj7EunuFZfLH eqOxAbH934JeEKrjbWeDP7hS6zt4zutAY6ZhoZf6wdolAh5n5PwWjPt1VnejusALj8 nDSLtOn51QezNxem/LVT/BVL88YLnbXA/2PqayaQ/ocA2TVulho0TNZT6/kQ9wlse0 czyX1du3kFVJ9YRhcoTX22R/iYFTLPAakG3ghbtnEeXMuXMynf9p6bUeX8J7h/9wmZ GSDg1HcuZEDnFW4muFrEgCR7egdsgJZgrvFhxNUBDX+Xj06g/Lzu+eWHBaZ5nv3vbx zB35xp9mTScQQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B57C6834B5 for ; Mon, 18 Oct 2021 14:11:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634559114; bh=oEr2x3/HTMtBO7oHOf/3PBdoGHpOprrbXWgPy0xdC/I=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=hXvJQYS3/b7Uo3lomqjDAwuw8cVzC6hqc0Akq1EjsOkLrcYnJl4ABkMtUHptSH229 RiMb30Jj1xorLGDzBVJcjb9m+8b5dqYU/T8Wxj4x7DGtOMBVhIhbcDTgOkc+yxZvDx YHbyiQKQPQpegkdYpxZtIlSN1tXgX8ARgl32AlVrWSOERPf2JQ4mKrCfLTv6MB8XyU Mboe0HD+AB8Dzxw5UqIrZSJYPQLXFOIekkPHBUvgmefgecwpwqEDpvU6i2Dkfm0CQS EP0+xkray+04W3SfnqxoIyRmzNUROhVj144KAs3f5M2TJmXbD8WCDqLUrEODkp/yJa /Tv6jPB2DHSew== Received: by janitor.denx.de (Postfix, from userid 108) id 06350A02B9; Mon, 18 Oct 2021 14:11:54 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id EE812A0091; Mon, 18 Oct 2021 14:11:47 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id A30F81E0F1B; Mon, 18 Oct 2021 14:11:47 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Rasmus Villemoes , Tom Rini , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211015183321.v7.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20211016003339.723169-1-sjg@chromium.org> <20211015183321.v7.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Fri, 15 Oct 2021 18:33:35 -0600." Date: Mon, 18 Oct 2021 14:11:47 +0200 Message-ID: <3496924.1634559107@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20211015183321.v7.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file in a board//env > directory called .env (or common.env if you want the same > environment for all boards). The cover letter does not mention a separate "env" directory - and do we really need it? I will almost always contain just a single file - so env/.env is an just unnecessary complication. > Also support += to allow variables to be appended to. This is needed when > using the preprocessor. ... > - Explain why variables starting with _ , and / are not supported ... > - Move use of += to this patch > - Explain that environment variables may not end in + I feel all these restrictions should also be mentioned in the commit message, not only in the code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Command, n.: Statement presented by a human and accepted by a computer in such a manner as to make the human feel as if he is in control.