Re: [PATCH] rockchip: rk3588-rock-5b: Remove USB-C controller from u-boot.dtsi

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Jonas,

On 2/13/26 6:42 PM, Jonas Karlman wrote:
> Hi Quentin,
> 
> On 2/13/2026 6:17 PM, Quentin Schulz wrote:
>> Hi Jonas,
>>
>> On 1/26/26 10:55 PM, Jonas Karlman wrote:
>>
>> [...]
>>
>>> -&usb_host0_xhci {
>>> -	dr_mode = "peripheral";
>>> -	maximum-speed = "high-speed";
>>
>> This is not set anymore after this patch is applied (dr_mode = otg and
>> no maximum-speed). Please keep this part as is and if actually fine to
>> remove, have a separate commit motivating the removal.
> 
> I disagree, these props may differ but the function they result in for
> U-Boot is the same, i.e. ums and rockusb commands can be used before and
> after this patch.
> 
> The board u-boot.dtsi included something minimal required to have ums
> and rockusb working, this can fully be replaced with upstream DT and
> U-Boot functionality stay the same. Something I think current commit
> message is already covering.
> 

I read the commit log as "code is already in upstream DTS so remove 
duplicated code", which isn't true as two properties aren't 
making/haven't made it.

At the very least, highlight those two changes and justify why it's fine 
not to have them anymore.

Can we enter SPL_DFU mode with dr_mode = otg? (I assume we could in the 
past?) You are the one who added those two properties in 2024 and it 
also wasn't really motivated back then, so why maximum-speed as well? 
And why is it fine to remove now?

Cheers,
Quentin