public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Tom Rini <trini@konsulko.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE
Date: Mon, 18 Oct 2021 15:56:06 +0200	[thread overview]
Message-ID: <3501738.1634565366@gemini.denx.de> (raw)
In-Reply-To: <20211016003339.723169-4-sjg@chromium.org>

Dear Simon,

In message <20211016003339.723169-4-sjg@chromium.org> you wrote:
> Add mention of this option this it does a similar thing to the text
> environment.
>
> Suggested-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
...

> +The format is the same as accepted by the mkenvimage tool: lines containing
> +key=value pairs, blank lines and lines beginning with # are ignored.

This is misleading. It can be read as: "lines containing key=value
pairs ... are ignored."

This reminds me of a sign in the door of a shop in Cornwall which
read: "No prams or dogs or food being eaten!"  I mean eating dogs is
bad enough, but eating prams? ? ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"There's only one way to have a happy marriage and as soon as I learn
what it is I'll get married again."                  - Clint Eastwood

  reply	other threads:[~2021-10-18 13:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-16  0:33 [PATCH v7 0/7] env: Allow environment in text files Simon Glass
2021-10-16  0:33 ` [PATCH v7 1/7] sandbox: Drop distro_boot Simon Glass
2021-10-16  0:33 ` [PATCH v7 2/7] doc: Move environment documentation to rST Simon Glass
2021-10-16  0:33 ` [PATCH v7 3/7] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-18 12:11   ` Wolfgang Denk
2021-10-16  0:33 ` [PATCH v7 4/7] sandbox: Use a text-based environment Simon Glass
2021-10-16  0:33 ` [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE Simon Glass
2021-10-18 13:56   ` Wolfgang Denk [this message]
2021-10-16  0:33 ` [PATCH v7 6/7] doc: Improve environment documentation Simon Glass
2021-10-16  0:33 ` [PATCH v7 7/7] bootm: Tidy up use of autostart env var Simon Glass
2021-10-18 12:06 ` [PATCH v7 0/7] env: Allow environment in text files Wolfgang Denk
2021-10-18 18:12   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3501738.1634565366@gemini.denx.de \
    --to=wd@denx.de \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox