From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D73C433EF for ; Mon, 18 Oct 2021 13:56:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEC0F60EFE for ; Mon, 18 Oct 2021 13:56:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DEC0F60EFE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 202F882BE5; Mon, 18 Oct 2021 15:56:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634565377; bh=xgDc0UgQnGtnuNcHjo0alsRQIY+4kZUqoNQltGUPJNo=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JtpLlOO7c+XbXZIgZB/Ig1vX42yL3o3y4tvlfwgZC7apLY9ag5OdmfdOVyFjdG8uQ 9BBS6ONZfXa4QgbgifwBsY1iGghVYnm7k+GyuNONwSMNVZdwiE/Gq7snCDlte0dNOI 5Q3ihk1wlqX3WJ0AgWHG44q7eQR0HqeIDfKriSsCkudGbrCOtO+PHuSJb/wfSvLVlV 0RbyjmdwJDdCyVsyaCXgkRJPR2iQQv3GB+ocLE9UDNSxT1W7MXaV4P9bT9yBbL60Iz +dIOPmB5yzFXk02EjwKnErlKaUYwkpnl/J2PRyWt7e0ffbRdFy1gz/q+Y1sob5Qc2k SIIIL0Jbgoynw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 31A6280ECC for ; Mon, 18 Oct 2021 15:56:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634565375; bh=xgDc0UgQnGtnuNcHjo0alsRQIY+4kZUqoNQltGUPJNo=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=m/FCfHEdSNmfghC2zJS97IcYS6yGjSH2IGH9eONQvist95qUkHkG2EFp16ydbCD/8 GvUaWyKwiZyIwYWhurTOrGgQvF3Jm1DOeeMTNDg0MQf+cI34ghxkosu2//wcLmFieA gOpg6FYAMhlL5ZoeWrB+N+r9AF5r+FyutDBK5TJJJLg6TGC7Hpy19N6pmV9nCOxEHq yQ7dN2Xg1wsRl/99AmKyQvufEcBn9h/YK71OZwBgsu0oxuf7R9AlqM1oEcPzTRz/P9 eOs1eaZLeGLuZCl0ylaZoc5PGStxcqZm1iLaUZA+AH9dcXskUMyNpVeRlppHSKlDce Uu1KPcQQNPXPA== Received: by janitor.denx.de (Postfix, from userid 108) id B9496A02B9; Mon, 18 Oct 2021 15:56:14 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 6E3ECA0069; Mon, 18 Oct 2021 15:56:06 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 442D11E0F1B; Mon, 18 Oct 2021 15:56:06 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Rasmus Villemoes , Tom Rini , Heinrich Schuchardt From: Wolfgang Denk Subject: Re: [PATCH v7 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211016003339.723169-4-sjg@chromium.org> References: <20211016003339.723169-1-sjg@chromium.org> <20211016003339.723169-4-sjg@chromium.org> Comments: In-reply-to Simon Glass message dated "Fri, 15 Oct 2021 18:33:37 -0600." Date: Mon, 18 Oct 2021 15:56:06 +0200 Message-ID: <3501738.1634565366@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20211016003339.723169-4-sjg@chromium.org> you wrote: > Add mention of this option this it does a similar thing to the text > environment. > > Suggested-by: Rasmus Villemoes > > Signed-off-by: Simon Glass ... > +The format is the same as accepted by the mkenvimage tool: lines containing > +key=value pairs, blank lines and lines beginning with # are ignored. This is misleading. It can be read as: "lines containing key=value pairs ... are ignored." This reminds me of a sign in the door of a shop in Cornwall which read: "No prams or dogs or food being eaten!" I mean eating dogs is bad enough, but eating prams? ? ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "There's only one way to have a happy marriage and as soon as I learn what it is I'll get married again." - Clint Eastwood