From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0A9C433FE for ; Mon, 18 Oct 2021 14:10:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FB1560EFE for ; Mon, 18 Oct 2021 14:10:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9FB1560EFE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 788CF82DB3; Mon, 18 Oct 2021 16:10:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634566247; bh=kvjOXCO09LCMR9KMlHn98h1zru/7MnGLcSAbmtrFId8=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=y/u7/Ss/EBr13XhlQxEHPQc/BUXvoYdV2hQcgzPayFDwHzENOePKFQTawnNcZc057 S7tNweNZMmT/NGfbyHIHp6d5+dAlpXsz0R47gJ4g6dkU3tDsxOnAVh0U60rsawK4Yb p5il0EFxOi6nQq/Hj2AqyK6W6LTO9z9B6YE8mIRFckkX7zstyguwjfUFnTQ4F5+1BA reFCEAB+2YPkSDHYCIPjrr1Zuygp2c9i00r1LracvuYora90K6ipDul8LX0NDZmY1b UJghJv/xGnrn2FZ4cOQri7/LaT8TJvhqy0NSzT+DssSTm/+Hasst9WkQk1Gvands/S lXXnekw1rqPlw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 5F2E382D85 for ; Mon, 18 Oct 2021 16:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634566244; bh=kvjOXCO09LCMR9KMlHn98h1zru/7MnGLcSAbmtrFId8=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=jgCxygnezRzcA7zhzF55kXHDUhcZKAFq3QVi7tSyxWvzp8z+S2YJYHo40CQBcK1v1 aw79PdghapydGdMGCq7ocm3A+H1FEoRbtqRK+aZA17TYol/Ze1hMgHHy79wD1Y9bWV R2rHF8IwLaGzdl+SPpEJ44+Rh8BSY5f67L76bvQoL01AblkwIBmtehvm3Fg7/BzZNP dHRCgJMmnHtCgCSsafddKeDPLKINYDMKr+pN/zxWtJiEBfgfSVXeNZPsQmtffGFwx8 uq4bYx6zBTGPCR6rK+hqzYv8k7vne6F+IlsjtQdT1HYbO3dYFqyJawksCor2OXzrHd OUWa/DtV5GOFQ== Received: by janitor.denx.de (Postfix, from userid 108) id 1072DA0277; Mon, 18 Oct 2021 16:10:44 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 1C713A0069; Mon, 18 Oct 2021 16:10:35 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id BF8FB1E0F1B; Mon, 18 Oct 2021 16:10:34 +0200 (CEST) To: Tom Rini cc: Simon Glass , U-Boot Mailing List , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v6 4/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211018133728.GQ7964@bill-the-cat> References: <20211014182257.468649-1-sjg@chromium.org> <20211014122254.v6.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3341802.1634308345@gemini.denx.de> <3496103.1634558337@gemini.denx.de> <20211018133728.GQ7964@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Mon, 18 Oct 2021 09:37:28 -0400." Date: Mon, 18 Oct 2021 16:10:34 +0200 Message-ID: <3502270.1634566234@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211018133728.GQ7964@bill-the-cat> you wrote: > > > And please see also my comments about changing the autostart > > functionality for the user. > > Perhaps we should just make "+" an illegal character in the variable > name, for consistency? And break backward compatibility? I'd rather see a better definition of the syntax of the environment files, plus maybe a more powerful parser. I mean, there is no technical reason to forbid the '+' character - and then it's only at the end of the variable name. Hm... I can't find it right now but did I not also read about other restrictions to variable names, like they must noch begin with '_' when using this new tool? I feel it is wrong to place new restrictions on something that was constant for 21 years, just because our parser cannot parse it... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "You ain't experienced..." "Well, nor are you." "That's true. But the point is ... the point is ... the point is we've been not experienced for a lot longer than you. We've got a lot of experience of not having any experience." - Terry Pratchett, _Witches Abroad_