From: Robey, Caleb <c-robey@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXTERNAL] Re: [PATCH 5/5] board: ti: beagleboneai: enable in am57xx_evm_defconfig
Date: Thu, 21 Nov 2019 16:00:03 +0000 [thread overview]
Message-ID: <3504dd88bc9c485b8a80945bec3ad2f5@ti.com> (raw)
In-Reply-To: <20191121151228.GD971@bill-the-cat>
> -----Original Message-----
> From: Tom Rini [mailto:trini at konsulko.com]
> Sent: Thursday, November 21, 2019 9:12 AM
> To: Vutla, Lokesh
> Cc: Robey, Caleb; u-boot at lists.denx.de; Jason Kridner; Erdahl, Michael;
> Kridner, Jason; Kever Yang; Jagan Teki; Michal Simek; Stefan Roese; Neil
> Armstrong; Masahiro Yamada; Fabio Estevam; Troy Kisky; Rizvi, Mohammad
> Faiz Abbas; Dannenberg, Andreas; Hiblot, Jean-Jacques; Heiko Schocher; Joe
> Hershberger; Simon Glass; Sam Protsenko; Bajjuri, Praneeth; Ruslan
> Trofymenko; Alistair Strachan; Davis, Andrew
> Subject: [EXTERNAL] Re: [PATCH 5/5] board: ti: beagleboneai: enable in
> am57xx_evm_defconfig
>
> On Thu, Nov 21, 2019 at 09:15:03AM +0530, Lokesh Vutla wrote:
> >
> >
> > On 21/11/19 3:39 AM, Caleb Robey wrote:
> > > Adding the configurations to the evm_defconfig file
> > >
> > > Signed-off-by: Jason Kridner <jdk@ti.com>
> > > Signed-off-by: Caleb Robey <c-robey@ti.com>
> > >
> > > ---
> > > configs/am57xx_evm_defconfig | 2 +- include/environment/ti/boot.h
> > > | 4 +++-
> > > 2 files changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/configs/am57xx_evm_defconfig
> > > b/configs/am57xx_evm_defconfig index 588e58947d..f59305794c 100644
> > > --- a/configs/am57xx_evm_defconfig
> > > +++ b/configs/am57xx_evm_defconfig
> > > @@ -38,7 +38,7 @@ CONFIG_CMD_BCB=y
> > > CONFIG_OF_CONTROL=y
> > > CONFIG_SPL_OF_CONTROL=y
> > > CONFIG_DEFAULT_DEVICE_TREE="am572x-idk"
> > > -CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1
> am57xx-beagle-x15-revc am572x-idk am571x-idk am574x-idk"
> > > +CONFIG_OF_LIST="am57xx-beagle-x15 am57xx-beagle-x15-revb1
> am57xx-beagle-x15-revc am5729-beagleboneai am572x-idk am571x-idk
> am574x-idk"
> > > CONFIG_ENV_IS_IN_MMC=y
> > > CONFIG_SYS_REDUNDAND_ENVIRONMENT=y
> > > CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
> > > diff --git a/include/environment/ti/boot.h
> > > b/include/environment/ti/boot.h index 684a744f31..d6f153c934 100644
> > > --- a/include/environment/ti/boot.h
> > > +++ b/include/environment/ti/boot.h
> > > @@ -10,7 +10,7 @@
> > > #define __TI_BOOT_H
> > >
> > > #ifndef CONSOLEDEV
> > > -#define CONSOLEDEV "ttyS2"
> > > +#define CONSOLEDEV "ttyS0"
> > > #endif
> >
> > This will fail kernel to boot when using the default args. Can you try
> > updating this dynamically?
>
> Yes, am57xx_evm will need to perhaps leverage CONFIG_PREBOOT to run
> something to dynamically update the console environment variable at run
> time.
>
This line seems to be working:
CONFIG_PREBOOT="if board_name am5729_beagleboneai; then setenv console ttyS0,115200; fi"
Any concerns with that? I removed the change from boot.h and
tested with the am5729 IDK and beagleboneai board. Everything seems to be working just fine.
Best,
Caleb
> --
> Tom
next prev parent reply other threads:[~2019-11-21 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 22:09 [U-Boot] [PATCH 0/5] board: ti: beagleboneai: add initial support Caleb Robey
2019-11-20 22:09 ` [U-Boot] [PATCH 1/5] board: ti: beagleboneai: emmc read changes Caleb Robey
2019-11-20 22:09 ` [U-Boot] [PATCH 2/5] board: ti: beagleboneai: add initial support Caleb Robey
2019-11-21 3:43 ` Lokesh Vutla
2019-11-20 22:09 ` [U-Boot] [PATCH 3/5] board: ti: beagleboneai: IODELAY and pinmux changes Caleb Robey
2019-11-20 22:09 ` [U-Boot] [PATCH 4/5] board: ti: beagleboneai: add dts file Caleb Robey
2019-11-20 22:09 ` [U-Boot] [PATCH 5/5] board: ti: beagleboneai: enable in am57xx_evm_defconfig Caleb Robey
2019-11-21 3:45 ` Lokesh Vutla
2019-11-21 15:12 ` Tom Rini
2019-11-21 16:00 ` Robey, Caleb [this message]
2019-11-21 16:34 ` [U-Boot] [EXTERNAL] " Tom Rini
2019-11-21 22:28 ` Robey, Caleb
2019-11-21 23:07 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3504dd88bc9c485b8a80945bec3ad2f5@ti.com \
--to=c-robey@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox