public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Tom Rini <trini@konsulko.com>,
	Joe Hershberger <joe.hershberger@ni.com>
Subject: Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file
Date: Tue, 19 Oct 2021 12:57:52 +0200	[thread overview]
Message-ID: <3561063.1634641072@gemini.denx.de> (raw)
In-Reply-To: <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid>

Dear Simon,

In message <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote:
>
> The environment variables should be of the form "var=value". Values can
> extend to multiple lines. See the README under 'Environment Variables:'
> for more information and an example. Note that environment variables may
> not end in + 

This makes not really clear that the restriction is on the name (and
not the value) of the environment variable.

> but can start with other strange characters, including
> underscore, comma and slash.

I would omit this as it does not provide any relevant information
here, and in addition it is misleading as it could be interpreted
that such characters are only legal at the start of the variable
name. But you can do:

=> setenv .-^-. foo
=> printenv .-^-.
.-^-.=foo



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A secure program has to be robust: it  must  be  able  to  deal  with
conditions  that "can't happen", whether user input, program error or
library/etc. This is basic damage  control.  Buffer  overflow  errors
have nothing to do with security, but everything with stupidity.
                 -- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>

  reply	other threads:[~2021-10-19 10:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 18:13 [PATCH v8 0/8] env: Allow environment in text files Simon Glass
2021-10-18 18:13 ` [PATCH v8 1/8] binman: Allow timeout to occur in the image or its section Simon Glass
2021-10-19 14:19   ` Marek Behún
2021-10-31 12:57     ` Simon Glass
2021-10-18 18:13 ` [PATCH v8 2/8] sandbox: Drop distro_boot Simon Glass
2021-10-19 14:20   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 3/8] doc: Move environment documentation to rST Simon Glass
2021-10-19 14:21   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-19 10:57   ` Wolfgang Denk [this message]
2021-10-19 14:07   ` Tom Rini
2021-10-19 14:11     ` Simon Glass
2021-10-19 14:25       ` Tom Rini
2021-10-19 15:31         ` Simon Glass
2021-10-19 16:20           ` Wolfgang Denk
2021-10-19 16:24             ` Simon Glass
2021-10-19 16:30               ` Tom Rini
2021-10-19 16:39                 ` Simon Glass
2021-10-19 16:44                   ` Tom Rini
2021-10-19 18:21                     ` Simon Glass
2021-10-21  9:10                   ` Wolfgang Denk
2021-10-21  9:05                 ` Wolfgang Denk
2021-10-21  9:02               ` Wolfgang Denk
2021-10-19 16:05       ` Wolfgang Denk
2021-10-19 16:14         ` Simon Glass
2021-10-19 15:57     ` Wolfgang Denk
2021-10-19 15:11   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 5/8] sandbox: Use a text-based environment Simon Glass
2021-10-19 14:32   ` Marek Behún
2021-10-19 15:52     ` Simon Glass
2021-10-19 16:07       ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 6/8] doc: Mention CONFIG_DEFAULT_ENV_FILE Simon Glass
2021-10-19 14:34   ` Marek Behún
2021-10-19 15:52     ` Simon Glass
2021-10-19 16:07       ` Marek Behún
2021-10-19 18:20         ` Simon Glass
2021-10-18 18:13 ` [PATCH v8 7/8] doc: Improve environment documentation Simon Glass
2021-10-19 14:36   ` Marek Behún
2021-10-18 18:13 ` [PATCH v8 8/8] bootm: Tidy up use of autostart env var Simon Glass
2021-10-19 14:38   ` Marek Behún
2021-10-19 10:48 ` [PATCH v8 0/8] env: Allow environment in text files Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3561063.1634641072@gemini.denx.de \
    --to=wd@denx.de \
    --cc=joe.hershberger@ni.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox