From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C1BC433EF for ; Tue, 19 Oct 2021 10:58:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2FF561154 for ; Tue, 19 Oct 2021 10:58:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2FF561154 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1624B82D5B; Tue, 19 Oct 2021 12:58:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634641083; bh=PWz+o4dXY3bn5SpW2M59swXiZU4sJb9O6I/Q22V5Tqg=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IQpAIIeqIp703G2D4Px/bFBrhEtOozpBtIQ2Jb4coJP4htm0YIvpaUzSNfkDOI909 st504lZbaR3YZGbtGFqPSDbdj5YVQL+3JiqgDPGmHkt+IOxE+uPKUrYgnWIAE2o0ZY jMastk7gpQTV9hc0MvcUSH49glQG1NV4ADzxWwEN2PSYRfAHSHDil5QVvwgAZWBF3W kUu5abZJfTdFNR6bQD2LtjQnb33OuW8yRRLfOi+AsEKodZSaiW+kgpjpav2hj723x2 h7imB5XGMnODl6EmfzWaw6PG3Hf5YVPwrbyQ0OIp9F1BVluRvhUkyGIcymqBnBTgST s2+j81wn0K3ig== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 1A21B81F0D for ; Tue, 19 Oct 2021 12:58:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634641081; bh=PWz+o4dXY3bn5SpW2M59swXiZU4sJb9O6I/Q22V5Tqg=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=CtDfzZeP1dXzbavBznGaTDbyzxmJYZPOA1uQy5rMDP2xYYNCYR+hf8kNtNUacUxf6 5suXlruy2ukLrlBMkJczWSDVr6fZD2wkjjMMara88rV8Qk06a/mdgEEDHOk+UgAftm 7kWU4xxIhejA60KfsVFJmCl+Y4rDoYZRdNBtQ5PXKrF1vxMvQOPi6bI4imZhlZDnpu XBiuNjhBeQ4l4oXXszeOz8xxByGUADfYO1wNK8LxswZpwI5dgMImY6x+tpJW/nRnqG ABsbv72D4dKUSr79vkuRKtiQ+VDgxTnJ+QwIciut6sBKAOexYywQDl2NkoK4AGJCZv RNcaDdjXXxAkg== Received: by janitor.denx.de (Postfix, from userid 108) id 9AB6BA0215; Tue, 19 Oct 2021 12:58:00 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id A244FA0057; Tue, 19 Oct 2021 12:57:52 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 4DFA41E0F1B; Tue, 19 Oct 2021 12:57:52 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20211018181322.1181847-1-sjg@chromium.org> <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Mon, 18 Oct 2021 12:13:18 -0600." Date: Tue, 19 Oct 2021 12:57:52 +0200 Message-ID: <3561063.1634641072@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > > The environment variables should be of the form "var=value". Values can > extend to multiple lines. See the README under 'Environment Variables:' > for more information and an example. Note that environment variables may > not end in + This makes not really clear that the restriction is on the name (and not the value) of the environment variable. > but can start with other strange characters, including > underscore, comma and slash. I would omit this as it does not provide any relevant information here, and in addition it is misleading as it could be interpreted that such characters are only legal at the start of the variable name. But you can do: => setenv .-^-. foo => printenv .-^-. .-^-.=foo Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de A secure program has to be robust: it must be able to deal with conditions that "can't happen", whether user input, program error or library/etc. This is basic damage control. Buffer overflow errors have nothing to do with security, but everything with stupidity. -- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>