From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF00C47080 for ; Mon, 31 May 2021 17:16:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12CF0610C9 for ; Mon, 31 May 2021 17:16:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12CF0610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BCF4B82D62; Mon, 31 May 2021 19:16:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UxDp0uji"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B1E9D82E88; Mon, 31 May 2021 19:16:31 +0200 (CEST) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB80082D61 for ; Mon, 31 May 2021 19:16:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-oi1-x236.google.com with SMTP id j75so12874593oih.10 for ; Mon, 31 May 2021 10:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=end0pghmDMzyhvrTeAI86CYk0BMhGblehOZa5tZhHXE=; b=UxDp0uji0yrRV+by48k8D83tnM5lpCq2PDQqiFqgszatE+pPHDElqvrjj8Dif1O7Cp BxaPl98GJ7drmaypSMN/60ljFPSoOskMRIMPlpT5ay+8151ndtzvF3PAxjZ92Yb9LSSs m+3w0IC3PkA5zIcTA9y/stGHvipor3ltsaR/OTLwkUQBOpGp9klK+8ksceyXr5y/Pyi6 VN/PoNypyYEBnDJ9nzILIsHPNUBspA6SBj94fMX9GlzHEMmpUtJYlo3L4I/KtrBHrnZ3 MCaY3ZhJUhgAZJMtmMx3gPLr1vamf1lMNQy+xT4dSDJkzzaDTW5hkJSOqvEyxqBfLprX 6yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=end0pghmDMzyhvrTeAI86CYk0BMhGblehOZa5tZhHXE=; b=cI6hjA8iz8K1Vb3U6s4SAzZ3FiU5hgk/QZouSwW0EbmypPLH1QstZLkQClx7d7ru/K wQrRqvgPP6uSnG7DIsX7KkeM+I9/jx7gXrdhe5K30WMxfNMDZIJq9VFv2TJ01dFbyojH iSoYSqEPMjTXv7YG8FmDUq3QnpAHHKOwPgaBmaU1IdVhv0IPO3/PKpaWW+4vUhONbSBJ nSr6LkQzR47IbRt24szt6eCX+SkJn7AXgtNBdiDYcyApwO+HIFY7xdFJQj/qHBatijQR JfMcbgoP6ZNIuru+QmF6/y8hLSHFzDjewrfH4vKurJQUnOq2L/LU4eBF6GRR8YBRgCkq 96pw== X-Gm-Message-State: AOAM532GHTjZHeTvWyeTkj/KsCu93ljzEjOlF4XLGmvov9QvtmuX4ivN 3gBg23300mzZTXTMXlJ0sxo= X-Google-Smtp-Source: ABdhPJyRpn0MI5YacpSahUxdVfuComferjka9Vvpx6SZwtlIN7gFKYrKje3c2FwxCylXmXJv8vQifA== X-Received: by 2002:aca:1b0f:: with SMTP id b15mr94541oib.178.1622481387248; Mon, 31 May 2021 10:16:27 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id s76sm2892115oie.50.2021.05.31.10.16.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 May 2021 10:16:26 -0700 (PDT) From: "Alex G." Subject: Re: [PATCH v3 3/5] arm: stm32mp: Implement support for TZC 400 controller To: Patrick DELAUNAY , u-boot@lists.denx.de, trini@konsulko.com Cc: sjg@chromium.org, etienne.carriere@linaro.org References: <20210415164829.2302939-1-mr.nuke.me@gmail.com> <20210415164829.2302939-4-mr.nuke.me@gmail.com> Message-ID: <35f580dc-11a4-4f84-ee54-4a7e2ee5b9ae@gmail.com> Date: Mon, 31 May 2021 12:16:26 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Patrick, On 5/28/21 4:59 AM, Patrick DELAUNAY wrote: > Hi, > > Any reason to prefer  uint16_t and uint32_t ? I use standard C types. u32, _u32, and __u32 are non-standard, and they have different meanings depending on how they're used. I avoid them for this reason. Alex > See checkpatch warning > > arch/arm/mach-stm32mp/include/mach/tzc.h:24: check: Prefer kernel type > 'u16' over 'uint16_t' > arch/arm/mach-stm32mp/include/mach/tzc.h:25: check: Prefer kernel type > 'u16' over 'uint16_t' > arch/arm/mach-stm32mp/tzc400.c:41: check: Prefer kernel type 'u16' over > 'uint16_t' > arch/arm/mach-stm32mp/tzc400.c:52: check: Prefer kernel type 'u32' over > 'uint32_t' > arch/arm/mach-stm32mp/tzc400.c:81: check: Prefer kernel type 'u32' over > 'uint32_t' > arch/arm/mach-stm32mp/tzc400.c:82: check: Prefer kernel type 'u32' over > 'uint32_t' > arch/arm/mach-stm32mp/tzc400.c:93: check: Prefer kernel type 'u32' over > 'uint32_t' > arch/arm/mach-stm32mp/tzc400.c:94: check: Prefer kernel type 'u32' over > 'uint32_t' > arch/arm/mach-stm32mp/tzc400.c:113: check: Prefer kernel type 'u32' over > 'uint32_t' > > But except these remarks: > > Reviewed-by: Patrick Delaunay > > Thanks > Patrick >