[U-Boot] bug in ubifs

[U-Boot] bug in ubifs

[tcremel at alphabot.fr]

 Some bugs I found while using uboot.
 -------------------------------------------------------
  BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
common/cmd_ubifs.c     from line  59 add 2 lines
           ubifs_initialized = 1;
       }
 +     // tcremel at alphabot.fr : ubifs_mounted is never reset if the
previous mount failed. This bring my system to hang as it tries to
unmount a non-existing mount point  
 +     ubifs_mounted = 0;
       ret = ubifs_mount(vol_name);
       if (ret)
           return -1;
 -------------------------------------------------------
  BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
fs/ubifs/super.c   from line 1189 add 2 lines
       ret = ubifs_get_sb(&ubifs_fs_type, flags, name, data, mnt);
       if (ret) {
           printf("Error reading superblock on volume '%s'!n", name);
 + // tcremel at alphabot.fr :  added as if the filesystem does not
exist, the previous system is partly kept.  This bring my system to
hang as it has some superblocks informations from another FS
 +         ubifs_sb=NULL;
           return -1;
       }
 -------------------------------------------------------
 in BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px;
}fs/ubifs/ubifs.c   from line 42 modified 1 line to 5
                  unsigned char *out, size_t *out_len)
   {
       unsigned long len = in_len;
 !     return zunzip(out, *out_len, (unsigned char *)in, &len, 0, 0);
   }
   /* Fake description object for the "none" compressor */
 >>>>>>>>>>>>>>>>>
                  unsigned char *out, size_t *out_len)
   {
       unsigned long len = in_len;
 ! // tcremel at alphabot.fr : the return length should not be lost.
 !     int res;
 !     res=zunzip(out, *out_len, (unsigned char *)in, &len, 0, 0);
 !     *out_len=len;
 !     return res;
   }
 -------------------------------------------------------
 Hope this helps ! :)
http://www.alphabot.fr

[U-Boot] bug in ubifs

[Stefan Roese]

Hi,

On Friday 29 January 2010 14:58:19 tcremel at alphabot.fr wrote:
>  Some bugs I found while using uboot.
>  -------------------------------------------------------
>   BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
> common/cmd_ubifs.c     from line  59 add 2 lines
>            ubifs_initialized = 1;
>        }
>  +     // tcremel at alphabot.fr : ubifs_mounted is never reset if the
> previous mount failed. This bring my system to hang as it tries to
> unmount a non-existing mount point

This is pretty much unreadable. Could you please re-send your mail in a 
different way. Best would be a proper patch that can be applied using git.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] bug in ubifs

[Wolfgang Denk]

Dear tcremel at alphabot.fr,

In message <36396.1264773499@alphabot.fr> you wrote:
>
>  Some bugs I found while using uboot.
>  -------------------------------------------------------
>   BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }in
> common/cmd_ubifs.c     from line  59 add 2 lines
>            ubifs_initialized = 1;
>        }
>  +     // tcremel at alphabot.fr : ubifs_mounted is never reset if the
> previous mount failed. This bring my system to hang as it tries to
> unmount a non-existing mount point  
>  +     ubifs_mounted = 0;
>        ret = ubifs_mount(vol_name);
>        if (ret)
>            return -1;
>  -------------------------------------------------------
...

Stefan had asked you to resubmit this (totallyunreadable!) message as

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Man is the best computer we can put aboard a spacecraft ...  and  the
only one that can be mass produced with unskilled labor.
                                                  - Wernher von Braun