From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ajay Bhargav <ajay.bhargav@einfochips.com>
Date: Wed, 10 Aug 2011 14:02:47 +0530 (IST)
Subject: [U-Boot] [PATCH v3 2/2] gpio: Add GPIO driver for Marvell SoC
	Armada100
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19FE39F3EE@SC-VEXCH4.marvell.com>
Message-ID: <36548756.72763.1312965167527.JavaMail.root@ahm.einfochips.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


----- "Prafulla Wadaskar" <prafulla@marvell.com> wrote:

> You should move entire contents of gpio.h in mvgpio.h within #ifdef
> CONFIG_SHEEVA_88SV331xV5, so just mvgpio.c,mvgpio.h,Makefile will add
> armada100 gpio driver support in more generic way.
> 
> > I have no idea about number of banks in other SOCs with same core.
> 
> No need to worry, at this moment this driver will be supporting
> 88SV331xv5 core only.
> 
> Regards..
> Prafulla . .
> 

I think its better to just keep Armada100 related stuff in gpio.h and
I will do the following suggested changes.

> > {
> >   Const unsigned int offset[4] = {0, 4, 8, 0x100}; /* gpio register
> > bank offsets */
> >   return (struct gpio_reg *)(ARMD1_GPIO_BASE + offset[bank]);
> > }

Regards,
Ajay Bhargav