From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA3A3C3DA59 for ; Mon, 22 Jul 2024 10:37:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F13887FED; Mon, 22 Jul 2024 12:37:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JmuR9j6e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4E0C887FED; Mon, 22 Jul 2024 12:37:36 +0200 (CEST) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B1FB987EDC for ; Mon, 22 Jul 2024 12:37:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=maximmosk4@gmail.com Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-52efd530a4eso2328767e87.0 for ; Mon, 22 Jul 2024 03:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721644653; x=1722249453; darn=lists.denx.de; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uUTQLkPheY9kftKbcwiqegxGdTAEGCLvLDmTfoy9HIw=; b=JmuR9j6ek3L5J0vi25LHwLnJ7ZTveo7tslUug+ik+lT1hJfQAfLWGcxgXTdh92A0Gd dBI3E5M8jSbENYcE25jgQ7k3faEe6eFYxp12iQme2dMLAqzhkLtm6bShVoNlbFIv1sNQ CMbg7JERKiMKmgJBDAmEZBwo0IpdN/QAFSdRXM1lZPIyagN00CbDqSaPHkw9jQOSIPrz /kPfjJ51V9b8xyPzgfPhpdP88ukscTiYT2afgEBrNA3voxDCtRbI0pB5+2wOvW8H1VfZ V56r+ZeNgi4upB7Y//ZmeBzoSXnzUxLrYR8xqw2rpL6xNm6QO0/374uuc3LyreWSXG0J ludw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721644653; x=1722249453; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uUTQLkPheY9kftKbcwiqegxGdTAEGCLvLDmTfoy9HIw=; b=h3GAEMtT97tyDQ5nQM8ZNX2FUCFtQM7EqJZv9s6Dv7woMB8v0ynshYnO4L7hdmng4q 3cbCn6vObBLgEctL9qCtQGXCraos4grjhmKuMOBFvmAxLmtdPG7iU0aZN+p7/m5pTsdN NB9tIe3cW2Y05d9vijSP/skgVJnpTN6DCEeDiHimEEYkpTIpGmCOsatdZhGF5hngFUWi 4vNnfo0ZpGXkvNkH2cexJq9IBhExSiPqT1OgQRxlfHanPnHKTvyNtskSsPcxuAZz8ohI HXQ5sf+veEg5gR69DXC+qgKHOhowuZjBPMKHJNAcy1qPamqBfm+ByfVFYv5ttltc5Ige jLpw== X-Forwarded-Encrypted: i=1; AJvYcCU65dj7y5A/Q+LSwHlt9gE7aeiKTsROtece6v2+GeQDK8hC9KEHpQIfo9C5Ln1XF5ZArVdOe6GlL9rTOG/MhUYkIOIAqQ== X-Gm-Message-State: AOJu0Yxlu55V6W44d3rl0muwvl32I9ZeSoRBRdVjJmB1fVkcmHyYxv2o 2agkuGxEAHO5NjrcECKUxIecACTluRFMWteqm5Xz1RyTm3cKUjg7 X-Google-Smtp-Source: AGHT+IEkWHVbyEX/jTQosoqa5g4EpD6NxB4EW0Ml3/6eBzj5T93XyDGORw5bfbXJHpNpUCJz6m55GQ== X-Received: by 2002:a05:6512:3c89:b0:52f:2ea:499f with SMTP id 2adb3069b0e04-52f02ea4badmr1908705e87.24.1721644652585; Mon, 22 Jul 2024 03:37:32 -0700 (PDT) Received: from [192.168.1.6] (109-252-15-116.nat.spd-mgts.ru. [109.252.15.116]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52f59923ac1sm237166e87.258.2024.07.22.03.37.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jul 2024 03:37:32 -0700 (PDT) Message-ID: <36573ae6-b9f2-49ed-98a0-9e041c865ca7@gmail.com> Date: Mon, 22 Jul 2024 13:37:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] board: rockchip: add Radxa ROCK 3 Model C To: Jonas Karlman , Maxim Moskalets , Kever Yang Cc: trini@konsulko.com, sjg@chromium.org, u-boot@lists.denx.de References: <20240722074907.28507-1-Maxim.Moskalets@kaspersky.com> Content-Language: en-US From: "Maxim M. Moskalets" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 22.07.2024 13:28, Jonas Karlman wrote: > Hi Maxim, > > On 2024-07-22 09:49, Maxim Moskalets wrote: >> Based on rock-3a-rk3568_defconfig. >> Tesetd on v1.31 revision. > nit: small typo s/Tesetd/Tested/ > >> Board Specifications: >> - Rockchip RK3566 >> - 1/2/4GB LPDDR4 2112MT/s >> - eMMC socket >> - uSD card slot >> - M.2 2230 Connector >> - GbE LAN with POE >> - 3.5mm jack with mic >> - HDMI 2.0, MIPI DSI/CSI >> - USB 3.0 Host/OTG, USB 2.0 Host >> - 40-pin GPIO expansion ports >> >> Signed-off-by: Maxim Moskalets >> Suggested-by: Jonas Karlman >> --- >> v3: >> add suggested by Jonas Karlman in >> https://lore.kernel.org/all/bbb81dd1-e318-423d-8258-db7556ce6850@kwiboo.se/ >> v2: >> rebase to updated upstream dts >> --- >> MAINTAINERS | 7 ++ >> arch/arm/dts/rk3566-rock-3c-u-boot.dtsi | 10 +++ >> configs/rock-3c-rk3566_defconfig | 97 +++++++++++++++++++++++++ >> doc/board/rockchip/rockchip.rst | 1 + >> 4 files changed, 115 insertions(+) >> create mode 100644 arch/arm/dts/rk3566-rock-3c-u-boot.dtsi >> create mode 100644 configs/rock-3c-rk3566_defconfig >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index a6e47e8a217..b87077d3adb 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -492,6 +492,13 @@ F: include/configs/owl-common.h >> F: configs/bubblegum_96_defconfig >> F: configs/cubieboard7_defconfig >> >> +ARM RADXA ROCK 3 MODEL C >> +M: Jonas Karlman >> +M: Maxim Moskalets >> +S: Maintained >> +F: arch/arm/dts/rk3566-rock-3c-u-boot.dtsi >> +F: configs/rock-3c-rk3566_defconfig > This should possible move to board/rockchip/evb_rk3568/MAINTAINERS same > as other boards using the evb_rk3568 target. > >> + >> ARM RENESAS RMOBILE/R-CAR >> M: Nobuhiro Iwamatsu >> M: Marek Vasut >> diff --git a/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi b/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi >> new file mode 100644 >> index 00000000000..fd7f5367b75 >> --- /dev/null >> +++ b/arch/arm/dts/rk3566-rock-3c-u-boot.dtsi >> @@ -0,0 +1,10 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + >> +#include "rk356x-u-boot.dtsi" >> + >> +&sfc { >> + flash@0 { >> + bootph-pre-ram; >> + bootph-some-ram; >> + }; >> +}; >> diff --git a/configs/rock-3c-rk3566_defconfig b/configs/rock-3c-rk3566_defconfig >> new file mode 100644 >> index 00000000000..f44b202c8c3 >> --- /dev/null >> +++ b/configs/rock-3c-rk3566_defconfig >> @@ -0,0 +1,97 @@ >> +CONFIG_ARM=y >> +CONFIG_SKIP_LOWLEVEL_INIT=y >> +CONFIG_COUNTER_FREQUENCY=24000000 >> +CONFIG_ARCH_ROCKCHIP=y >> +CONFIG_SF_DEFAULT_SPEED=24000000 >> +CONFIG_SF_DEFAULT_MODE=0x2000 >> +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3566-rock-3c" >> +CONFIG_ROCKCHIP_RK3568=y >> +CONFIG_ROCKCHIP_SPI_IMAGE=y >> +CONFIG_SPL_SERIAL=y >> +CONFIG_DEBUG_UART_BASE=0xFE660000 >> +CONFIG_DEBUG_UART_CLOCK=24000000 >> +CONFIG_SPL_SPI_FLASH_SUPPORT=y >> +CONFIG_SPL_SPI=y >> +CONFIG_SYS_LOAD_ADDR=0xc00800 >> +CONFIG_PCI=y >> +CONFIG_DEBUG_UART=y >> +CONFIG_AHCI=y >> +CONFIG_FIT=y >> +CONFIG_FIT_VERBOSE=y >> +CONFIG_SPL_FIT_SIGNATURE=y >> +CONFIG_SPL_LOAD_FIT=y >> +CONFIG_LEGACY_IMAGE_FORMAT=y >> +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3566-rock-3c.dtb" >> +# CONFIG_DISPLAY_CPUINFO is not set >> +CONFIG_DISPLAY_BOARDINFO_LATE=y >> +CONFIG_SPL_MAX_SIZE=0x40000 >> +CONFIG_SPL_PAD_TO=0x7f8000 >> +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set >> +CONFIG_SPL_SPI_LOAD=y >> +CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000 >> +CONFIG_SPL_ATF=y >> +CONFIG_CMD_GPIO=y >> +CONFIG_CMD_GPT=y >> +CONFIG_CMD_I2C=y >> +CONFIG_CMD_MMC=y >> +CONFIG_CMD_PCI=y >> +CONFIG_CMD_POWEROFF=y >> +CONFIG_CMD_USB=y >> +# CONFIG_CMD_SETEXPR is not set >> +CONFIG_CMD_PMIC=y >> +CONFIG_CMD_REGULATOR=y >> +# CONFIG_SPL_DOS_PARTITION is not set >> +CONFIG_SPL_OF_CONTROL=y >> +CONFIG_OF_LIVE=y >> +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" >> +CONFIG_SYS_RELOC_GD_ENV_ADDR=y >> +CONFIG_SPL_DM_SEQ_ALIAS=y >> +CONFIG_SPL_REGMAP=y >> +CONFIG_SPL_SYSCON=y >> +CONFIG_SCSI_AHCI=y >> +CONFIG_AHCI_PCI=y >> +CONFIG_SPL_CLK=y >> +CONFIG_ROCKCHIP_GPIO=y >> +CONFIG_SYS_I2C_ROCKCHIP=y >> +CONFIG_LED=y >> +CONFIG_LED_GPIO=y >> +CONFIG_MISC=y >> +CONFIG_SUPPORT_EMMC_RPMB=y >> +CONFIG_MMC_DW=y >> +CONFIG_MMC_DW_ROCKCHIP=y >> +CONFIG_MMC_SDHCI=y >> +CONFIG_MMC_SDHCI_SDMA=y >> +CONFIG_MMC_SDHCI_ROCKCHIP=y >> +CONFIG_SF_DEFAULT_BUS=4 >> +CONFIG_SPI_FLASH_SFDP_SUPPORT=y >> +CONFIG_SPI_FLASH_GIGADEVICE=y >> +CONFIG_SPI_FLASH_MACRONIX=y >> +CONFIG_SPI_FLASH_WINBOND=y >> +CONFIG_SPI_FLASH_XTX=y >> +CONFIG_PHY_REALTEK=y >> +CONFIG_DWC_ETH_QOS=y >> +CONFIG_DWC_ETH_QOS_ROCKCHIP=y >> +CONFIG_NVME_PCI=y >> +CONFIG_PCIE_DW_ROCKCHIP=y >> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y >> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y >> +CONFIG_SPL_PINCTRL=y >> +CONFIG_DM_PMIC=y >> +CONFIG_PMIC_RK8XX=y >> +CONFIG_REGULATOR_RK8XX=y >> +CONFIG_SPL_RAM=y >> +CONFIG_SCSI=y >> +CONFIG_BAUDRATE=1500000 >> +CONFIG_DEBUG_UART_SHIFT=2 >> +CONFIG_SYS_NS16550_MEM32=y >> +CONFIG_ROCKCHIP_SFC=y >> +CONFIG_SYSRESET=y >> +CONFIG_USB=y >> +CONFIG_USB_XHCI_HCD=y >> +CONFIG_USB_EHCI_HCD=y >> +CONFIG_USB_EHCI_GENERIC=y >> +CONFIG_USB_OHCI_HCD=y >> +CONFIG_USB_OHCI_GENERIC=y >> +CONFIG_USB_DWC3=y >> +CONFIG_USB_DWC3_GENERIC=y >> +CONFIG_ERRNO_STR=y >> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst >> index bedc52e03e2..69976ab2463 100644 >> --- a/doc/board/rockchip/rockchip.rst >> +++ b/doc/board/rockchip/rockchip.rst >> @@ -105,6 +105,7 @@ List of mainline supported Rockchip boards: >> - Pine64 SOQuartz on Model A (soquartz-model-a-rk3566) >> - Powkiddy X55 (powkiddy-x55-rk3566) >> - Radxa CM3 IO Board (radxa-cm3-io-rk3566) >> + - Radxa ROCK 3 Model C (rock-3c-rk3566) > Please use the marketing name, same as in the device tree: This was the name used for Model A. I believe it is correct to name in the same way. > Radxa ROCK 3C > > With those fixed: > > Reviewed-by: Jonas Karlman > > Regards, > Jonas > >> >> * rk3568 >> - Rockchip Evb-RK3568 (evb-rk3568)