From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CA5C433F5 for ; Thu, 21 Oct 2021 09:10:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D58F6112D for ; Thu, 21 Oct 2021 09:10:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D58F6112D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CBE483484; Thu, 21 Oct 2021 11:10:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634807424; bh=XZT6tewN/tKGHtCOiK1D9m/3AdufWZoCZIJN53f25XM=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hqkksd0uJE/Gl5Np/V3tbFCg7507c1YuxhlEsbqQxWi3xDqA0X/KCpgxNTEohgoln rqOt2byJRD2Kbf7WKEqULpb7CN10oWuPQ94vi01BDDzrcGIW9exVPSuLWL/DpPKbWU +0UWVDA9TcdstbFEJH34hkprrGO0jiUjYHgPSOLKT/0AjitHx+lOABLhxT9wuckUoQ hICTusrvFGhPoncH6TfF7w6nam3tje1KW5gACHfdc7aTVKd9DnwBvXeM9QNQlSt7nY nu7Pw0dgl/bTOWE92P7X/8Xyk/0phf8YO+ubygNhj++zy3I4Eqnq4Ltt9QUPr8f8+a xh50TB9i0M6qg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 18F3683476 for ; Thu, 21 Oct 2021 11:10:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634807421; bh=XZT6tewN/tKGHtCOiK1D9m/3AdufWZoCZIJN53f25XM=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=EnkVZBUoVDmfH/U3A1Tk/3lNE8lS19HtCS6kPz3wG/SuijcUqJ111zMgPJ0xLlZXL m4H67mf0visJzp8JAmin/3yBvR+JmaLMBuUTGsnHDvFo2CMMG3BsYcdKYh8zPe/k4D N04guiUMNLaYdwA9g57aNID74aiV8Lf98YrN4cfWL5L76cSn//tWKpuWrybX2O6BVs lCAHifHDvq28khHhlVXieT0LIezLobkFQPMfmddlOckNJjAmumF6TguPZ5jAQpFRXW ZPA38UuAheo0mZirG73ACBtgtbVY7Fk9Mlu5+xfj9gv6uM9j3w4Wp/SFBZwBTq4QOL FTR1T5bI5/okA== Received: by janitor.denx.de (Postfix, from userid 108) id C8FE4A021F; Thu, 21 Oct 2021 11:10:20 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 6B8BDA0099; Thu, 21 Oct 2021 11:10:11 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 099651E0F1B; Thu, 21 Oct 2021 11:10:11 +0200 (CEST) To: Simon Glass cc: Tom Rini , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v8 4/8] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211018181322.1181847-1-sjg@chromium.org> <20211018121315.v8.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <20211019140711.GC7964@bill-the-cat> <20211019142529.GE7964@bill-the-cat> <3573814.1634660430@gemini.denx.de> <20211019163000.GI7964@bill-the-cat> Comments: In-reply-to Simon Glass message dated "Tue, 19 Oct 2021 10:39:55 -0600." Date: Thu, 21 Oct 2021 11:10:11 +0200 Message-ID: <3677889.1634807411@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message you wrote: > > > Wait saying we'll add "+SOMETHING" is a common case? > > Yes we have places where we add to env vars depending on CONFIG settings. Yes, but how many places are there where the appended value starts with a '+' ? > The way I have this, is it fairly trivial to convert an existing > script to a text file. I suspect it can be done automatically but I > have not actually tried it. I'd really like to keep it simple. I also > want to invoke the 'if you are not in mainline you don't exist' maxim > at this point. In which way is "+=" easier to parse than "=+"? The only extension you have to make is for the "=[^+]" case to check the first charater of the value: if it is a backslash, then ignore it. This has zero influence on doing this manually or automatic. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I see that Microsoft's campaign to destroy all knowledge of any operating environment but its own environment-of-the-year has succeeded in creating a generation of users who don't understand the concept of a shell... -- L. Peter Deutsch in