From: Wolfgang Denk <wd@denx.de>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Marek Behún" <marek.behun@nic.cz>,
"Rasmus Villemoes" <rasmus.villemoes@prevas.dk>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Tom Rini" <trini@konsulko.com>,
"Joe Hershberger" <joe.hershberger@ni.com>
Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file
Date: Thu, 21 Oct 2021 11:50:02 +0200 [thread overview]
Message-ID: <3682215.1634809802@gemini.denx.de> (raw)
In-Reply-To: <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid>
Dear Simon,
In message <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote:
> At present U-Boot environment variables, and thus scripts, are defined
> by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text
> to this file and dealing with quoting and newlines is harder than it
> should be. It would be better if we could just type the script into a
> text file and have it included by U-Boot.
>
> Add a feature that brings in a .env file associated with the board
> config, if present. To use it, create a file in a board/<vendor>
> directory, typically called <board>.env and controlled by the
> CONFIG_ENV_SOURCE_FILE option.
>
> The environment variables should be of the form "var=value". Values can
> extend to multiple lines. See the README under 'Environment Variables:'
> for more information and an example. Note that variables names may
> not end in + due to the += syntax below.
I still object to placing new, arbitrary restrictions on what may or
may not be used in environment variable names.
We have discussed alternative implementations, and trivial changes
like using "=+" instead of "+=" as append operator do not require
such restictions.
Thus, and only for the restictions on variable names:
Naked-by: Wolfgang Denk <wd@denx.de>
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
There is is no reason for any individual to have a computer in their
home. -- Ken Olsen (President of Digital Equipment Corporation),
Convention of the World Future Society, in Boston, 1977
next prev parent reply other threads:[~2021-10-21 9:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 22:44 [PATCH v9 0/7] env: Allow environment in text files Simon Glass
2021-10-19 22:44 ` [PATCH v9 1/7] sandbox: Drop distro_boot Simon Glass
2021-10-19 22:44 ` [PATCH v9 2/7] doc: Move environment documentation to rST Simon Glass
2021-10-20 6:38 ` Heinrich Schuchardt
2021-10-22 3:05 ` Simon Glass
2021-10-19 22:44 ` [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file Simon Glass
2021-10-21 9:50 ` Wolfgang Denk [this message]
2021-10-21 12:23 ` Tom Rini
2021-10-21 13:06 ` Wolfgang Denk
2021-10-21 13:25 ` Marek Behún
2021-10-21 13:28 ` Marek Behún
2021-10-21 15:12 ` Wolfgang Denk
2021-10-21 15:18 ` Tom Rini
2021-10-21 15:59 ` Simon Glass
2021-10-21 16:03 ` Tom Rini
2021-10-21 16:51 ` Simon Glass
2021-10-22 6:40 ` Rasmus Villemoes
2021-10-24 19:54 ` Simon Glass
2021-10-25 7:06 ` Rasmus Villemoes
2021-10-25 15:18 ` Simon Glass
2021-10-25 19:52 ` Rasmus Villemoes
2021-10-26 10:15 ` Wolfgang Denk
2021-10-28 14:18 ` Simon Glass
2021-10-22 8:08 ` Wolfgang Denk
2021-10-22 14:47 ` Tom Rini
2021-10-24 15:46 ` Wolfgang Denk
2021-10-24 16:44 ` Tom Rini
2021-10-25 7:48 ` Wolfgang Denk
2021-10-22 8:06 ` Wolfgang Denk
2021-10-22 14:04 ` Marek Behún
2021-10-22 14:50 ` Tom Rini
2021-10-19 22:44 ` [PATCH v9 4/7] sandbox: Use a text-based environment Simon Glass
2021-10-20 6:58 ` Alexander Dahl
2021-10-19 22:44 ` [PATCH v9 5/7] doc: Mention CONFIG_DEFAULT_ENV_FILE Simon Glass
2021-10-19 22:44 ` [PATCH v9 6/7] doc: Improve environment documentation Simon Glass
2021-10-19 22:44 ` [PATCH v9 7/7] bootm: Tidy up use of autostart env var Simon Glass
2021-10-21 14:02 ` [PATCH v9 0/7] env: Allow environment in text files Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3682215.1634809802@gemini.denx.de \
--to=wd@denx.de \
--cc=joe.hershberger@ni.com \
--cc=marek.behun@nic.cz \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox