From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199B5C433EF for ; Thu, 21 Oct 2021 09:50:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 033A6610CF for ; Thu, 21 Oct 2021 09:50:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 033A6610CF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2D4638346A; Thu, 21 Oct 2021 11:50:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634809813; bh=Ks9PAwaM0TF6r6IRoVRfoFBId8FV+k9pZYDx1UG86WM=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=zYr6pmEZQFvuy1L+SVzDLFY49Zqz6L3khjhP0MRQudvuldLHlk0TWAR8DWYLLYj+t G+fAZ1g9dXCzBoA/18M7OnubT+0hkr47iMwxA0+odp48MHrvWW4I8UkneEgVtg61BR sQYItVgqK3KvqTr1hy2q0xjO3Zrh5M2oHBPmEGsDHMgZpn2DTgxwwwAJgLGaJeppSF wDqiQUHCa8BbXpKZZHjL908rB3Hi4q1N2MqW3q5GYpVpxb0RYP1uWZ94uTIC2qIuxI OSC8JbYPC+iLEhoM78He5vWGkS9NlZ0+wMzSFtbU+tlNfQOJL9JnyXuhQgYC/5LeOq +Je1U3vjdeuyA== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9D56483405 for ; Thu, 21 Oct 2021 11:50:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634809810; bh=Ks9PAwaM0TF6r6IRoVRfoFBId8FV+k9pZYDx1UG86WM=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=iRO7fgmyqSOnfGnaxwLhDF3lELmJatHib0PB+snC+FgCxWgi6AIBUqiC2w7GfRs12 7z79bPLPvNaSXNvs8R7i6Tz17dQgfSFiNlaD6ICv7BNmRRmYYzEVaNRnshhNDJNhBV qX0TTZvVcbHiOvUMG+0WB5t/c9TBciF6ab2v7dhdatqAb/r70MSZhukSMt0RUruWr3 7MeOiGxpVxv9Sx5Qa5btm3lo9DNQnIuhQgU8QH8lIY+cqHI/VN3g6+ulEoCpQqBCok FN0cWDGNQn704E0hrPbWe9bYcpkxX5DGbY3+ABH7shGV8oNqS2yL6QmQjdK5BxbVrg beekRLDPxiTcQ== Received: by janitor.denx.de (Postfix, from userid 108) id 17FFCA0162; Thu, 21 Oct 2021 11:50:10 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 47E6CA0099; Thu, 21 Oct 2021 11:50:03 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id E2B4D1E0F1B; Thu, 21 Oct 2021 11:50:02 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Rasmus Villemoes , Heinrich Schuchardt , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Tue, 19 Oct 2021 16:44:18 -0600." Date: Thu, 21 Oct 2021 11:50:02 +0200 Message-ID: <3682215.1634809802@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It would be better if we could just type the script into a > text file and have it included by U-Boot. > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file in a board/ > directory, typically called .env and controlled by the > CONFIG_ENV_SOURCE_FILE option. > > The environment variables should be of the form "var=value". Values can > extend to multiple lines. See the README under 'Environment Variables:' > for more information and an example. Note that variables names may > not end in + due to the += syntax below. I still object to placing new, arbitrary restrictions on what may or may not be used in environment variable names. We have discussed alternative implementations, and trivial changes like using "=+" instead of "+=" as append operator do not require such restictions. Thus, and only for the restictions on variable names: Naked-by: Wolfgang Denk Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de There is is no reason for any individual to have a computer in their home. -- Ken Olsen (President of Digital Equipment Corporation), Convention of the World Future Society, in Boston, 1977