public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper
Date: Thu, 27 Jun 2019 13:08:11 +0200	[thread overview]
Message-ID: <36968e33-4d65-53b3-e17a-60a4394edd4e@denx.de> (raw)
In-Reply-To: <CAByghJaWgYW8XS7qG8V4WQ68HMG2Eaamu3ya189yYSSM7OE7Ag@mail.gmail.com>

Hi Igor,

On 27/06/19 11:26, Igor Opaniuk wrote:
> Hi Stefano,
> 
> On Wed, Jun 26, 2019 at 10:37 AM Philippe Schenker <dev@pschenker.ch> wrote:
>>
>> On Tue, 2019-06-25 at 14:48 +0300, Igor Opaniuk wrote:
>>> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>>>
>>> Fix set_emmcargs wrapper, which prepares proper bootargs for booting
>>> from eMMC.
>>>
>>> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
>>
>> Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>
>>
>>> ---
>>>  include/configs/apalis_imx6.h | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/configs/apalis_imx6.h b/include/configs/apalis_imx6.h
>>> index 4b0a3fb26b..cffb90a690 100644
>>> --- a/include/configs/apalis_imx6.h
>>> +++ b/include/configs/apalis_imx6.h
>>> @@ -121,8 +121,8 @@
>>>       "imx6q-apalis-cam-eval.dtb fat 0 1"
>>>
>>>  #define EMMC_BOOTCMD \
>>> -     "set_emmcargs emmcargs ip=off root=PARTUUID=${uuid} ro,noatime " \
>>> -             "rootfstype=ext4 rootwait\0" \
>>> +     "set_emmcargs=setenv emmcargs ip=off root=PARTUUID=${uuid} " \
>>> +             "ro,noatime rootfstype=ext4 rootwait\0" \
>>>       "emmcboot=run setup; run emmcfinduuid; run set_emmcargs; " \
>>>               "setenv bootargs ${defargs} ${emmcargs} ${setupargs} " \
>>>               "${vidargs}; echo Booting from internal eMMC chip...; " \
>>
> 
> This is a bug fix, currently boot on Apalis iMX6 is broken.
> could you please apply this patch so it's included in v2019.07 release?
> 

I pick it up, I am sorting which fixes I should take for release. Thanks !

Best regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      reply	other threads:[~2019-06-27 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 11:48 [U-Boot] [PATCH] apalis_imx6: fix set_emmcargs wrapper Igor Opaniuk
2019-06-26  7:37 ` Philippe Schenker
2019-06-27  9:26   ` Igor Opaniuk
2019-06-27 11:08     ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36968e33-4d65-53b3-e17a-60a4394edd4e@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox