From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B137C4332F for ; Thu, 21 Oct 2021 15:12:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F343B61372 for ; Thu, 21 Oct 2021 15:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F343B61372 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4105F833F4; Thu, 21 Oct 2021 17:12:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634829158; bh=b8xa9Ievt7UehhJypTNX6ECuj+fgHxN3UVcNQxhhV0I=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KYIyUithNyYDM/buPZlobl/op6TOpFE0DpMZjJIeGf2ax1AjI0MuYS8885wezfoe6 wo+IQHPn2hMqhBh4+NyHo/eCHyc7Q2snalj3fsHSIdDZoGZSsHQ0lCQcF5+8HYEf9m pMf1jU83b5izVXCPJbg30hNw8iqMIothnJp8bX1YtmfCXEfiSp1XHidnqF/gTs1hWI 3lE970anJ5yCoW/4ZbyVyC7Z5+3Gjp+e7z31PW01LKV0QdS78JzCXR7UpzVJZsYH8t L5kRE87OozEc5RX/Wdwy81RauQJqUDPuItrv8ecF7oMqUirFyqXHtDLp0DhLfaM5xX aNfg9gpgxfMKQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E23318321C for ; Thu, 21 Oct 2021 17:12:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1634829155; bh=b8xa9Ievt7UehhJypTNX6ECuj+fgHxN3UVcNQxhhV0I=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=c54E8lF+vPIZqKm/oiejx9aKXXQ+iJKvnXQyc8KbnrUsg+ufCkpOwcYFobwHzmXm9 g58CSS/2vSocMMSaAAyiylOSEuGXCaP1wU9Gf2SPByih7vUqmaVoEnuPOMbp+w1IH9 8zZTCMDRQiIOoyYWFxC/1/mrT2nYRAtOAXnM1QZl1Gs7+OVbXJ+EXZHAAF8STjIzqR TCOHdaFoA1nnbFjpKtBcRg1CCn+7EULT3CYSp7pxg5v0Cdz/FQx/SrlD+SO1Bkz+dM 1VhOMthGpoi+EeqsX+/OBngZkpgZVh/UXp0Uu5cEiOzGtdPe01xxaNnrVHr/aFjOXG a4oEmYXEKV0oA== Received: by janitor.denx.de (Postfix, from userid 108) id 52061A02B9; Thu, 21 Oct 2021 17:12:35 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 620A7A0099; Thu, 21 Oct 2021 17:12:26 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 39E431E0F1B; Thu, 21 Oct 2021 17:12:26 +0200 (CEST) To: Marek =?UTF-8?B?QmVow7pu?= cc: Simon Glass , Tom Rini , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211021152831.15524883@thinkpad> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> <3695947.1634821611@gemini.denx.de> <20211021152537.441c37b9@thinkpad> <20211021152831.15524883@thinkpad> Comments: In-reply-to Marek =?UTF-8?B?QmVow7pu?= message dated "Thu, 21 Oct 2021 15:28:31 +0200." Date: Thu, 21 Oct 2021 17:12:26 +0200 Message-ID: <3702754.1634829146@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Marek, In message <20211021152831.15524883@thinkpad> you wrote: > > > > I think =+ will confuse far more people than + as last character of var I still fail to see why '=+' could be confusing if properly documented to be the append operator. I mean, it is not a new invention of mine. OpenEmbedded / Yocto uses '=+' a lot, like in meta/recipes-kernel/dtc/dtc.inc: PACKAGES =+ "${PN}-misc" Actually they use both '+=' and '=+', like RESULT+=${ERRORS} > > name working weirdly. But I also think that + should be supported as > > last character. Therefore I propose backslash escaping in variable name, > > i.e. > > var+=value > > appends value to var, while > > var\+=value > > sets variable with name "var+" Yes, this is yet another alternative for handling this problem. > Also, I think that it would be better if spaces and tabs were allowed > to indent the .env file, i.e. > > var_a = 3 > var_bcd = 7 > > should set "var_a" to "3", "var_bcd" to "7". Why not... In the end it boils down that the file format should be properly defined and have a clear syntax description. Apparently the "=\0" format as used in U-Boot persistent storage should not be taken literally here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de If you're out of tree, you don't exist. - David Woodhouse in <1304620350.2398.29.camel@i7.infradead.org>