[U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[Alex Marginean]

Replace legacy I2C_EARLY_INIT with dm-pre-reloc dts property.

Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
---

Depends on this patch series:
https://patchwork.ozlabs.org/project/uboot/list/?series=118778

 arch/arm/dts/fsl-ls1028a-qds.dts | 1 +
 include/configs/ls1028aqds.h     | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/fsl-ls1028a-qds.dts b/arch/arm/dts/fsl-ls1028a-qds.dts
index e308989a00..717ab0a994 100644
--- a/arch/arm/dts/fsl-ls1028a-qds.dts
+++ b/arch/arm/dts/fsl-ls1028a-qds.dts
@@ -37,6 +37,7 @@
 
 &i2c0 {
 	status = "okay";
+	u-boot,dm-pre-reloc;
 
 	fpga at 66 {
 		#address-cells = <1>;
diff --git a/include/configs/ls1028aqds.h b/include/configs/ls1028aqds.h
index be018ef2be..b0e9441a48 100644
--- a/include/configs/ls1028aqds.h
+++ b/include/configs/ls1028aqds.h
@@ -16,7 +16,6 @@
 #define CONFIG_DIMM_SLOTS_PER_CTLR		2
 
 #define CONFIG_QIXIS_I2C_ACCESS
-#define CONFIG_SYS_I2C_EARLY_INIT
 
 /*
  * QIXIS Definitions
-- 
2.17.1

[U-Boot] [PATCH 2/2] configs: ls1028aqds: enable I2C and GPIO DM

[Alex Marginean]

LS1028A was already converted to I2C/GPIO DM, move the QDS board over too.

Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
---
 configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 5 ++++-
 configs/ls1028aqds_tfa_defconfig             | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
index 4a2b354008..76c9af5ef3 100644
--- a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
+++ b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028AQDS=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SECURE_BOOT=y
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
@@ -8,7 +9,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -31,6 +31,9 @@ CONFIG_NETCONSOLE=y
 CONFIG_DM=y
 CONFIG_SCSI_AHCI=y
 CONFIG_SATA_CEVA=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_DM_MMC=y
 CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
diff --git a/configs/ls1028aqds_tfa_defconfig b/configs/ls1028aqds_tfa_defconfig
index b315910414..7c98474d73 100644
--- a/configs/ls1028aqds_tfa_defconfig
+++ b/configs/ls1028aqds_tfa_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_TARGET_LS1028AQDS=y
+CONFIG_SYS_MALLOC_F_LEN=0x6000
 CONFIG_SYS_FSL_SDHC_CLK_DIV=1
 CONFIG_TFABOOT=y
 CONFIG_NR_DRAM_BANKS=2
@@ -7,7 +8,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
 CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
 CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
-# CONFIG_SYS_MALLOC_F is not set
 CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_OF_STDOUT_VIA_ALIAS=y
@@ -34,6 +34,9 @@ CONFIG_DM=y
 CONFIG_SCSI_AHCI=y
 CONFIG_SATA_CEVA=y
 CONFIG_FSL_CAAM=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
 CONFIG_DM_MMC=y
 CONFIG_FSL_ESDHC=y
 CONFIG_DM_SPI_FLASH=y
-- 
2.17.1

[U-Boot] [PATCH 2/2] configs: ls1028aqds: enable I2C and GPIO DM

[Bin Meng]

On Fri, Jul 12, 2019 at 7:25 PM Alex Marginean
<alexandru.marginean@nxp.com> wrote:
>
> LS1028A was already converted to I2C/GPIO DM, move the QDS board over too.
>
> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> ---
>  configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 5 ++++-
>  configs/ls1028aqds_tfa_defconfig             | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[U-Boot] [PATCH 2/2] configs: ls1028aqds: enable I2C and GPIO DM

[Chuanhua Han]

Hi,Alex

I have already sent the patch set of ls1028aqds i2c dm. Please check the patchwork link below：
https://patchwork.ozlabs.org/project/uboot/list/?series=118709

thanks,
Chaunhua
> -----Original Message-----
> From: Alex Marginean <alexandru.marginean@nxp.com>
> Sent: 2019年7月12日 19:23
> To: u-boot at lists.denx.de
> Cc: Chuanhua Han <chuanhua.han@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Alex Marginean <alexm.osslist@gmail.com>
> Subject: [PATCH 2/2] configs: ls1028aqds: enable I2C and GPIO DM
> 
> LS1028A was already converted to I2C/GPIO DM, move the QDS board over too.
> 
> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> ---
>  configs/ls1028aqds_tfa_SECURE_BOOT_defconfig | 5 ++++-
>  configs/ls1028aqds_tfa_defconfig             | 5 ++++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
> b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
> index 4a2b354008..76c9af5ef3 100644
> --- a/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
> +++ b/configs/ls1028aqds_tfa_SECURE_BOOT_defconfig
> @@ -1,5 +1,6 @@
>  CONFIG_ARM=y
>  CONFIG_TARGET_LS1028AQDS=y
> +CONFIG_SYS_MALLOC_F_LEN=0x6000
>  CONFIG_SECURE_BOOT=y
>  CONFIG_SYS_FSL_SDHC_CLK_DIV=1
>  CONFIG_TFABOOT=y
> @@ -8,7 +9,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
>  CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
>  CONFIG_AHCI=y
>  CONFIG_DISTRO_DEFAULTS=y
> -# CONFIG_SYS_MALLOC_F is not set
>  CONFIG_FIT_VERBOSE=y
>  CONFIG_OF_BOARD_SETUP=y
>  CONFIG_OF_STDOUT_VIA_ALIAS=y
> @@ -31,6 +31,9 @@ CONFIG_NETCONSOLE=y
>  CONFIG_DM=y
>  CONFIG_SCSI_AHCI=y
>  CONFIG_SATA_CEVA=y
> +CONFIG_DM_GPIO=y
> +CONFIG_DM_I2C=y
> +CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
>  CONFIG_DM_MMC=y
>  CONFIG_FSL_ESDHC=y
>  CONFIG_DM_SPI_FLASH=y
> diff --git a/configs/ls1028aqds_tfa_defconfig
> b/configs/ls1028aqds_tfa_defconfig
> index b315910414..7c98474d73 100644
> --- a/configs/ls1028aqds_tfa_defconfig
> +++ b/configs/ls1028aqds_tfa_defconfig
> @@ -1,5 +1,6 @@
>  CONFIG_ARM=y
>  CONFIG_TARGET_LS1028AQDS=y
> +CONFIG_SYS_MALLOC_F_LEN=0x6000
>  CONFIG_SYS_FSL_SDHC_CLK_DIV=1
>  CONFIG_TFABOOT=y
>  CONFIG_NR_DRAM_BANKS=2
> @@ -7,7 +8,6 @@ CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT=y
>  CONFIG_SEC_FIRMWARE_ARMV8_PSCI=y
>  CONFIG_AHCI=y
>  CONFIG_DISTRO_DEFAULTS=y
> -# CONFIG_SYS_MALLOC_F is not set
>  CONFIG_FIT_VERBOSE=y
>  CONFIG_OF_BOARD_SETUP=y
>  CONFIG_OF_STDOUT_VIA_ALIAS=y
> @@ -34,6 +34,9 @@ CONFIG_DM=y
>  CONFIG_SCSI_AHCI=y
>  CONFIG_SATA_CEVA=y
>  CONFIG_FSL_CAAM=y
> +CONFIG_DM_GPIO=y
> +CONFIG_DM_I2C=y
> +CONFIG_I2C_SET_DEFAULT_BUS_NUM=y
>  CONFIG_DM_MMC=y
>  CONFIG_FSL_ESDHC=y
>  CONFIG_DM_SPI_FLASH=y
> --
> 2.17.1

[U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[Bin Meng]

On Fri, Jul 12, 2019 at 7:25 PM Alex Marginean
<alexandru.marginean@nxp.com> wrote:
>
> Replace legacy I2C_EARLY_INIT with dm-pre-reloc dts property.
>
> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> ---
>
> Depends on this patch series:
> https://patchwork.ozlabs.org/project/uboot/list/?series=118778
>
>  arch/arm/dts/fsl-ls1028a-qds.dts | 1 +
>  include/configs/ls1028aqds.h     | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Maybe we need another separate patch to remove i2c_early_init_f() call
in board_early_init_f() in board/freescale/ls1028a/ls1028a.c?

Regards,
Bin

[U-Boot] [EXT] Re: [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[Chuanhua Han]

Hi，
I have already sent the patch set of ls1028aqds i2c dm. Please check the patchwork link below：
https://patchwork.ozlabs.org/project/uboot/list/?series=1187093

Thanks,
Chuanhua

> -----Original Message-----
> From: Bin Meng <bmeng.cn@gmail.com>
> Sent: 2019年7月13日 11:47
> To: Alexandru Marginean <alexandru.marginean@nxp.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Chuanhua Han
> <chuanhua.han@nxp.com>
> Subject: [EXT] Re: [U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS
> board to I2C DM
> 
> Caution: EXT Email
> 
> On Fri, Jul 12, 2019 at 7:25 PM Alex Marginean
> <alexandru.marginean@nxp.com> wrote:
> >
> > Replace legacy I2C_EARLY_INIT with dm-pre-reloc dts property.
> >
> > Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> > ---
> >
> > Depends on this patch series:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118778&amp;d
> at
> >
> a=02%7C01%7Cchuanhua.han%40nxp.com%7C1cfa23cba36241e0876208d707
> 44cdd6%
> >
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636985864401799867
> &amp;sd
> >
> ata=Uv7WjXfc7wlcJ9kNb1soveXOFH4MkTmVjL2nsBlrac0%3D&amp;reserved=0
> >
> >  arch/arm/dts/fsl-ls1028a-qds.dts | 1 +
> >  include/configs/ls1028aqds.h     | 1 -
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> 
> Maybe we need another separate patch to remove i2c_early_init_f() call in
> board_early_init_f() in board/freescale/ls1028a/ls1028a.c?
> 
> Regards,
> Bin

[U-Boot] [EXT] Re: [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[Alex Marginean]

Hi Chuanhua,

On 7/15/2019 5:37 AM, Chuanhua Han wrote:
> Hi，
> I have already sent the patch set of ls1028aqds i2c dm. Please check the patchwork link below：
> https://patchwork.ozlabs.org/project/uboot/list/?series=1187093

Oh, OK, I didn't see that set of patches, I'll give them a try.
The actual url is:
https://patchwork.ozlabs.org/project/uboot/list/?series=118709

Thank you!
Alex

> 
> Thanks,
> Chuanhua
> 
>> -----Original Message-----
>> From: Bin Meng <bmeng.cn@gmail.com>
>> Sent: 2019年7月13日 11:47
>> To: Alexandru Marginean <alexandru.marginean@nxp.com>
>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Chuanhua Han
>> <chuanhua.han@nxp.com>
>> Subject: [EXT] Re: [U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS
>> board to I2C DM
>>
>> Caution: EXT Email
>>
>> On Fri, Jul 12, 2019 at 7:25 PM Alex Marginean
>> <alexandru.marginean@nxp.com> wrote:
>>>
>>> Replace legacy I2C_EARLY_INIT with dm-pre-reloc dts property.
>>>
>>> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
>>> ---
>>>
>>> Depends on this patch series:
>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
>>>
>> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118778&amp;d
>> at
>>>
>> a=02%7C01%7Cchuanhua.han%40nxp.com%7C1cfa23cba36241e0876208d707
>> 44cdd6%
>>>
>> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636985864401799867
>> &amp;sd
>>>
>> ata=Uv7WjXfc7wlcJ9kNb1soveXOFH4MkTmVjL2nsBlrac0%3D&amp;reserved=0
>>>
>>>   arch/arm/dts/fsl-ls1028a-qds.dts | 1 +
>>>   include/configs/ls1028aqds.h     | 1 -
>>>   2 files changed, 1 insertion(+), 1 deletion(-)
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> Maybe we need another separate patch to remove i2c_early_init_f() call in
>> board_early_init_f() in board/freescale/ls1028a/ls1028a.c?
>>
>> Regards,
>> Bin
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
> 

[U-Boot] [EXT] Re: [PATCH 1/2] armv8: ls1028aqds: switch LS1028A QDS board to I2C DM

[Alex Marginean]

Hi,

On 7/15/2019 9:30 AM, Alex Marginean wrote:
> Hi Chuanhua,
> 
> On 7/15/2019 5:37 AM, Chuanhua Han wrote:
>> Hi，
>> I have already sent the patch set of ls1028aqds i2c dm. Please check 
>> the patchwork link below：
>> https://patchwork.ozlabs.org/project/uboot/list/?series=1187093
> 
> Oh, OK, I didn't see that set of patches, I'll give them a try.
> The actual url is:
> https://patchwork.ozlabs.org/project/uboot/list/?series=118709

The patch series from Chuanhua looks OK to, please discard these two
patches form me, they duplicate changes.

Thank you!
Alex

> 
> Thank you!
> Alex
> 
>>
>> Thanks,
>> Chuanhua
>>
>>> -----Original Message-----
>>> From: Bin Meng <bmeng.cn@gmail.com>
>>> Sent: 2019年7月13日 11:47
>>> To: Alexandru Marginean <alexandru.marginean@nxp.com>
>>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Chuanhua Han
>>> <chuanhua.han@nxp.com>
>>> Subject: [EXT] Re: [U-Boot] [PATCH 1/2] armv8: ls1028aqds: switch 
>>> LS1028A QDS
>>> board to I2C DM
>>>
>>> Caution: EXT Email
>>>
>>> On Fri, Jul 12, 2019 at 7:25 PM Alex Marginean
>>> <alexandru.marginean@nxp.com> wrote:
>>>>
>>>> Replace legacy I2C_EARLY_INIT with dm-pre-reloc dts property.
>>>>
>>>> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
>>>> ---
>>>>
>>>> Depends on this patch series:
>>>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
>>>>
>>> hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D118778&amp;d
>>> at
>>>>
>>> a=02%7C01%7Cchuanhua.han%40nxp.com%7C1cfa23cba36241e0876208d707
>>> 44cdd6%
>>>>
>>> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636985864401799867
>>> &amp;sd
>>>>
>>> ata=Uv7WjXfc7wlcJ9kNb1soveXOFH4MkTmVjL2nsBlrac0%3D&amp;reserved=0
>>>>
>>>>   arch/arm/dts/fsl-ls1028a-qds.dts | 1 +
>>>>   include/configs/ls1028aqds.h     | 1 -
>>>>   2 files changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>>
>>> Maybe we need another separate patch to remove i2c_early_init_f() 
>>> call in
>>> board_early_init_f() in board/freescale/ls1028a/ls1028a.c?
>>>
>>> Regards,
>>> Bin
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
>>
>