From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 927A3C00140 for ; Tue, 2 Aug 2022 13:10:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D7CB83E4C; Tue, 2 Aug 2022 15:10:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=thorsis.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A3B6880584; Tue, 2 Aug 2022 15:10:19 +0200 (CEST) Received: from mail.thorsis.com (mail.thorsis.com [92.198.35.195]) by phobos.denx.de (Postfix) with ESMTP id CCB9D83E4C for ; Tue, 2 Aug 2022 15:10:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=thorsis.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ada@thorsis.com From: Alexander Dahl To: Tom Rini Cc: u-boot@lists.denx.de, Marek Vasut , Pali =?ISO-8859-1?Q?Roh=E1r?= , Philippe Reynes , Alexander Dahl Subject: Re: Build with CONFIG_TOOLS_LIBCRYPTO disabled is broken Date: Tue, 02 Aug 2022 15:10:13 +0200 Message-ID: <3706927.dslp0D23Aq@ada> In-Reply-To: <20220727130856.GU1146598@bill-the-cat> References: <1884029.XjOfZupGQm@ada> <20220727130856.GU1146598@bill-the-cat> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hello everyone, Am Mittwoch, 27. Juli 2022, 15:08:56 CEST schrieb Tom Rini: > On Tue, Jul 26, 2022 at 10:27:01AM +0200, Alexander Dahl wrote: > > Hei hei, > > > > once again I tried building U-Boot with CONFIG_TOOLS_LIBCRYPTO disabled > > and > > with no libssl-dev installed on the build machine. It does not work. > > > > Even porting the patch disabling the build with kwbimage (see links below) > > does not help anymore, because since commit 6e052d1cbafb ("mkimage: add > > public key for image pre-load stage") there's a new hard dependency on > > host openssl in tools/image-host.c and the corresponding kconfig symbol > > CONFIG_TOOLS_FIT can not be disabled through menuconfig. > > > > Just read those discussions again, but not sure what can be done to > > proceed > > here? Can I help somehow? > > I think we need a new patch that guards the new functions / calls under > CONFIG_TOOLS_LIBCRYPTO and then a new CI job that removes libssl-dev > before building tools-only so we don't re-introduce the problem is what > we need to move forward here. Apart from that kwbimage stuff, the changeset 6e052d1cbafb mentioned above touches the following files: - include/image.h - tools/fit_image.c - tools/image-host.c Conditional building for CONFIG_TOOLS_LIBCRYPTO can currently only be found in tools/Makefile (not through #ifdefs in header or source files). I'm not sure if fit_image.o and image-host.o should be moved away from FIT_OBJS-y to something else, though. This probably requires a better understanding of those objects than I have. :-/ Greets Alex