From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx5/6 timer: Use defined CONFIG_SYS_MX*_CLK32
Date: Fri, 17 Aug 2012 21:52:46 +0200 (CEST) [thread overview]
Message-ID: <37416474.2523268.1345233166383.JavaMail.root@advansee.com> (raw)
In-Reply-To: <502E9EEB.2010509@denx.de>
Hi Stefano,
> On 14/08/2012 17:01, Beno?t Th?baudeau wrote:
> > Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
>
> Hi Beno?t,
>
> > .../arch/arm/cpu/armv7/imx-common/timer.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git
> > u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
> > u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> > index 1645ff8..ad67367 100644
> > --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/imx-common/timer.c
> > +++ u-boot-4d3c95f/arch/arm/cpu/armv7/imx-common/timer.c
> > @@ -44,7 +44,11 @@ static struct mxc_gpt *cur_gpt = (struct mxc_gpt
> > *)GPT1_BASE_ADDR;
> > #define GPTCR_FRR (1 << 9) /* Freerun / restart */
> > #define GPTCR_CLKSOURCE_32 (4 << 6) /* Clock source */
> > #define GPTCR_TEN 1 /* Timer enable */
> > -#define CLK_32KHZ 32768 /* 32Khz input */
> > +#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
> > +#define CLK_32KHZ CONFIG_SYS_MX5_CLK32
> > +#elif defined(CONFIG_MX6Q)
> > +#define CLK_32KHZ CONFIG_SYS_MX6_CLK32
> > +#endif
> >
> > DECLARE_GLOBAL_DATA_PTR;
> >
>
> Frankly I do not see the advantage to use the CONFIG_SYS defines.
It can be useful if 32000 Hz is used instead of 32768 Hz for some boards.
> On
> the
> other hand, checking this patch I see that CONFIG_SYS_MX5_CLK32 and
> CONFIG_SYS_MX6_CLK32 are dead code.
>
> I do not find drivers using, but all boards define them:
>
> grep -r CONFIG_SYS_MX5_CLK32 *
> include/configs/efikamx.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/mx53loco.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/mx53ard.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/mx51evk.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/vision2.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/mx53evk.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/ima3-mx53.h:#define CONFIG_SYS_MX5_CLK32 32768
> include/configs/mx53smd.h:#define CONFIG_SYS_MX5_CLK32 32768
>
> and
>
> include/configs/mx6qsabrelite.h.orig:#define CONFIG_SYS_MX6_CLK32
> 32768
> include/configs/mx6qarm2.h:#define CONFIG_SYS_MX6_CLK32 32768
> include/configs/mx6qsabrelite.h:#define CONFIG_SYS_MX6_CLK32
> 32768
Indeed.
> We have two defines, both for nothing. I prefer a patch dropping
> completely this dead code as to try to use it...
See my use case above, and tell me if it made you change your mind.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-17 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 15:01 [U-Boot] [PATCH] mx5/6 timer: Use defined CONFIG_SYS_MX*_CLK32 Benoît Thébaudeau
2012-08-17 19:43 ` Stefano Babic
2012-08-17 19:52 ` Benoît Thébaudeau [this message]
2012-08-17 20:51 ` Stefano Babic
2012-08-17 21:03 ` Benoît Thébaudeau
2012-08-17 21:09 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37416474.2523268.1345233166383.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox