From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6B8C4338F for ; Thu, 29 Jul 2021 15:48:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0612560F43 for ; Thu, 29 Jul 2021 15:48:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0612560F43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E756C82E05; Thu, 29 Jul 2021 17:48:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZUKL71Qm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1F04E82E02; Thu, 29 Jul 2021 17:48:37 +0200 (CEST) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EC28D82E02 for ; Thu, 29 Jul 2021 17:48:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.nuke.me@gmail.com Received: by mail-oi1-x22a.google.com with SMTP id o20so8937368oiw.12 for ; Thu, 29 Jul 2021 08:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wxzIINLdGpF4xvMnTT5HBiaWan3JduyNu4riRa0p4c8=; b=ZUKL71Qmv7s3cbbNwJO75211NjWJ4GjwOnWSkY2rGSfQzkYsmfoUDLAe7+BO+22xZo +ihhhlJa+fCSIDk8RpjgRt/vmee9Mx0w6//II0scxOzCgo3InR4uXwFKhmjMFpWw3aMZ g8n3jXGCOjGlDwp7BIvp5yp7Mp3QID3DvaJ3NZieIYKUMAHYPchXQT9GE+SGRlubFz/q 10wqmpEoGxlon3GuWaXXtvX6oBSGGZL6wXs19APjS+EXtqv0nOk+O1oYHXNEmNlknPKb dPD2t/i+p0lR3frW9fvidRwnDDxfwn6gxNy4ochXWWk34gMF3pMiJnnVEspCQOPnFpV0 XqJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wxzIINLdGpF4xvMnTT5HBiaWan3JduyNu4riRa0p4c8=; b=FKIqnzhm7eRVvZmVokywtzvuKNyp/GdL7N+M0PS84WubWfck2sT4PL1tESGaiFizQn WN1BRozmC5rBgwm7W6e0IqgsfMAQKO1meXFdTL/gSY4ewX17H6exiLvyWacuGQxpGSs1 g8PR8CX7eGI1mJ2KmRM8AC655xZsCTuhzTLWrZba5e6XI3hgoqB3W0VmJKr8vaco2GBl 5Ccj6ibBDpqd5pu0e9uwpfb8TWrztF4nCExhBZBxkcI9HEBAY/yI/y8ecuzo0Vnd/5K+ JBINUBlj6/k7dqUAaCkqovZZIZ2clV/eBrdiTPxxllvC6YMMRMR5sllMJ8uFj/+rtGrX UGmA== X-Gm-Message-State: AOAM533KTIVmLXLm3u2pVOx/LhoJw+3stPrCWfGsmRsN2oKjPUh6feUF 9hvsFxQvu/AgmHrvvIQo/r4t0akDu4I= X-Google-Smtp-Source: ABdhPJxI+HKTti1FgUT8+J3T5MlRUFsNPRaq+B8puxwFgWFcD8c4jZyeJmQRgS2xkLbWDvB5XT8ezA== X-Received: by 2002:a54:4007:: with SMTP id x7mr3519556oie.26.1627573711981; Thu, 29 Jul 2021 08:48:31 -0700 (PDT) Received: from nuclearis3.gtech (c-98-195-139-126.hsd1.tx.comcast.net. [98.195.139.126]) by smtp.gmail.com with ESMTPSA id e31sm598019ote.22.2021.07.29.08.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 08:48:31 -0700 (PDT) Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 To: Artem Panfilov , Tom Rini Cc: "u-boot@lists.denx.de" References: <20210728181023.25067-1-panfilov.artyom@gmail.com> <21fa035a-7ab5-7045-dd47-90670eb8be14@gmail.com> <20210728200701.GY9379@bill-the-cat> <34cdf0ed-c97d-e5ec-31ff-24e4ca085c4d@gmail.com> <20210728225619.GB9379@bill-the-cat> <20210728234351.GI9379@bill-the-cat> <028916da-5e0f-36d2-29bb-dccf30cfcf91@gmail.com> <20210729125946.GM9379@bill-the-cat> From: "Alex G." Message-ID: <387c820c-e012-46df-34f8-066fef263706@gmail.com> Date: Thu, 29 Jul 2021 10:48:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Artem On 7/29/21 9:52 AM, Artem Panfilov wrote: > On 29.07.2021 15:59, Tom Rini wrote: >> Well yes, this is part of the question now, is there enough interest in >> the old version to bother with?  The other part of the question is >> what's being built now that wasn't being built before, and is that a bug >> or a feature (a less CONFIG-dependent set of tools is good for generic >> distributions). > > OK, if someone else will report the same issue after u-boot release, > then it should be fixed. Currently, I am okay with my local fix > by disabling the CONFIG_TOOLS_LIBCRYPTO option. ECDSA signing was not verified against a libcrypto that old. Given that signatures are non-deterministic, I doubt we could have a CI test that says old-libcrypto, known block must equal known signature. When we added ECDSA, there was not a need to consider old libcrypto versions, but I also did not pay attention to the #ifdefs in the much older RSA path. I'm sorry that you had to go through the frustrations of getting a patch rejected which does something the codebase already does. I am going to take a look at cleaning up the RSA path. There's no point in maintaining backwards compatibility if we're not doing it across the board. Alex