From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A11C1C433F5 for ; Sun, 24 Oct 2021 15:46:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F21F860F12 for ; Sun, 24 Oct 2021 15:46:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F21F860F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C639F82E7D; Sun, 24 Oct 2021 17:46:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635090372; bh=uVG4Ic4jlv90nKFsvlEM33lKO+S/9pYwXYe2RtP+hJU=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nVrYDotHaq904s76hfojvrWt7Rvv55JqgkZJLuWI1Uq3mhS0ja+hFLFtV5fUFwDOa PSL5RNFRi5j0R5E8JrusHO38LD1o5ltnN1IOBh8WqPKOsybdcsd7dUHCBqgWRLs7+1 sqiQkpir3MM3i1VV2rLTMAgdm+fgUS3vnI9Px8G1+J9QYpOQ4dY548U/dS6MlFds3k o8l8tqK091h0Cfvx1MsE0KI1gxjBvIc36hpHAc/na/iyBS2NawS4x5L5GRSJm3g0ed Cp84D0sNKzmS8uce3jU3XuLnxv2QMfHpUVPp9KiF7IOr6zOEExF3rGYFSl4tvIKQ67 KcmbOapTi1+eA== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F313782ECC for ; Sun, 24 Oct 2021 17:46:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635090370; bh=uVG4Ic4jlv90nKFsvlEM33lKO+S/9pYwXYe2RtP+hJU=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=rTYRpQ7Woone2ESaOXDBdqwdeNAJjrzufp6jByRse/IWfavWKULWhe6pfbSdIgVEp 4TpsFkEpasNa4ESYaQyj5iiMSCjojBsVlB16LbC3POU2DF8FdAEpiFLMrQ41sfv6uM oUeL81b2lI5Vgd1U1C2D/Fabnc/SF9dg4ngag30yk4v7GqM+Rz8lHwlsbz5zR/mDC6 gef4nt/1LolSS0kQSjR2rQ88B5DiAUX8ZF0D7ucpwpjqhZESNha44HpTAsLgOXTHfV 3Xa3LfS9Yj9Y6Es1OrvtUBm6uPBGeFXNU8SdtykpD5WZOmpGNLoakPgqzcAcmx3BAk xHTN15I1E3O3w== Received: by janitor.denx.de (Postfix, from userid 108) id A2FAFA0120; Sun, 24 Oct 2021 17:46:09 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 74C21A006F; Sun, 24 Oct 2021 17:46:00 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 22F4C1E0F1B; Sun, 24 Oct 2021 17:46:00 +0200 (CEST) To: Tom Rini cc: Simon Glass , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211022144759.GG3577824@bill-the-cat> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> <3695947.1634821611@gemini.denx.de> <20211021152537.441c37b9@thinkpad> <20211021152831.15524883@thinkpad> <20211021160311.GC3577824@bill-the-cat> <3763481.1634890085@gemini.denx.de> <20211022144759.GG3577824@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Fri, 22 Oct 2021 10:47:59 -0400." Date: Sun, 24 Oct 2021 17:46:00 +0200 Message-ID: <3903411.1635090360@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211022144759.GG3577824@bill-the-cat> you wrote: > > > Any escape character is also a legal name character. > > I am struggling to have a non-meme reaction to this. Perhaps the best > step is just earlier on in the series note that variable names need to > fit within the broadly and commonly used set of characters and assorted > funny business you can do historically needs to be migrated. Indeed I think this is the most reasonable approach. Like you cannot write any aritrary code in plain C and have to fall back to assembler in a few places, this patch series should simply not claim to be able to support all legal environment settings. It is a convenience tool, and it is OK if it has a few restrictions, like for the character set of supported variable names. But: 1) These restrictions must be clearly documented, both in the commit message and in the related documentation/readme. 2) There should be another, more primitive way to generate environment settings without these restrictions.. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Whom the gods would destroy, they first teach BASIC.