From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5386C433EF for ; Mon, 14 Mar 2022 09:37:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6EBC883B67; Mon, 14 Mar 2022 10:37:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="PsLUds5c"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42B8183B67; Mon, 14 Mar 2022 10:37:17 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0CB2183B5C for ; Mon, 14 Mar 2022 10:37:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20220314093708epoutp0463145403ca4f2f2e97dbb96a974d68ec~cNbgzd1by1098310983epoutp04U for ; Mon, 14 Mar 2022 09:37:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20220314093708epoutp0463145403ca4f2f2e97dbb96a974d68ec~cNbgzd1by1098310983epoutp04U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1647250629; bh=A3EnsxfNDSSjCJ00mTL+RUrLkm3rORDxSVsXNFHo5qw=; h=Date:Subject:To:From:In-Reply-To:References:From; b=PsLUds5cUAlrvVNjxc4ODfPonf6RXbNKHzs2huZmrDO9oeusQrTssszAVsP4cWjRh KDbGr8DaO12wbuJb8gVUUMQTVFC/JgHavFnbTfALfXOsHKbEsGqriycepyg0cp6G12 J7FsYdZ5Dc+gtgCBwRPLg9kqpog3E0xgXwy4qhRg= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20220314093708epcas1p1e1601346ddb19051c81c9f5afc7ed568~cNbgjoQTB0228502285epcas1p1q; Mon, 14 Mar 2022 09:37:08 +0000 (GMT) Received: from epsmges1p4.samsung.com (unknown [182.195.36.132]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4KHBJc17gSz4x9QJ; Mon, 14 Mar 2022 09:37:04 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p4.samsung.com (Symantec Messaging Gateway) with SMTP id 20.1A.21932.0CC0F226; Mon, 14 Mar 2022 18:37:04 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20220314093703epcas1p437d8799f426e506607a7a764b7407e46~cNbbeMbWw1097510975epcas1p4I; Mon, 14 Mar 2022 09:37:03 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220314093703epsmtrp2dd5d95095e1948ade0b5fce8d38aebaa~cNbbdXhQB0118501185epsmtrp23; Mon, 14 Mar 2022 09:37:03 +0000 (GMT) X-AuditID: b6c32a38-93fff700000255ac-82-622f0cc0ea66 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id D8.1A.29871.FBC0F226; Mon, 14 Mar 2022 18:37:03 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220314093702epsmtip25a25897d11beb6a6e5ddf9069e1ac5e6~cNbbLFkxZ2516825168epsmtip2Z; Mon, 14 Mar 2022 09:37:02 +0000 (GMT) Message-ID: <39424ebb-eac3-7c94-20e0-02a73fa538e1@samsung.com> Date: Mon, 14 Mar 2022 18:37:02 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP Content-Language: en-US To: Robert Marko , sr@denx.de, peng.fan@nxp.com, stcarlso@linux.microsoft.com, u-boot@lists.denx.de, pali@kernel.org From: Jaehoon Chung In-Reply-To: <20220311181407.1930327-1-robert.marko@sartura.hr> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFJsWRmVeSWpSXmKPExsWy7bCmnu4BHv0kg3V9rBYL9pxms/ix6gur xdKrDhYn131gslj2ej6rxdu9newObB7zZp1g8di0qpPN49f2o0weZ+/sYPTY+G4Hk8eP773M AWxR2TYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QGco KZQl5pQChQISi4uV9O1sivJLS1IVMvKLS2yVUgtScgpMC/SKE3OLS/PS9fJSS6wMDQyMTIEK E7IzdvUtZS1oFKpYtzeigXE3XxcjJ4eEgInErY/9LF2MXBxCAjsYJfZdP8MI4XxilFjz5wEr hPONUeLOm3MsMC2vTi+DatnLKHFgxkmoqveMEq2n2tlBqngF7CSebTrHCmKzCKhKbH4zlxki LihxcuYTsEmiAhESL4/8ZQKxhQUcJH6u6QarYRYQl7j1ZD4TyFARgX5GievHboENZRPQkdj+ 7ThYA6eAvcSjJQ1MEA3yEtvfzmEGaZAQaOWQWD/vBdStLhIL7zRA2cISr45vYYewpSQ+v9vL BtHQzCixdMlBVginh1HiX8N1NogqY4n9SycDreAAWqEpsX6XPkRYUWLn77mMEJv5JN597WEF KZEQ4JXoaBOCKFGRuPT6JRPMrrtP/kOVeEg0X+eDhNYkRomN17cwTWBUmIUUMLOQAmAWkt9m IRyxgJFlFaNYakFxbnpqsWGBCTy+k/NzNzGCE6mWxQ7GuW8/6B1iZOJgPMQowcGsJMJrtVQv SYg3JbGyKrUoP76oNCe1+BCjKTB6JjJLiSbnA1N5Xkm8oYmlgYmZkbGJhaGZoZI4b+/U04lC AumJJanZqakFqUUwfUwcnFINTE6CFh6bDyncfPV+8Zacwz/eHVeqfrLwncTf+xtvxage5uL/ kDF5n5W3VoNjXbzP+Qcv1B7VKb01eh/6oU/4y8ypW7LKgyLTXB79nD3XQ1RXb7GHE7viN7EL acseMnQsFvqju/bE5HDXmSvNeFuKn9wO5XJ8sqkgauq3GOvXf1qadzvKPZOWWV8XIqj+/JF4 T8c8cUP5irn29W3flJV+/I0zZwt9dz6kpihKmr87IMVLf1/giiPekXxbJxS3KJ9J+cK46POC hp2Or5exmGslnl+c/PfWoUATX/dPwQwfOacfe37bUuB/x7Tfxz0ylGPmb59SeeZdrELv7SdV Rm4qXUrufz+G3jV7wtmT0jbnthJLcUaioRZzUXEiABDV/I4tBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsWy7bCSvO5+Hv0kg+3HOC0W7DnNZvFj1RdW i6VXHSxOrvvAZLHs9XxWi7d7O9kd2DzmzTrB4rFpVSebx6/tR5k8zt7Zweix8d0OJo8f33uZ A9iiuGxSUnMyy1KL9O0SuDJ29S1lLWgUqli3N6KBcTdfFyMnh4SAicSr08tYuhi5OIQEdjNK vL96kh0iISXx+elUti5GDiBbWOLw4WKImreMElt7fzKD1PAK2Ek823SOFcRmEVCV2PxmLlRc UOLkzCcsILaoQIRE27IpYHFhAQeJn2u6wWxmAXGJW0/mM4EMFRHoZ5S4cfALM8SGSYwSy5/8 AutmE9CR2P7tOBOIzSlgL/FoSQMTyEXMAuoS6+cJQQySl9j+dg7zBEbBWUh2z0KyYxZCxywk HQsYWVYxSqYWFOem5xYbFhjmpZbrFSfmFpfmpesl5+duYgTHhpbmDsbtqz7oHWJk4mA8xCjB wawkwmu1VC9JiDclsbIqtSg/vqg0J7X4EKM0B4uSOO+FrpPxQgLpiSWp2ampBalFMFkmDk6p BqaJsulTThuvme74yEzneuQh11ruogf5q6OEbA5o7fb/nmZw+c2qzaxb3+Ss+LLP5uNmsYSb Kw0vTzkip7tktVWCxT++vepBXicTOdcdfGf/h3uH/VWOn/MO/th6k73nqu4aznKeVc5ma+9u KCv9ZGfayXGuVrfIoWerU9qT6lcu++cVFBqsKRd4uu6/ealdxsNth3yOsj0P4vPdJSNZG/qK K57j7HnVqx+fvUxOuTV7Hfe9zfbbNi09rOmzv7X2yyL26Kl/Oc/PDKmtUnCbzfjnxf7ln3wd 5cT+bTLQ2CSQZRHXfq5fIkzS1WuGsISB3sTDBzX6z/Afd96yxjrjrYnTpEvyX32F3FOkWr7X GzIpsRRnJBpqMRcVJwIA5YhD7PwCAAA= X-CMS-MailID: 20220314093703epcas1p437d8799f426e506607a7a764b7407e46 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220311181417epcas1p4207a65f5b292a3ff7bb8e4c0092f0f18 References: <20220311181407.1930327-1-robert.marko@sartura.hr> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/12/22 03:14, Robert Marko wrote: > Generic SDHCI driver received support for checking the busy status by > polling the DAT[0] level instead of waiting for the worst MMC switch time. > > Unfortunately, it appears that this does not work for Xenon controllers > despite being a part of the standard SDHCI registers and the Armada 3720 > datasheet itself telling that BIT(20) is useful for detecting the DAT[0] > busy signal. > > I have tried increasing the timeout value, but I have newer managed to > catch DAT_LEVEL bits change from 0 at all. > > This issue appears to hit most if not all SoC-s supported by Xenon driver, > at least A3720, A8040 and CN9130 have non working eMMC currently. > > So, until a better solution is found drop the wait_dat0 OP for Xenon. > I was able to only test it on A3720, but it should work for others as well. > > Fixes: 40e6f52454fc ("drivers: mmc: Add wait_dat0 support for sdhci driver") > Signed-off-by: Robert Marko Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/xenon_sdhci.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/xenon_sdhci.c b/drivers/mmc/xenon_sdhci.c > index e292f2903d..2f8805096c 100644 > --- a/drivers/mmc/xenon_sdhci.c > +++ b/drivers/mmc/xenon_sdhci.c > @@ -439,6 +439,8 @@ static const struct sdhci_ops xenon_sdhci_ops = { > .set_ios_post = xenon_sdhci_set_ios_post > }; > > +static struct dm_mmc_ops xenon_mmc_ops; > + > static int xenon_sdhci_probe(struct udevice *dev) > { > struct xenon_sdhci_plat *plat = dev_get_plat(dev); > @@ -452,6 +454,9 @@ static int xenon_sdhci_probe(struct udevice *dev) > host->mmc->dev = dev; > upriv->mmc = host->mmc; > > + xenon_mmc_ops = sdhci_ops; > + xenon_mmc_ops.wait_dat0 = NULL; > + > /* Set quirks */ > host->quirks = SDHCI_QUIRK_WAIT_SEND_CMD | SDHCI_QUIRK_32BIT_DMA_ADDR; > > @@ -568,7 +573,7 @@ U_BOOT_DRIVER(xenon_sdhci_drv) = { > .id = UCLASS_MMC, > .of_match = xenon_sdhci_ids, > .of_to_plat = xenon_sdhci_of_to_plat, > - .ops = &sdhci_ops, > + .ops = &xenon_mmc_ops, > .bind = xenon_sdhci_bind, > .probe = xenon_sdhci_probe, > .remove = xenon_sdhci_remove,