[U-Boot] [PATCH v2 13/13] mxc nand: Add support for i.MX5

Benoît Thébaudeau
2012-11-16T20:28:16Z

On Friday, November 16, 2012 9:15:33 PM, Beno?t Th?baudeau wrote:
> Hi Scott,
>
> On Thursday, November 15, 2012 11:22:03 PM, Scott Wood wrote:
> > On 09/18/2012 01:11:21 PM, Tom Rini wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > On 09/17/12 17:36, Scott Wood wrote:
> > > > On Tue, Aug 21, 2012 at 11:04:14PM +0200, Beno?t Th?baudeau
> > > > wrote:
> > > >> Signed-off-by: Beno?t Th?baudeau
> > > >> <benoit.thebaudeau@advansee.com> Cc: Scott Wood
> > > >> <scottwood@freescale.com> Cc: Stefano Babic <sbabic@denx.de>
> > > >> ---
> > > >> Changes for v2: - Fix warning for unused tmp variable in
> > > >> board_nand_init() for NFC V1.
> > > >>
> > > >> .../arch/arm/include/asm/arch-mx5/imx-regs.h | 9 +
> > > >> .../drivers/mtd/nand/mxc_nand.c | 219
> > > >> +++++++++++++++----- .../include/fsl_nfc.h
> > > >> | 149 ++++++++----- .../nand_spl/nand_boot_fsl_nfc.c
> > > >> | 114 +++++++--- 4 files changed, 365 insertions(+), 126
> > > >> deletions(-)
> > > >
> > > > Unless Tom or Wolfgang object, I'm inclined to drop the
> > > > objection
> > > > to adding new hardware support to nand_spl in this case. I'd
> > > > rather see the support be merged rather than ignored because a
> > > > contributor has time for a small job but not a large one.
> > > > Plus,
> > > > this code will likely be reused by the new SPL support, if this
> > > > platform is space constrained, so it's not dead-end effort.
> > >
> > > I'm OK with pulling this in while providing an on-the-record prod
> > > to
> > > please find some time to do a conversion or two in time for
> > > v2013.01.
> >
> > I'm going to leave this one until there's a config added that uses
> > it,
> > so that we at least get compile-testing.
>
> OK.
>
> I won't be able to add my i.MX51 board to mainline before at least a
> few months.
>
> It's hard to find the schematics of all the i.MX5 boards supported by
> mainline
> U-Boot. According to the links below, at least the Genesi EFIKA MX
> Smartbook and
> the Freescale MX53 ARD boards have embedded NAND. Matt, Fabio, is it
> possible to
> find the schematics of these boards somewhere?
> http://www.genesi-tech.com/products/smartbook
> https://community.freescale.com/thread/289468
>
> The EFIKA MX Smartbook probably has MLC if we consider its NAND size.
> 4-kiB
> pages should be supported by nand_spl/nand_boot_fsl_nfc.c, but not
> yet by
> drivers/mtd/nand/mxc_nand.c. The latter currently has a
> CONFIG_SYS_NAND_LARGEPAGE to differentiate 512-B and 2-kiB pages. If
> we were to
> add support for 4-kiB pages to this driver, I think that this should
> be
> replaced with a CONFIG_SYS_NAND_PAGE_SIZE like in
> nand_boot_fsl_nfc.c. Do you
> agree?

Also, I've noticed that some of the oobfree fields of the nand_ecclayout
structures in mxc_nand.c are slightly different from what can be found in Linux.
Any idea about which one is correct (if any)?

This field does not even always start at offset 0 when it looks free according
to the ECC info. Is this normal?

Best regards,
Beno?t