public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vladimir Gurevich <vag@paulidav.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] {Patch]: A small bug in PCI command
Date: Tue, 11 Mar 2003 19:27:41 -0800	[thread overview]
Message-ID: <3E6EA92D.7050603@paulidav.org> (raw)

Hello,

I've just noticed that "pci" command (or pci header)
fails to show the device class properly.

The problem is that the function pci_classes_str
uses an array of pointers to strings to connvert the 
class and these pointers don't get relocated after
u-boot is moved into RAM. Thus they still point
to some addresses in FLASH, which is not correct.

Is it only my problem or other people have similar
experience?

We can either do manual relocation (same way how
cmd_tbl is relocated in board_init_r()) or
replace this table with a (ugly?) switch statement.
That's the patch attached.

Thanks,
Vladimir
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cmd_pci.diff
Url: http://lists.denx.de/pipermail/u-boot/attachments/20030311/6e6dd733/attachment.txt 

             reply	other threads:[~2003-03-12  3:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-12  3:27 Vladimir Gurevich [this message]
2003-03-12 19:40 ` [U-Boot-Users] [Patch]: A small bug in PCI command Vladimir Gurevich
2003-03-13  9:43   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E6EA92D.7050603@paulidav.org \
    --to=vag@paulidav.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox