From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pantelis Antoniou <panto@intracom.gr>
Date: Tue, 10 Jun 2003 09:48:08 +0300
Subject: [U-Boot-Users] Status LEDs status?
In-Reply-To: <20030609204914.C6F79C5FD7@atlas.denx.de>
References: <20030609204914.C6F79C5FD7@atlas.denx.de>
Message-ID: <3EE57F28.1020208@intracom.gr>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Wolfgang Denk wrote:

>In message <3EE47B1C.3090601@intracom.gr> you wrote:
>
snip

>
>If you have such a patch, please submit it. But please  note  that  I
>don't want to add any CPU specific code in the drivers/ directory.
>
>Best regards,
>
>Wolfgang Denk
>
>
OK

How about this patch.

The main idea is to do all the hardware specific stuff
in a header while the file in the drivers directory
is very simple and common to all the configurations.

The key is the new include file mpc_led.h which
implements the current behaviour for the 8xx/8260/5xx.

If your board has LEDs that don't fall into
the current scheme then in the board include file
you define CONFIG_BOARD_SPECIFIC_LED and provide
the __led_init __led_toggle and __led_set inline functions.

IMHO this cleans up the current scheme, allows boards
that have non standard LED configurations to work, and
I think makes it easier for arches other that ppc to
support LEDs.

Regards

Pantelis