From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27A8EC38142 for ; Fri, 27 Jan 2023 15:48:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3508785693; Fri, 27 Jan 2023 16:48:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ndp2Vlb/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1F4CE85720; Fri, 27 Jan 2023 16:02:50 +0100 (CET) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 226F2856D3 for ; Fri, 27 Jan 2023 16:00:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x630.google.com with SMTP id rl14so14497562ejb.2 for ; Fri, 27 Jan 2023 07:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p/ltCh7PtKZIsguwO1J2InoM7kXPyh2K4TTjXqHfNvM=; b=Ndp2Vlb/x3zC37BA+31yn5aX7OxvIEpL++iIIL5kg78FhKWPXnl6C8xe2gk2wVkwZV DGjn7NQA6QQNRmq416PeVvdpux1eJmWB76aOsGO7zIvlxBBp+4VjTDwEraX7TItvY+ch ILNerSIwPxXU0ypu+eRlCDHe4oUJxh13Sw8f6joZ4qreKVdEA5imzLc6KXR4VrBxpte6 eHTZ1ZqE01kDccAd5YOIxTWSqFUzqfHwAm4/QBR7DQnu9Wk5EKZJmPmkRNPj1kLGjVYp 5UgWUa+Y2tNra5s3XquPTLgUC58G89ElGhCGqGx+3VXSBJr4KleVVBbdxT7BDJwSp3PG SrHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p/ltCh7PtKZIsguwO1J2InoM7kXPyh2K4TTjXqHfNvM=; b=8K+2WGJsZsCpCpTPZF87xWO2/ZC2KwQOcAucjiHxG3YRZEPi9HjuTb54qkgy2DBRDE x1xckeGkUSH/UkeXxiAJqoUPu1NgB+N0UMXJlepU+uiMQLergkQr0UlIHSKzEreC1woF yuaULSK4k8BH4TPoL4u6cPJWSk/XewPFTO+PiuF9XAjMqd0/AgGzddMpFBOJ4R05v8Mr P7syN0PPtgRPdV5MkrM0Sa1W8p/O+8aP/gl+P8r2sYZDB/6jTJBYmVelysktp9wR+Pse 7V6avZBVP/xaK0Aih5zt6vW0V2Q/qvg+pBj+/xSbETKpbWCBgDDFBLYBH94wT7waM3q9 7gtw== X-Gm-Message-State: AO0yUKXZ71kcM/VjernSgF5aRPIm3t2SGj5uJ6+HUDrPmQyKmbqB6l0M eegKeSs1Biy/ckMn2NNhXVM= X-Google-Smtp-Source: AK7set+Mp9CJVN5Fb3okjWTccmSRVh4/qi+z8zaDEtoDpAsKun+Tgur0Ahyki8goNn7tcrzwFWAYJA== X-Received: by 2002:a17:907:6d0e:b0:87b:dc05:ec87 with SMTP id sa14-20020a1709076d0e00b0087bdc05ec87mr1834299ejc.57.1674831617813; Fri, 27 Jan 2023 07:00:17 -0800 (PST) Received: from [192.168.10.30] (126-5-142-46.pool.kielnet.net. [46.142.5.126]) by smtp.gmail.com with ESMTPSA id jl15-20020a17090775cf00b00878812a8d14sm1726854ejc.85.2023.01.27.07.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 07:00:17 -0800 (PST) Message-ID: <3a43b9e0-2c01-a94d-e7de-202989b9cedc@gmail.com> Date: Fri, 27 Jan 2023 16:00:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 02/88] treewide: Correct invalid Kconfig syntax and warnings Content-Language: en-US To: Tom Rini , Simon Glass Cc: u-boot@lists.denx.de, Adam Ford , Alexey Brodkin , Ashok Reddy Soma , Aswath Govindraju , Bharat Gooty , Bin Meng , Brandon Maier , Bryan Brattlof , Chris Packham , Dave Gerlach , Eugeniy Paltsev , Heinrich Schuchardt , Ilias Apalodimas , Jacky Bai , Jagan Teki , Jan Kiszka , Jim Liu , John Keeping , Kautuk Consul , Kever Yang , Le Jin , Lukasz Majewski , Marek Vasut , Masahisa Kojima , Michal Simek , Nobuhiro Iwamatsu , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Peng Fan , Philipp Tomsich , Philippe Reynes , Rasmus Villemoes , Rayagonda Kokatanur , Rick Chen , Samuel Holland , Sean Anderson , Stefan Bosch , Sughosh Ganu , Tianrui Wei , Vignesh Raghavendra , Weijie Gao , Ye Li , uboot-snps-arc@synopsys.com References: <20230123220031.3540724-1-sjg@chromium.org> <20230123220031.3540724-3-sjg@chromium.org> From: Daniel Schwierzeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 27 Jan 2023 16:48:43 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/27/23 14:45, Tom Rini wrote: > On Mon, Jan 23, 2023 at 02:59:05PM -0700, Simon Glass wrote: > >> In several places a 'select' is used to select a choice, which is not >> supported by Kconfig. In other places, the filename for the 'source' >> command is not in quites. >> >> Fix these two problems throughout the tree, so that kconfiglib does not >> show any more warnings. >> >> Signed-off-by: Simon Glass > > OK, to summarize what I just said in another email and clarify future > work. Please first split this patch in to its own series that corrects > each type of problem, per commit. The missing quotes for example, and > then the extra whitespace ones. Next, commenting out a select is wrong, > and each case needs to be better understood / fixed. I'm honestly not > sure if asking endianness for MIPS is right and if we should select that > from boards too, like ARC, but probably. The ARC_MMU one also should > just not be asked, I suspect, but as a separate patch where you cc > Alexey, we'll find out :) And so on, for each. Thanks. > For MIPS the endianess (and also architecture/ISA level) needs to be able to be set by the user via menuconfig as most MIPS cores or SoCs can support multiple variants. The idea is that the specific SoC or machine just sets the supported options to restrict the options the user can choose. The board's defconfig should set the required default value for each option but must not *select* it. See the Boston board for example: config TARGET_BOSTON bool "Support Boston" ... select SUPPORTS_BIG_ENDIAN select SUPPORTS_CPU_MIPS32_R1 select SUPPORTS_CPU_MIPS32_R2 select SUPPORTS_CPU_MIPS32_R6 select SUPPORTS_CPU_MIPS64_R1 select SUPPORTS_CPU_MIPS64_R2 select SUPPORTS_CPU_MIPS64_R6 select SUPPORTS_LITTLE_ENDIAN A possible fix for ARC could be: --- a/arch/Kconfig +++ b/arch/Kconfig @@ -53,8 +53,6 @@ config ARC select SUPPORT_OF_CONTROL select SYS_CACHE_SHIFT_7 select TIMER - select SYS_BIG_ENDIAN if CPU_BIG_ENDIAN - select SYS_LITTLE_ENDIAN if !CPU_BIG_ENDIAN config ARM bool "ARM architecture" @@ -490,7 +488,7 @@ endif source "board/keymile/Kconfig" -if MIPS || MICROBLAZE +if MIPS || MICROBLAZE || ARC choice prompt "Endianness selection" @@ -502,11 +500,11 @@ choice config SYS_BIG_ENDIAN bool "Big endian" - depends on (SUPPORTS_BIG_ENDIAN && MIPS) || MICROBLAZE + depends on (SUPPORTS_BIG_ENDIAN && MIPS) || MICROBLAZE || (CPU_BIG_ENDIAN && ARC) config SYS_LITTLE_ENDIAN bool "Little endian" - depends on (SUPPORTS_LITTLE_ENDIAN && MIPS) || MICROBLAZE + depends on (SUPPORTS_LITTLE_ENDIAN && MIPS) || MICROBLAZE || (CPU_LITTLE_ENDIAN && ARC) endchoice A *make savedefconfig* should than automatically add *CONFIG_SYS_LITTLE_ENDIAN=y* or *CONFIG_SYS_BIG_ENDIAN=y* to the ARC board defconfig's. -- - Daniel