From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 21/21] sf: Fix s25fs512s id param table
Date: Thu, 17 Nov 2016 09:27:31 +0530 [thread overview]
Message-ID: <3a5fae2e-e9d9-922f-4c00-96fd03436ab4@ti.com> (raw)
In-Reply-To: <CAD6G_RQvWPFoLD3eYVZRnCiE=z=wTPAd8phuBJkCyVOkuKYRDA@mail.gmail.com>
On Wednesday 16 November 2016 07:17 PM, Jagan Teki wrote:
> On Wed, Nov 16, 2016 at 6:34 PM, Siva Durga Prasad Paladugu
[...]
>>>>> diff --git a/drivers/mtd/spi/spi_flash_ids.c
>>>>> b/drivers/mtd/spi/spi_flash_ids.c index 4ec2255..8f9520f 100644
>>>>> --- a/drivers/mtd/spi/spi_flash_ids.c
>>>>> +++ b/drivers/mtd/spi/spi_flash_ids.c
>>>>> @@ -99,7 +99,7 @@ const struct spi_flash_info spi_flash_ids[] = {
>>>>> {"s25fl256s_256k", INFO(0x010219, 0x4d00, 256 * 1024, 128,
>>>>> RD_FULL | WR_QPP) },
>>>>> {"s25fl256s_64k", INFO(0x010219, 0x4d01, 64 * 1024, 512, RD_FULL
>>>>> | WR_QPP) },
>>>>> {"s25fs256s_64k", INFO6(0x010219, 0x4d0181, 64 * 1024, 512,
>>>>> RD_FULL | WR_QPP | SECT_4K) },
>>>>> - {"s25fs512s", INFO(0x010220, 0x4d00, 128 * 1024, 512, RD_FULL |
>>>>> WR_QPP) },
>>>>> + {"s25fs512s", INFO6(0x010220, 0x4d0081, 128 * 1024, 512,
>>>>> RD_FULL | WR_QPP) },
>>>>
>>>> As I said in my earlier comments, Please add SECT_4K, otherwise it will be
>>> broken.
>>>
>>> If SECT_4K need then it should be an existing issue, but Vignesh R tested this
>>> already. Vignesh any comment?
No, I gave my Tested-by for s25fl512s and not for s25fs series. Before
this patch, s25fl512s was detected as s25fs512s and flash writes used to
fail on s25fl512s. After this patch, s25fl512s is detected correctly
and flash writes are fine.
>> No, previously, you are disabling 4K sector erase using spansion_s25fss_disable_4KB_erase() routine and
>> making the device as uniform sector size and hence I think no issues previously without 4k erase commands.
>> But now, as you removed it(spansion_s25fss_disable_4KB_erase() ) in 10/21, normal sector erase command may not work on top/bottom sectors with 4k sector size
>> and it may fail now.
>
> OK, Wait for Vignesh test will update that fix as well.
>
> thanks!
>
--
Regards
Vignesh
next prev parent reply other threads:[~2016-11-17 3:57 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 4:02 [U-Boot] [PATCH v6 00/21] sf: Updates on flash detection Jagan Teki
2016-11-16 4:02 ` [U-Boot] [PATCH v6 01/21] sf: Adopt flash table INFO macro from Linux Jagan Teki
2016-11-16 5:23 ` Siva Durga Prasad Paladugu
2016-11-16 12:39 ` Jagan Teki
2016-11-16 12:51 ` Siva Durga Prasad Paladugu
2016-11-18 7:05 ` Siva Durga Prasad Paladugu
2016-11-17 0:29 ` york sun
2016-11-16 4:02 ` [U-Boot] [PATCH v6 02/21] sf: Simplify lock ops detection code Jagan Teki
2016-11-16 5:38 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 03/21] sf: sandbox: Use JEDEC_MFR|ID in id exctract Jagan Teki
2016-11-16 5:42 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 04/21] sf: Cleanup spi_flash_info{} Jagan Teki
2016-11-16 5:49 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 05/21] sf: nr_sectors -> n_sectors Jagan Teki
2016-11-16 5:52 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 06/21] sf: Add SPI_FLASH_MAX_ID_LEN Jagan Teki
2016-11-16 5:56 ` Siva Durga Prasad Paladugu
2016-11-16 12:42 ` Jagan Teki
2016-11-16 13:07 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 07/21] sf: Increase max id length by 1 byte Jagan Teki
2016-11-16 6:00 ` Siva Durga Prasad Paladugu
2016-11-16 6:02 ` Siva Durga Prasad Paladugu
2016-11-16 4:02 ` [U-Boot] [PATCH v6 08/21] sf: Add INFO6 flash_info macro Jagan Teki
2016-11-16 6:09 ` Siva Durga Prasad Paladugu
2016-11-16 12:24 ` Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 09/21] sf: params: Add S25FS256S_64K spi flash support Jagan Teki
2016-11-16 6:34 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 10/21] sf: Remove legacy idcode detection code Jagan Teki
2016-11-16 6:40 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 11/21] sf: Remove non-meaningful comments Jagan Teki
2016-11-16 6:42 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 12/21] sf: Rename sf_params.c to spi_flash_ids.c Jagan Teki
2016-11-16 6:44 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 13/21] sf: ids: Use small letter's with flash name Jagan Teki
2016-11-16 6:48 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 14/21] sf: ids: Use small letter in ext_jedec Jagan Teki
2016-11-16 6:50 ` Siva Durga Prasad Paladugu
2016-11-16 4:03 ` [U-Boot] [PATCH v6 15/21] sf: Rename few local functions Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 16/21] spi: Remove dual flash options/flags Jagan Teki
2016-11-16 6:57 ` Siva Durga Prasad Paladugu
2016-11-16 13:52 ` Jagan Teki
2016-11-17 6:23 ` Siva Durga Prasad Paladugu
2016-11-17 6:28 ` Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 17/21] sf: dataflash: Remove unneeded spi data Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 18/21] sf: dataflash: Move flash id detection into jedec_probe Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 19/21] sf: dataflash: Fix add_dataflash return logic Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 20/21] sf: dataflash: Minor cleanups Jagan Teki
2016-11-16 4:03 ` [U-Boot] [PATCH v6 21/21] sf: Fix s25fs512s id param table Jagan Teki
2016-11-16 7:02 ` Siva Durga Prasad Paladugu
2016-11-16 12:45 ` Jagan Teki
2016-11-16 13:04 ` Siva Durga Prasad Paladugu
2016-11-16 13:47 ` Jagan Teki
2016-11-16 18:00 ` Jagan Teki
2016-11-17 3:57 ` Vignesh R [this message]
2016-11-18 11:09 ` [U-Boot] [PATCH v6 00/21] sf: Updates on flash detection Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a5fae2e-e9d9-922f-4c00-96fd03436ab4@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox