From: Alex G. <mr.nuke.me@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing
Date: Thu, 7 Jan 2021 16:24:05 -0600 [thread overview]
Message-ID: <3a76022e-5860-0901-edd4-5e4ea62dabaa@gmail.com> (raw)
In-Reply-To: <20210107172503.GA2292@bill-the-cat>
On 1/7/21 11:25 AM, Tom Rini wrote:
> On Thu, Jan 07, 2021 at 10:27:50AM -0600, Alex G. wrote:
>> On 1/7/21 6:35 AM, Simon Glass wrote:
>>> Hi Alexandru,
>>
>> Hi Simon,
>>
>> (pun alert!) A lot of your comments have to do with comments. I use comments
>> as a tool to add something of value to code. When the code is
>> self-documenting, comments don't help much.
>> See kernel coding style chapter 8.
>
> Comments for comments sake are bad. Comments so that we can also have
> reasonable generated documentation are good. Function prototypes fall
> in to that second category to me, with few exceptions (and that we have
> lots of bad examples isn't a good reason). The function names may well
> make it obvious what's going on but the comments allow for generated
> documentation to include that when explaining the not so obvious parts.
> Thanks!
>
The problem with generated documentation is that it's not very useful.
People add comments for the sake of comments to have something
generated. Most often you end up with a detailed description of all the
details, but almost never the big picture. Nowadays, I don't even waste
my time reading generated documentation.
I am getting ready to send the new series with the goodies requested by
Simon. I don't find the new comments to be useful, and I find some to
spread out the code such that it hurts readability. They will be there
because you and Simon asked nicely, although I think you're wrong.
Alex
next prev parent reply other threads:[~2021-01-07 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 21:00 [PATCH RFC v2 0/5] Add support for ECDSA image signing (with test) Alexandru Gagniuc
2020-12-30 21:00 ` [PATCH RFC v2 1/5] lib: Rename rsa-checksum.c to hash-checksum.c Alexandru Gagniuc
2021-01-07 12:35 ` Simon Glass
2020-12-30 21:00 ` [PATCH RFC v2 2/5] lib/rsa: Make fdt_add_bignum() available outside of RSA code Alexandru Gagniuc
2021-01-07 12:35 ` Simon Glass
2020-12-30 21:00 ` [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing Alexandru Gagniuc
2021-01-07 12:35 ` Simon Glass
2021-01-07 16:27 ` Alex G.
2021-01-07 17:25 ` Tom Rini
2021-01-07 22:24 ` Alex G. [this message]
2021-01-07 17:29 ` Simon Glass
2021-01-07 19:56 ` Alex G.
2020-12-30 21:00 ` [PATCH RFC v2 4/5] doc: signature.txt: Document devicetree format for ECDSA keys Alexandru Gagniuc
2021-01-07 12:35 ` Simon Glass
2020-12-30 21:00 ` [PATCH RFC v2 5/5] test/py: ecdsa: Add test for mkimage ECDSA signing Alexandru Gagniuc
2021-01-07 12:35 ` Simon Glass
2021-01-07 16:44 ` Alex G.
2021-01-07 17:31 ` Simon Glass
2021-01-07 18:44 ` Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a76022e-5860-0901-edd4-5e4ea62dabaa@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox