public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] [PATCH] Command history and Command buffer editing
@ 2005-09-27 12:59 J Mac
  2005-09-27 20:19 ` [U-Boot-Users] " J Mac
  2005-11-16 23:49 ` [U-Boot-Users] " Keith J Outwater
  0 siblings, 2 replies; 3+ messages in thread
From: J Mac @ 2005-09-27 12:59 UTC (permalink / raw)
  To: u-boot

I made this patch using 'diff' on two source trees;  I got the original copies
of the files from the gitweb interface at source.denx.net.  I used the
'diff -purN OLD NEW' command as described in README to generate the patch.

All code changes are local to common/main.c

Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the
behaviour(s).

Please let me know if there is something I need to do to make the patch
acceptable.

* Patch by James MacAulay Sept 27, 2005
	- Add a configuration option CONFIG_COMMAND_HISTORY to implement command
	  history.  Uses up and down arrow keys to scroll through history.  Other
	  options are described in README.
	- Add a configuration option CONFIG_COMMAND_EDIT to implement command
	  buffer editing.  Uses ^A, ^E, left and right arrow keys to move through
	  command buffer.  Other options are described in README.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: command_history_and_edit.patch.tar.gz
Type: application/x-gzip
Size: 3803 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050927/b76c2190/attachment.bin 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] Re: [PATCH] Command history and Command buffer editing
  2005-09-27 12:59 [U-Boot-Users] [PATCH] Command history and Command buffer editing J Mac
@ 2005-09-27 20:19 ` J Mac
  2005-11-16 23:49 ` [U-Boot-Users] " Keith J Outwater
  1 sibling, 0 replies; 3+ messages in thread
From: J Mac @ 2005-09-27 20:19 UTC (permalink / raw)
  To: u-boot

d'oh!

I discovered a foolish mistake in my patch release methods.  I missed
a last minute update  to the included headers section.  here is the
new patch...

* Patch by James MacAulay Sept 27, 2005
       - Add a configuration option CONFIG_COMMAND_HISTORY to implement command
         history.  Uses up and down arrow keys to scroll through history.  Other
         options are described in README.
       - Add a configuration option CONFIG_COMMAND_EDIT to implement command
         buffer editing.  Uses ^A, ^E, left and right arrow keys to move through
         command buffer.  Other options are described in README.

On 9/27/05, J Mac <macamirix.com@gmail.com> wrote:
> I made this patch using 'diff' on two source trees;  I got the original copies
> of the files from the gitweb interface at source.denx.net.  I used the
> 'diff -purN OLD NEW' command as described in README to generate the patch.
>
> All code changes are local to common/main.c
>
> Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the
> behaviour(s).
>
> Please let me know if there is something I need to do to make the patch
> acceptable.
>
> * Patch by James MacAulay Sept 27, 2005
>         - Add a configuration option CONFIG_COMMAND_HISTORY to implement command
>           history.  Uses up and down arrow keys to scroll through history.  Other
>           options are described in README.
>         - Add a configuration option CONFIG_COMMAND_EDIT to implement command
>           buffer editing.  Uses ^A, ^E, left and right arrow keys to move through
>           command buffer.  Other options are described in README.
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: command_history_and_edit.patch.tar.gz
Type: application/x-gzip
Size: 3869 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050927/f2a0241f/attachment.bin 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot-Users] [PATCH] Command history and Command buffer editing
  2005-09-27 12:59 [U-Boot-Users] [PATCH] Command history and Command buffer editing J Mac
  2005-09-27 20:19 ` [U-Boot-Users] " J Mac
@ 2005-11-16 23:49 ` Keith J Outwater
  1 sibling, 0 replies; 3+ messages in thread
From: Keith J Outwater @ 2005-11-16 23:49 UTC (permalink / raw)
  To: u-boot

James - 
I applied this patch when you first sent it out to my local development 
sources
and had no problems.  I really like the added functionality.

I would definitely vote for adding it.

A suggestion:  How about modifying things so that only unique commands get 
added
to the history?  In other words, if I type 'printenv' two consecutive 
times,
only add the command once to the history buffer.

Keith

> I made this patch using 'diff' on two source trees;  I got the original 
copies
> of the files from the gitweb interface at source.denx.net.  I used the
> 'diff -purN OLD NEW' command as described in README to generate the 
patch.
> 
> All code changes are local to common/main.c
> 
> Define CONFIG_COMMAND_HISTORY and/or CONFIG_COMMAND_EDIT to enable the
> behaviour(s).
> 
> Please let me know if there is something I need to do to make the patch
> acceptable.
> 
> * Patch by James MacAulay Sept 27, 2005
>    - Add a configuration option CONFIG_COMMAND_HISTORY to implement 
command
>      history.  Uses up and down arrow keys to scroll through history. 
Other
>      options are described in README.
>    - Add a configuration option CONFIG_COMMAND_EDIT to implement command
>      buffer editing.  Uses ^A, ^E, left and right arrow keys to move 
through
>      command buffer.  Other options are described in README.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-11-16 23:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-27 12:59 [U-Boot-Users] [PATCH] Command history and Command buffer editing J Mac
2005-09-27 20:19 ` [U-Boot-Users] " J Mac
2005-11-16 23:49 ` [U-Boot-Users] " Keith J Outwater

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox