From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E72C4743E for ; Sun, 6 Jun 2021 16:34:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 397A061370 for ; Sun, 6 Jun 2021 16:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397A061370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 54172814A4; Sun, 6 Jun 2021 18:34:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Gwe7oybD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8923B81780; Sun, 6 Jun 2021 18:34:09 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B193A80C68 for ; Sun, 6 Jun 2021 18:34:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x72e.google.com with SMTP id 76so14401281qkn.13 for ; Sun, 06 Jun 2021 09:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eGQiJCMT3KTlwW9UssJgPBQEGyUwBA5qF28Lrxbofe4=; b=Gwe7oybDwtr2f6oZW5d358UbMAW5oYm7Czj8QPRe6/31S77D2J1thWDUKfs5xUMed8 epFzL91cQwFOoINLuBPvVwwALodXhHRR2fFgaV94HWhxE2uO9PbOzUfuSF8Nur51vdxu 9I/Vd08qlohE8XlugBTpoW9BnvNdeOCDBzTW9EhjjH/NK5d+Uxjd0azWUopEcee78l8C A1OUhagwG0nxp0ZB8X0dJYLAc1I2JHQLnD+ph5SeUzRouQn3vI3VXpmmQCpDlBaWOvEy qwBRMCAL2V4gs07yg/FM0SYm/qy3dS/kg01BXrvM+IXB5NfzjZ+gaStQG5JcRUE/oP+x neZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eGQiJCMT3KTlwW9UssJgPBQEGyUwBA5qF28Lrxbofe4=; b=Pm/4xaAUdoaZw43lFy5RDB3QcWyHLlhtb8mDHEkdptu2bCo/Bmv9oXRQuKOON5u4xv IBtTPD0o+lYJpjurzjFXhGTUgqFGJds1iZm0+uZT+obaHvaM2rylDsxCBehHSbApohfh UuWHBijkR8F0Tkk7/t/+uy5Z/sJTvyl/qXARXOZpVBVLbO8ElBsm6iEndMzKT7mgn3De lMUUjWp3UqI8gh5ZxEdtHvZ2Csindz/RzMJx5F+GNfjiZaGy36l829APZtHWfKx+2fkx B0EDugjG3qHXOHJp1DMVC11CfAnwKqrecKeO5SNq5ustXx6iAT7Vf/m0jD3wlXYRnv74 v/1A== X-Gm-Message-State: AOAM533U5xGobnQkFuev1va2P7++f9MvqMDllwY0IzLR7VeTk0UiQQAc zx5E6pOvGj6WRlWXpSHsPcI= X-Google-Smtp-Source: ABdhPJwcAj47pUaGEBNJghJGsPN/zzXMi4GJMEOl7YwP/O9D4/T527zgxtNCBp7Y5N4fq9ikPJ2pxQ== X-Received: by 2002:a37:6084:: with SMTP id u126mr13308474qkb.294.1622997244244; Sun, 06 Jun 2021 09:34:04 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id 7sm7705167qtu.38.2021.06.06.09.34.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Jun 2021 09:34:03 -0700 (PDT) Subject: Re: [PATCH V5 1/2] mmc: add OpenPiton mmc support To: Tianrui Wei , u-boot@lists.denx.de Cc: ycliang@andestech.com, rick@andestech.com, peng.fan@nxp.com, jh80.chung@samsung.com, jbalkind@ucsb.edu, bmeng.cn@gmail.com, xypron.glpk@gmx.de References: From: Sean Anderson Message-ID: <3b2fc708-b9ec-b49f-08e3-69ef79fbcb39@gmail.com> Date: Sun, 6 Jun 2021 12:34:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/4/21 12:52 AM, Tianrui Wei wrote: > From: Tianrui Wei > Date: Fri, 4 June 2021 12:45:29 +0800 > Subject: [PATCH v5 1/2] mmc: add OpenPiton mmc support > > This patch adds mmc support for OpenPiton board. > > Changelog: > > v5: move definitions around, changed some incompatible type information > > Signed-off-by: Tianrui Wei > Signed-off-by: Jonathan Balkind > --- > > drivers/mmc/Kconfig | 7 + > drivers/mmc/Makefile | 1 + > drivers/mmc/piton_mmc.c | 174 +++++ > 3 files changed, 182 insertions(+) > create mode 100644 drivers/mmc/piton_mmc.c > > diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig > index 14d79139..1038800f 100644 > --- a/drivers/mmc/Kconfig > +++ b/drivers/mmc/Kconfig > @@ -707,6 +707,13 @@ config MMC_SUNXI_HAS_MODE_SWITCH > bool > depends on MMC_SUNXI > > +config MMC_PITON > + bool "MMC support for openpiton SoC" > + depends on DM_MMC && BLK > + help > + This driver enables SD card support in U-Boot port for We already know it's for U-Boot ;) > + OpenPiton SoC Please add a bit more than this. In particular, it would be useful to note that this is an "emulated" device where the host does all of the work. > + > config GENERIC_ATMEL_MCI > bool "Atmel Multimedia Card Interface support" > depends on DM_MMC && BLK && ARCH_AT91 > diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile > index 1c849cba..698dfe05 100644 > --- a/drivers/mmc/Makefile > +++ b/drivers/mmc/Makefile > @@ -71,6 +71,7 @@ obj-$(CONFIG_MMC_SDHCI_XENON) += xenon_sdhci.o > obj-$(CONFIG_MMC_SDHCI_ZYNQ) += zynq_sdhci.o > > obj-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o > +obj-$(CONFIG_MMC_PITON) += piton_mmc.o > obj-$(CONFIG_MMC_UNIPHIER) += tmio-common.o uniphier-sd.o > obj-$(CONFIG_RENESAS_SDHI) += tmio-common.o renesas-sdhi.o > obj-$(CONFIG_MMC_BCM2835) += bcm2835_sdhost.o > diff --git a/drivers/mmc/piton_mmc.c b/drivers/mmc/piton_mmc.c > new file mode 100644 > index 00000000..2b2d5756 > --- /dev/null > +++ b/drivers/mmc/piton_mmc.c > @@ -0,0 +1,174 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * (C) Copyright 2009 SAMSUNG Electronics > + * Minkyu Kang > + * Jaehoon Chung > + * Portions Copyright 2011-2019 NVIDIA Corporation > + * Portions Copyright 2021 Tianrui Wei > + * This file is adapted from tegra_mmc.c > + * Tianrui Wei > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct piton_mmc_plat { > + struct mmc_config cfg; > + struct mmc mmc; > +}; > + > +struct piton_mmc_priv { > + u64 piton_mmc_base_addr; /* peripheral id */ Again, please use void __iomem *. > +}; > + > +/* > + * see mmc_read_blocks to see how it is used. > + * start block is hidden at cmd->arg Hidden? > + * also, initialize the block size at init > + */ > +static int piton_mmc_send_cmd(struct udevice *dev, struct mmc_cmd *cmd, > + struct mmc_data *data) Nit: alignment > +{ > + /* check first if this is a pure command */ > + if (!data) > + return 0; Variable declarations come before code. > + > + u64 byte_cnt, start_block, start_addr; I think these should be size_t, since you use it for pointer arithmetic. > + > + struct piton_mmc_priv *priv = dev_get_priv(dev); > + unsigned long *buff = (unsigned long *)data->dest; > + > + start_addr = priv->piton_mmc_base_addr + (start_block); > + byte_cnt = data->blocks * data->blocksize; What should happen if (byte_cnt & 3)? > + start_block = cmd->cmdarg; > + > + /* if there is a read */ > + if (data->flags & MMC_DATA_READ) { > + for (u64 i = 0; i < byte_cnt; i += 4) { Declare i with the rest of the variables. > + *(buff) = readl((void *)(start_addr + i)); I think this could be rewritten as size_t byte_cnt; u32 *buff, *start_addr; /* ... */ for (byte_cnt = /* ... */; byte_cnt; byte_cnt -= sizeof(u32)); *buff++ = readl(start_addr++); Which more closely follows the model of memcpy. Speaking of which, I thought you were going to use it: > Scratch the previous email, I stand corrected. You're right about > memcpy could work, thanks for the great suggestion :P What happened to that? > + buff++; > + } > + } else { > + /* else there is a write > + * we don't handle write, so error right away > + */ > + return -ENODEV; Please use -ENOSYS. See [1] for details. In general, several of my comments on your previous patch are still unaddressed. I would like if you could either respond to them with your reasoning for not addressing them, or implement them. --Sean [1] https://u-boot.readthedocs.io/en/latest/develop/driver-model/design.html#error-codes > + } > + > + return 0; > +} > + > +static int piton_mmc_ofdata_to_platdata(struct udevice *dev) > +{ > + struct piton_mmc_priv *priv = dev_get_priv(dev); > + struct piton_mmc_plat *plat = dev_get_platdata(dev); > + struct mmc_config *cfg; > + struct mmc *mmc; > + /* fill in device description */ > + struct blk_desc *bdesc; > + > + priv->piton_mmc_base_addr = dev_read_addr(dev); > + cfg = &plat->cfg; > + cfg->name = "PITON MMC"; > + cfg->host_caps = MMC_MODE_8BIT; > + cfg->f_max = 100000; > + cfg->f_min = 400000; > + cfg->voltages = MMC_VDD_21_22; > + > + mmc = &plat->mmc; > + mmc->read_bl_len = MMC_MAX_BLOCK_LEN; > + mmc->capacity_user = 0x100000000; > + mmc->capacity_user *= mmc->read_bl_len; > + mmc->capacity_boot = 0; > + mmc->capacity_rpmb = 0; > + for (int i = 0; i < 4; i++) > + mmc->capacity_gp[i] = 0; > + mmc->capacity = 0x2000000000ULL; > + mmc->has_init = 1; > + > + bdesc = mmc_get_blk_desc(mmc); > + bdesc->lun = 0; > + bdesc->hwpart = 0; > + bdesc->type = 0; > + bdesc->blksz = mmc->read_bl_len; > + bdesc->log2blksz = LOG2(bdesc->blksz); > + bdesc->lba = lldiv(mmc->capacity, mmc->read_bl_len); > + > + return 0; > +} > + > +/* test if piton has the micro mmc card present > + * always return 1, which means present > + */ > +static int piton_mmc_getcd(struct udevice *dev) > +{ > + /* > + * always return 1 > + */ > + return 1; > +} > + > +/* dummy function, piton_mmc don't need initialization > + * in hw > + */ > +static const struct dm_mmc_ops piton_mmc_ops = { > + .send_cmd = piton_mmc_send_cmd, > + .get_cd = piton_mmc_getcd, > +}; > + > +static int piton_mmc_probe(struct udevice *dev) > +{ > + struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev); > + struct piton_mmc_plat *plat = dev_get_platdata(dev); > + struct mmc_config *cfg = &plat->cfg; > + > + cfg->name = dev->name; > + upriv->mmc = &plat->mmc; > + upriv->mmc->has_init = 1; > + upriv->mmc->capacity = 0x2000000000ULL; > + upriv->mmc->read_bl_len = MMC_MAX_BLOCK_LEN; > + > + return 0; > +} > + > +static int piton_mmc_bind(struct udevice *dev) > +{ > + struct piton_mmc_plat *plat = dev_get_platdata(dev); > + struct mmc_config *cfg = &plat->cfg; > + > + cfg->name = dev->name; > + cfg->host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS | MMC_MODE_8BIT; > + cfg->voltages = MMC_VDD_165_195 | MMC_VDD_32_33 | MMC_VDD_33_34; > + cfg->f_min = 1000000; > + cfg->f_max = 52000000; > + cfg->b_max = U32_MAX; > + > + return mmc_bind(dev, &plat->mmc, cfg); > +} > + > +static const struct udevice_id piton_mmc_ids[] = { > + {.compatible = "openpiton,piton-mmc"}, > + { /* sentinel */ } > +}; > + > +U_BOOT_DRIVER(piton_mmc_drv) = { > + .name = "piton_mmc", > + .id = UCLASS_MMC, > + .of_match = piton_mmc_ids, > + .ofdata_to_platdata = piton_mmc_ofdata_to_platdata, > + .bind = piton_mmc_bind, > + .probe = piton_mmc_probe, > + .ops = &piton_mmc_ops, > + .platdata_auto_alloc_size = sizeof(struct piton_mmc_plat), > + .priv_auto_alloc_size = sizeof(struct piton_mmc_priv), > +}; >