From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACB21EB64DD for ; Wed, 26 Jul 2023 01:47:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AE0048676D; Wed, 26 Jul 2023 03:47:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 40ECC86778; Wed, 26 Jul 2023 03:47:32 +0200 (CEST) Received: from mail-m11886.qiye.163.com (mail-m11886.qiye.163.com [115.236.118.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 74A128674E for ; Wed, 26 Jul 2023 03:47:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11886.qiye.163.com (Hmail) with ESMTPA id C01398014A; Wed, 26 Jul 2023 09:47:12 +0800 (CST) Message-ID: <3b6efea7-e288-a3af-5bd6-18d01caa4823@rock-chips.com> Date: Wed, 26 Jul 2023 09:47:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 0/3] board: rockchip: Add Hardkernel ODROID-M1 Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich Cc: Stefan Agner , u-boot@lists.denx.de References: <20230722140209.1897117-1-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230722140209.1897117-1-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkMdTVZOSkweHU1JShgYTE9VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a898fe0f8872ebakusnc01398014a X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Mxg6Ejo*AT1NTE1DFzNMETYo Tj5PCi5VSlVKTUJLSEhNS0hIT0tOVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFPQ0NONwY+ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Jonas,     Could you split this patchset into two patch set?     I can take the patch 3, but the patch 1~2 is suppose to go to other maintainer's tree, unless those patches got ACK from maintainer. Thanks,  - Kever On 2023/7/22 22:02, Jonas Karlman wrote: > This series add support for Hardkernel ODROID-M1, a single board > computer with a RK3568B2 SoC. > > First patch fixes a build issue in the dwc_ahci driver. > > Second patch fixes a build warning in the ini command. > > Third patch import the device tree from linux v6.4 and add a defconfig > for Hardkernel ODROID-M1. > > Following was tested on a ODROID-M1 8GB v1.0 2022-06-13: > - SD-card boot > - eMMC boot > - SPI Flash boot > - PCIe/NVMe/AHCI > - SATA port > - USB host > > Changes in v3: > - Remove vcc5v0_usb_host regulator-always-on workaround > - Remove CONFIG_ETH_DESIGNWARE=y and CONFIG_GMAC_ROCKCHIP=y > > Changes in v2: > - Add new patch to fix build warning in the ini command > - Enable CMD_MTD, CMD_INI and CMD_CRAMFS to closer > match downstream legacy U-Boot > - Do not override spi0 alias, use SF_DEFAULT_BUS=4 > - Collect r-b and t-b tags > > With the new options added in v2 it is possible to load downstream > petitboot from SD-card using following commands: > > load mmc 1:1 $fdt_addr_r rk3568-odroid-m1.dtb > load mmc 1:1 $cramfsaddr ODROIDBIOS.BIN > cramfsload $scriptaddr boot.scr > source $scriptaddr > > This series have loose dependencies on the following series: > - rockchip: Fix PCIe and NVMe support on RK3568 [1] > - rockchip: rk3568: Use dwc3-generic driver [2] > - rockchip: rk3568: Fix alloc space exhausted in SPL [3] > - rockchip: rk3568: Device Tree updates [4] > - rockchip: rk35xx: Fix SPI Flash alias [5] > > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=365195 > [2] https://patchwork.ozlabs.org/project/uboot/list/?series=364127 > [3] https://patchwork.ozlabs.org/project/uboot/list/?series=361999 > [4] https://patchwork.ozlabs.org/project/uboot/list/?series=362030 > [5] https://patchwork.ozlabs.org/project/uboot/list/?series=363527 > > Jonas Karlman (3): > ata: dwc_ahci: Fix support for other platforms > cmd: ini: Fix build warning > board: rockchip: Add Hardkernel ODROID-M1 > > arch/arm/dts/Makefile | 1 + > arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi | 37 ++ > arch/arm/dts/rk3568-odroid-m1.dts | 744 ++++++++++++++++++++++ > arch/arm/mach-rockchip/rk3568/Kconfig | 6 + > board/hardkernel/odroid_m1/Kconfig | 15 + > board/hardkernel/odroid_m1/MAINTAINERS | 8 + > board/hardkernel/odroid_m1/Makefile | 3 + > board/hardkernel/odroid_m1/odroid_m1.c | 1 + > cmd/ini.c | 2 +- > configs/odroid-m1-rk3568_defconfig | 111 ++++ > doc/board/rockchip/rockchip.rst | 1 + > drivers/ata/dwc_ahci.c | 4 + > include/configs/odroid_m1.h | 11 + > 13 files changed, 943 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/dts/rk3568-odroid-m1-u-boot.dtsi > create mode 100644 arch/arm/dts/rk3568-odroid-m1.dts > create mode 100644 board/hardkernel/odroid_m1/Kconfig > create mode 100644 board/hardkernel/odroid_m1/MAINTAINERS > create mode 100644 board/hardkernel/odroid_m1/Makefile > create mode 100644 board/hardkernel/odroid_m1/odroid_m1.c > create mode 100644 configs/odroid-m1-rk3568_defconfig > create mode 100644 include/configs/odroid_m1.h >