From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE3DC4338F for ; Fri, 13 Aug 2021 09:38:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B418161038 for ; Fri, 13 Aug 2021 09:38:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B418161038 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=prevas.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB75A82D95; Fri, 13 Aug 2021 11:38:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="SDPXnIyA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 27A7B82DBC; Fri, 13 Aug 2021 11:38:24 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03on070c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe09::70c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BA4D582DDA for ; Fri, 13 Aug 2021 11:38:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D3JM9ia46HV18ju0Kc3KvPrm9XqpNLXkz/mugKMZTLuF7qLwCExyA8EKwxn38qyEJbl6MoO+O8WV5TjYYpDUd/jrazbRIHsDk1dutuYKyQfTS9mK1jJR2g5eRUy5iwmBoTjVLNEWgoMySqkJi8or0/Pdh8NfbkwM1bmEklNgIn39plThTxi8hOqAU+1dypgT9ZIyYBrjbCG+pDaWZbYLxRLTmF1h94uQ15xcZapxpkJ8O7MaFTH9tLJ137WnG/KS2EpSAOsOTgMwfUA+5BSsCj0y401VUxJ3nstOIarHZrfSjvNeSGmRtcQUJNqdGeyBUyH+IpiEPFMkTxLN+pnJFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eWs71kUoCOie00W9cB+NoUjMvZf/qJvS80RBzU6vkY=; b=FpDRX1pY/kAzfixQi/z6ijzF7lMSJvNgraHAmnbFqF/aFEhLt45Xzy64RU+Hhm40sBNvk1XUiYXPsdN4mfAlBTzhIrrQK3zlz3m7BmY42rZYkJlaNZgLuIafrUNkRW6IWRbEsM3S09xkjD+PHy/yX2mUts0GiIF5MNuqr7nYOKhhT1oF46kXlYAkJC74dIsSS4A1R8cN0TC2a78O1o0M6y3OCRC1TxXyIWdIdGSUY3piPtOn99yGFaZ1Y43yfq7tLdQloQzjti5Bw0Fjujhy59HqqmvzYU4aGz4V6x9RzEJ6hMaA132S4Y7x5GU7ZvjmogAFErUCWscZ+5t73CWJfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6eWs71kUoCOie00W9cB+NoUjMvZf/qJvS80RBzU6vkY=; b=SDPXnIyAdzWzWBXvvaYD1wst2KJelFeAH3riCLXvMQE737pnEJIEu9g7kJbY28SBcSPmJq73opDoo9+XhGG70PQuYGtcXv02DFEozG2y+xbLUnrkFTCT6ZHbFvmMTjEKQ2rB0NnR4Glp0THGvIFEcUOifweWtPd05ur+Usr292o= Authentication-Results: konsulko.com; dkim=none (message not signed) header.d=none;konsulko.com; dmarc=none action=none header.from=prevas.dk; Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) by AM0PR10MB3330.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Fri, 13 Aug 2021 09:38:18 +0000 Received: from AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc83:36a5:db02:3dbb]) by AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM ([fe80::fc83:36a5:db02:3dbb%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 09:38:18 +0000 Subject: Re: [PATCH v4 3/3] arm64: Kconfig: Enable usage of optimized memset/memcpy/memmove To: Stefan Roese , u-boot@lists.denx.de Cc: Wolfgang Denk , sjg@chromium.org, trini@konsulko.com References: <20210812144751.2563707-1-sr@denx.de> <20210812144751.2563707-4-sr@denx.de> From: Rasmus Villemoes Message-ID: <3bdbc28d-e000-ef0a-3277-abdad4023310@prevas.dk> Date: Fri, 13 Aug 2021 11:38:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210812144751.2563707-4-sr@denx.de> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0016.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::29) To AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:3f::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.149] (80.208.69.72) by AM6PR10CA0016.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Fri, 13 Aug 2021 09:38:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 307dc8d3-ba79-410b-76ed-08d95e3e1519 X-MS-TrafficTypeDiagnostic: AM0PR10MB3330: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x5xxTXu6Bn7UGtx2tdckZdo0rkYQ8sI4UHGExizOWyHROL/lQnrs3U/M6UqHh+HcQ4Sm4jKF9Veq+uyZqbZhmXfkbNzFdQazH55zLRhE4yLVSh/NMXq/UjisdA42BS33Z4EWznWMbgS7aVLwJ+mZbsLz88+Bbiv9ecUwLu41h4zo894TLbWP5gwPLo3bYqFliA/5GoJTvwHgwYGqUCJy6fnuryW6Sj2qE/+Azq/GT9zdtWKstR1Lks0ZTIZJns2idRwclOTAXgZWlPq3g+1Fhuwjd+p2FrTv+Sjh9yr2IEHtQvfdPbHWze1ArWWSkH5+nGhQhuzsOavRup/H3Jh6ZPBa236WCYiGxfCsOTyNdtqF/zZyBtFswMjxNUCh8lq3sWd96mymLVz7zUE2EQAxwSWcu3CCxdRzgDvPziKmkJUDvQxXRJxHP8OVDSuVfuf0HhUYFGfHxUFmvPOAs2WjLi0ygnQ4u7nnmKPZWxgyaelTfXzrSYcEHRUUbqsA9LX4pDWxgxRAyXVgHDicQ+cMVwi6WJ0yyEiOdH4yJrTSTbAoE0iNVHRbtPc4bpNKTPaavGOTBqtMXaqj5VYxTHmJlq8xRxNKR03SbzvnoltVivz8/6mtsj++kEvrU0V8VUFiFzGF3yhQPX8cw0ZjeDtvu46QaTVdE9awkvKN0R2iqQS489dV6/fhZScob145Lg5xYSF/ITz34R68+ItFtuMtq4ABbesXkB5JwkxHSfUnUCdpTR/E9zajpGedLvjgV0VKHE25QiJPwROEXTKGKzigYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(136003)(346002)(376002)(39840400004)(396003)(366004)(4326008)(16576012)(316002)(52116002)(956004)(31686004)(66946007)(2616005)(186003)(5660300002)(66476007)(8936002)(8976002)(8676002)(478600001)(38350700002)(38100700002)(66556008)(6486002)(36756003)(83380400001)(31696002)(26005)(2906002)(86362001)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?nbUIoEB5jsxqs/BF3mQ//nXOTJYQi5p1QblhBo2k/e9QFckP/Ohz5eyp?= =?Windows-1252?Q?IpzVznjPKBRh6WzCR5aXpHv3gClUHwW/UXhB1SyoO3qaYc2dgNN/43g/?= =?Windows-1252?Q?ASSk+AfZK2Q41XXFCiYqdi3ktHpu2NIc2Ugr3Wb44C5UI2L7kOkfhT40?= =?Windows-1252?Q?/1AHduvBnvOjDlK4bWXy3x55OyrTEV9+qqhJ2qoT88TLDbADu+Zc16HS?= =?Windows-1252?Q?of1szJX134wgGjils/saO9kn/KOaosd1j6R8E+RIqM+msChAWNgLbHEZ?= =?Windows-1252?Q?mlNQJca06i/SJI3Q8Xx3JUa2X8s3WXzz2WOOYiZOilG9PewBQCDC5Rl9?= =?Windows-1252?Q?1prI56Ha+gwjhpffpLV6FtnCU+VZDUmHfBpwYcUnjjFT+opdrXyB0Ku4?= =?Windows-1252?Q?NN+NBW1ZhaM9f3bpzmTYO3+MHJOMppzLgjm3Cv9RjfuxGRy1+UfJMp75?= =?Windows-1252?Q?w0thOmXMifDm9UK4lY7j0TgHtVl1fcWHy8Rj0xxnfPQYFNUwSx+KxLvk?= =?Windows-1252?Q?f4aGQKQQ9dhS0kmL6/32UdTevkd/zvuTw3xgMMjLHNRyCHAjd/QsW/e0?= =?Windows-1252?Q?E2HOdx2OGUzb4133zX7uNdNSKtgoDyk+rrojhmaEOsy+v+0CgSR8VjOk?= =?Windows-1252?Q?JaABL3iwPkw5GUT1TGqOMhij1sJ7ptqMiz97PnnyBsYnKfpjk223OqAC?= =?Windows-1252?Q?sFA1QYuAPHyDWo2tH8CRj3s2G+bJ5xphWXciRT7XM8oKb8Hzq242Vf01?= =?Windows-1252?Q?J0iUtocZpbpmA4h/TCEtsYR4xX5Gi4tJIeMz4eZqQuLbIqaQwIi8jOio?= =?Windows-1252?Q?YKw+fU7QuGA1ZIcrFqKGrAEdmLfxjmnxrqRe9iJ58ttM+10OrY04xCyv?= =?Windows-1252?Q?FXmYEVg133m6qpamj7lBS1CV6oJC7ZiM9Mdmv3yIgWJDC1UqIjBE5Xnx?= =?Windows-1252?Q?9EDSDvbv8Zq9H5nOQXUENREV5ENe+LsrEcdoDsODCx67Uf0Ta5FdVjlX?= =?Windows-1252?Q?4KGtgvKXUXO01vGKZj2VgpHpJfm8OcZcLhpX5eY8/yKz327ZEpWhTMaR?= =?Windows-1252?Q?Skvrpm87Sz03J+ol4zy8t5alK9x59k27Zvug9qsDO1sZlcL0oK97bNFN?= =?Windows-1252?Q?X2vHLrtvqOucebb7vA+DgJRq46K9OAlUD72WiU4qB6zbLmWI/AEpIfV/?= =?Windows-1252?Q?MorzR5t77Of6udnUp8wA2yK/tW89Y/Y5YW+tmy1jJQjAxxDvFbkJGlDd?= =?Windows-1252?Q?C4HBh4YsfYSxquSOdpOT0VDp5w7V+sjYo5BIiVDmPNWmH7yEEyFY/ZZC?= =?Windows-1252?Q?MOPZtSQ6fU7/udTkZySEGbVQJ99jFwelf08Nu5XA73AS6ghouU6PK2xq?= =?Windows-1252?Q?nDGpEa8hSTQsauT8ZK6nVrumj0KT75uLokwg3Cfu7K8yccgdUwVnJk5n?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 307dc8d3-ba79-410b-76ed-08d95e3e1519 X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB1874.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 09:38:18.5578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ukLjMSDCJ6uZ6Vv0+K5kCwb/BpBEPScB35zxbS9yuOJVbWaAhyP1ZwSJneu5QhltC2QTqiGC4zNF8P3rVQCUcwq72L+lgb23yXiWax0MSms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3330 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/08/2021 16.47, Stefan Roese wrote: > This patch enables the use of the optimized memset(), memmove() & > memcpy() versions recently added on ARM64. > > Signed-off-by: Stefan Roese > > > +config USE_ARCH_MEMMOVE > + bool "Use an assembly optimized implementation of memmove" > + default y > + depends on ARM64 > + help > + Enable the generation of an optimized version of memmove. > + Such an implementation may be faster under some conditions > + but may increase the binary size. Hm. I don't think you can allow making this separately (de)selectable, since if the optimized memcpy is selected, the memmove comes unconditionally for free [and it would be a bit silly to guard the ENTRY_ALIAS() by a CONFIG check IMO]. So with USE_ARCH_MEMCPY=y, USE_ARCH_MEMMOVE=n, I think you'd get a "multiple definitions of memmove" error. So on arm64, I think USE_ARCH_MEMMOVE should simply be an unchangeable alias for USE_ARCH_MEMCPY (and similarly for the SPL/TPL variants). In Kconfig, I think one could spell this bool "Use an ..." if !ARM64 default USE_ARCH_MEMCPY if ARM64 depends on ARM64 where the last line can be removed if an when there's a separate memmove for arm32 that one should be allowed to select. Rasmus