Re: [PATCH 1/2] board: phytec: am62a7: Add PHYTEC phyCORE-AM62A7 SoM

Garrett Giordano
2024-11-19T00:22:54Z

Hey Tom,

On 11/18/24 06:10, Tom Rini wrote:
> On Fri, Nov 15, 2024 at 11:50:54AM -0800, Garrett Giordano wrote:
>
>> Add support for PHYTEC phyCORE-AM62A7 SoM.
>>
>> Supported features:
>> - 2GB LPDDR4 RAM
>> - eMMC
>> - External SD
>> - Ethernet
>> - debug UART
>>
>> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
> [snip]
>> diff --git a/board/phytec/phycore_am62ax/phycore-am62ax.c b/board/phytec/phycore_am62ax/phycore-am62ax.c
>> new file mode 100644
>> index 00000000000..60752f431d1
>> --- /dev/null
>> +++ b/board/phytec/phycore_am62ax/phycore-am62ax.c
>> @@ -0,0 +1,66 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
>> +/*
>> + * Copyright (C) 2024 PHYTEC America LLC
>> + * Author: Garrett Giordano <ggiordano@phytec.com>
>> + */
>> +
>> +#include <asm/arch/hardware.h>
>> +#include <asm/io.h>
>> +#include <spl.h>
>> +#include <fdt_support.h>
>> +
>> +#include "../common/am6_som_detection.h"
>> +
>> +DECLARE_GLOBAL_DATA_PTR;
>> +
> But you don't use gd in the code, so this can go away. With that
> removed:
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
Good catch, I will drop the declaration and pick up your Reviewed-by in v2.

Regards,

Garrett