From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Thu, 25 Jan 2018 10:01:11 +0900 Subject: [U-Boot] [PATCH 1/7] mmc: uniphier-sd: Use mmc_of_parse() In-Reply-To: <20180116171703.14361-1-marek.vasut+renesas@gmail.com> References: <20180116171703.14361-1-marek.vasut+renesas@gmail.com> Message-ID: <3c282e46-8cd1-ff17-7a1d-e178cffd1d6e@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 01/17/2018 02:16 AM, Marek Vasut wrote: > Drop the ad-hoc DT caps parsing in favor of common framework function. > > Signed-off-by: Marek Vasut > Cc: Jaehoon Chung > Cc: Masahiro Yamada If Masahiro is ok, i will pick this patch and others to u-boot-mmc. Best Regards, Jaehoon Chung > --- > drivers/mmc/uniphier-sd.c | 23 +++++++---------------- > 1 file changed, 7 insertions(+), 16 deletions(-) > > diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c > index 741f9dfd9c..552e37d852 100644 > --- a/drivers/mmc/uniphier-sd.c > +++ b/drivers/mmc/uniphier-sd.c > @@ -799,24 +799,15 @@ static int uniphier_sd_probe(struct udevice *dev) > return ret; > } > > - plat->cfg.name = dev->name; > - plat->cfg.host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS; > - > - switch (fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev), "bus-width", > - 1)) { > - case 8: > - plat->cfg.host_caps |= MMC_MODE_8BIT; > - break; > - case 4: > - plat->cfg.host_caps |= MMC_MODE_4BIT; > - break; > - case 1: > - break; > - default: > - dev_err(dev, "Invalid \"bus-width\" value\n"); > - return -EINVAL; > + ret = mmc_of_parse(dev, &plat->cfg); > + if (ret < 0) { > + dev_err(dev, "failed to parse host caps\n"); > + return ret; > } > > + plat->cfg.name = dev->name; > + plat->cfg.host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS; > + > if (quirks) { > priv->caps = quirks; > } else { >