From: Sean Anderson <seanga2@gmail.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Alper Nebi Yasak <alpernebiyasak@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCH 5/4] mkimage: update man page and -h output
Date: Mon, 6 Nov 2023 19:46:33 -0500 [thread overview]
Message-ID: <3c84d65a-fe72-8fe1-6f64-7065889641ea@gmail.com> (raw)
In-Reply-To: <7b7878a9-c0dd-4d3b-b888-2a6a190109f2@prevas.dk>
On 10/13/23 14:30, Rasmus Villemoes wrote:
> On 12/10/2023 04.17, Sean Anderson wrote:
>
>> I was hoping you would respond to my most-recent email regarding this
>> series.
>> In particular:
>>
>> | Why does mkimage have to do this? Can't you just use truncate or, in a
>> | binman context, align-size?
>
> In both cases, that just affects the size of the file, but does not
> affect the totalsize field in the fdt header.
Use `dtc -a` then.
> Wrt. binman, just as I was somewhat misled by the short mkimage -h
> output into thinking that this already worked as I expected, binman's
> fit,align documentation can also be read that way - and the
> _implementation_ certainly currently unconditionally translates a
> fit,align property into a -B argument to mkimage. So if we don't want
> mkimage to support a -B by itself, binman documentation and code would
> probably need another patch to reject that as well.
Yeah, that's a good idea.
--Sean
next prev parent reply other threads:[~2023-11-07 0:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:37 [PATCH 0/4] mkimage: also honour -B even without external data Rasmus Villemoes
2023-09-19 11:37 ` [PATCH 1/4] " Rasmus Villemoes
2023-09-21 1:02 ` Simon Glass
2023-09-21 7:57 ` Rasmus Villemoes
2023-09-22 15:26 ` Simon Glass
2023-09-25 8:47 ` Rasmus Villemoes
2023-09-25 13:10 ` Simon Glass
2023-09-25 13:25 ` Rasmus Villemoes
2023-09-27 19:02 ` Sean Anderson
2023-09-28 7:10 ` Rasmus Villemoes
2023-09-29 13:16 ` Sean Anderson
2023-11-04 19:43 ` Simon Glass
2023-11-06 8:15 ` Rasmus Villemoes
2023-09-19 11:37 ` [PATCH 2/4] binman: test: rename 275_fit_align.dts -> 275_fit_align_external.dts Rasmus Villemoes
2023-09-21 1:02 ` Simon Glass
2023-09-19 11:37 ` [PATCH 3/4] tools: binman: add test case for fit, align without fit, external-offset Rasmus Villemoes
2023-09-21 1:03 ` Simon Glass
2023-09-19 11:37 ` [PATCH 4/4] binman: update documentation for fit,align property Rasmus Villemoes
2023-09-21 1:03 ` Simon Glass
2023-09-25 15:14 ` Jonas Karlman
2023-09-26 6:25 ` Rasmus Villemoes
2023-09-27 14:19 ` Simon Glass
2023-09-28 8:02 ` [PATCH 5/4] mkimage: update man page and -h output Rasmus Villemoes
2023-10-02 1:17 ` Simon Glass
2023-10-11 18:37 ` Tom Rini
2023-10-11 19:07 ` Rasmus Villemoes
2023-10-11 19:33 ` Tom Rini
2023-10-12 2:40 ` Simon Glass
2023-10-12 2:17 ` Sean Anderson
2023-10-12 12:02 ` Tom Rini
2023-10-13 18:30 ` Rasmus Villemoes
2023-11-07 0:46 ` Sean Anderson [this message]
2023-11-07 7:30 ` Rasmus Villemoes
2023-11-07 7:33 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c84d65a-fe72-8fe1-6f64-7065889641ea@gmail.com \
--to=seanga2@gmail.com \
--cc=alpernebiyasak@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox