From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2] cmd: Ensure sf operates on spi flash
Date: Tue, 4 Feb 2020 09:10:32 -0500 [thread overview]
Message-ID: <3cade2c1-7d74-4afb-93ec-54037d210a7e@gmail.com> (raw)
In-Reply-To: <CAEUhbmUOSJcTZGjBfWCY8Wx+b56kr+x2DbRFvVzbOM_82mx-hg@mail.gmail.com>
On 2/4/20 5:49 AM, Bin Meng wrote:
> Hi Sean,
>
> On Mon, Jan 20, 2020 at 7:13 AM Sean Anderson <seanga2@gmail.com> wrote:
>>
>> Currently, the sf command will probe anything attached to an spi bus, regardless
>> of whether it is UCLASS_SPI_FLASH. This came up when testing the mmc_spi driver,
>
> Did you do something like:
>
> => sf probe 1 0
sf probe 0, but yes. I forgot that my spi bus 0 had the SD card on it
not the spi flash. I feel like this sort of thing should be caught by
u-boot to prevent the user from almost certainly causing a segfault.
--Sean
prev parent reply other threads:[~2020-02-04 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 23:02 [PATCH] cmd: Ensure sf operates on spi flash Sean Anderson
2020-01-19 23:13 ` [PATCH v2] " Sean Anderson
2020-02-04 10:49 ` Bin Meng
2020-02-04 14:10 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cade2c1-7d74-4afb-93ec-54037d210a7e@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox