From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F041C433EF for ; Thu, 19 May 2022 11:40:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C37528429D; Thu, 19 May 2022 13:39:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="c/rKmy1m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7D13B84281; Thu, 19 May 2022 13:39:36 +0200 (CEST) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE1B683D9B for ; Thu, 19 May 2022 13:39:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x62b.google.com with SMTP id ch13so9317555ejb.12 for ; Thu, 19 May 2022 04:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=4r+GzzIPkTG70E+JH7swDqzFYbmEmolMqANnpZy4b3I=; b=c/rKmy1m2xRE3AWyAXSDsVcysptpEM99xFrgxR0tAUrNNeTwS8ns2tciS5sLuKtnf4 jX/srfWX65Vg+Ll+RtOoFHpovnrZZreKFdi8aIAFcgT50h5XHHmmevTyShqvbe530RDl dKlLrg6zdnYIFYOCClZPqc6N8Vg0UgwbThl1cWUFVgxfB4ByiKoBw20jnZP1cVrinXuo d4aw//FG8zfnKGCypYQefw4104VMrf74i4apsGifvwwmxaateBIIts3tn1n3+sIH4uBx thn4Dm5Er69SS3xqq4g5TxGb3d7fNtWmi6uYvndmLCNDR/e2XJgMyDFjsW+4Ac+ggXsw DyaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=4r+GzzIPkTG70E+JH7swDqzFYbmEmolMqANnpZy4b3I=; b=mFyPMYDObacWILOsEzBN0UmiWHtT74pN+x2Ry15J3EqS7zSy8dODrtXd/qezWuSlih PtiN/xGoaZU726xrfvWjpYO2Ey7c4f3hzW6BhOjksul6qu4Is8inBC/y5FCyyWmnYPKZ 0hBkJpNov0L8yNjw/Cp3vBTf6pE0p8tShACYmonREE1CHK0Hu9SIEo6PjYjvCJZ1YOjP TBxi2gN+6+o16KBJWo4NBqkQfddUJXu/tFkRxrHS/JfwWYpEXXjsFVYpBBoeFSRn37Q4 1pSoSC+8I2ONvaUd4u2hXK6JD3GAZTbkHadaPBMYnEyBNu8KlcgoReJJ7r2Wb6CYd7uu oGvQ== X-Gm-Message-State: AOAM530VvGKTOhrZvEJV7IrA7AehPBbOvKY85jB/m6ECIcW31PmAWvJD MVEgDReStFCDItzaFX7aerU= X-Google-Smtp-Source: ABdhPJwFKkn6FOfaMiGgoThA2PvfvD2pQZLccR2Dw1KKPbjc9HiQNKfyjp0vS9GPSIeHFzFKoRbf9g== X-Received: by 2002:a17:907:980e:b0:6f5:222a:334e with SMTP id ji14-20020a170907980e00b006f5222a334emr3596881ejc.643.1652960371139; Thu, 19 May 2022 04:39:31 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id ml19-20020a170906cc1300b006fe9ea76d20sm316492ejb.174.2022.05.19.04.39.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 May 2022 04:39:30 -0700 (PDT) Message-ID: <3cd4b24e-018a-9474-cf76-8f1fdfb72186@gmail.com> Date: Thu, 19 May 2022 14:36:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 From: Alper Nebi Yasak Subject: Re: [RFC PATCH v2 3/8] soc: rockchip: Include common U-Boot dtsi file To: Andrew Abbott Cc: Jagan Teki , Johan Jonker , Simon Glass , Samuel Dionne-Riel , Peter Robinson , Kever Yang , Philipp Tomsich , U-Boot Mailing List References: <20220516110712.178958-1-andrew@mirx.dev> <20220516110712.178958-4-andrew@mirx.dev> Content-Language: en-US In-Reply-To: <20220516110712.178958-4-andrew@mirx.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 16/05/2022 14:07, Andrew Abbott wrote: > This pulls in binman definitions so images can be built for all > Rockchip platforms. > > Signed-off-by: Andrew Abbott > --- See Simon's patch [1] for this, which contains these changes and is more complete. I think the 'imply BINMAN's there achieve the same thing as your 'select BINMAN if SPL' in patch 6/8, but I'm not sure which is better. [1] rockchip: Include binman script in 64-bit boards https://lore.kernel.org/u-boot/20220306031917.3005215-24-sjg@chromium.org/ > > (no changes since v1) > > arch/arm/dts/rk3308-u-boot.dtsi | 2 ++ > arch/arm/dts/rk3328-u-boot.dtsi | 2 ++ > arch/arm/dts/rk3368-u-boot.dtsi | 1 + > arch/arm/dts/rk3568-u-boot.dtsi | 2 ++ > 4 files changed, 7 insertions(+) > > diff --git a/arch/arm/dts/rk3308-u-boot.dtsi b/arch/arm/dts/rk3308-u-boot.dtsi > index 4bfad31fba..ab5bfc2ce9 100644 > --- a/arch/arm/dts/rk3308-u-boot.dtsi > +++ b/arch/arm/dts/rk3308-u-boot.dtsi > @@ -3,6 +3,8 @@ > *(C) Copyright 2019 Rockchip Electronics Co., Ltd > */ > > +#include "rockchip-u-boot.dtsi" > + > / { > aliases { > mmc0 = &emmc; > diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi > index 1633558264..d4a7540a92 100644 > --- a/arch/arm/dts/rk3328-u-boot.dtsi > +++ b/arch/arm/dts/rk3328-u-boot.dtsi > @@ -3,6 +3,8 @@ > * (C) Copyright 2019 Rockchip Electronics Co., Ltd > */ > > +#include "rockchip-u-boot.dtsi" > + > / { > aliases { > mmc0 = &emmc; > diff --git a/arch/arm/dts/rk3368-u-boot.dtsi b/arch/arm/dts/rk3368-u-boot.dtsi > index 2767c2678d..b37da4e851 100644 > --- a/arch/arm/dts/rk3368-u-boot.dtsi > +++ b/arch/arm/dts/rk3368-u-boot.dtsi > @@ -3,6 +3,7 @@ > * Copyright (c) 2020 Theobroma Systems Design und Consulting GmbH > */ > > +#include "rockchip-u-boot.dtsi" > #include > > / { > diff --git a/arch/arm/dts/rk3568-u-boot.dtsi b/arch/arm/dts/rk3568-u-boot.dtsi > index 5a80dda275..fa9b6ae23b 100644 > --- a/arch/arm/dts/rk3568-u-boot.dtsi > +++ b/arch/arm/dts/rk3568-u-boot.dtsi > @@ -3,6 +3,8 @@ > * (C) Copyright 2021 Rockchip Electronics Co., Ltd > */ > > +#include "rockchip-u-boot.dtsi" > + > / { > aliases { > mmc0 = &sdhci;