From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA1D5C00140 for ; Tue, 9 Aug 2022 03:29:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3834984566; Tue, 9 Aug 2022 05:29:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MkEXW1cf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B336849AA; Tue, 9 Aug 2022 05:29:34 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5DE2D84566 for ; Tue, 9 Aug 2022 05:29:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=f.fainelli@gmail.com Received: by mail-qk1-x732.google.com with SMTP id d8so3277446qkk.1 for ; Mon, 08 Aug 2022 20:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=rV52VFQkRSsKwH0o7EqggGgQBFNqeL52m3rss+wgizs=; b=MkEXW1cf02b0+vtPBYUpHN6/qWXEighgiqELwPu9D+uybMviCCIFlV38Ile/3Vd0bd p2cPK6OUE+nvzvCobVpiX0X1UNOmrpmz1W/3E5EixjMJzsK8OxuVt03VpGeBcSCn339l AjFGF0HagUAgJlI6An3rB0w+/SZUK/8+pgH9YvT/eeea4Y/sqHtf7BCjAZTHC1eEMOSh CnYLYcUw2e0e1i6XcszHNXDDOu56Oa2yFiBisfKFcchPWWnLao3nMPv8aYHWVSyaWQ54 4L1PhC9pCkbaWS2miUNC09yjKNY+Z9x/a4m23k+EmY49zCn64sgIzqnsEGnfEoDYIZ7w SO6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=rV52VFQkRSsKwH0o7EqggGgQBFNqeL52m3rss+wgizs=; b=DDYe28eB+nA8t+uNCZlhS2V9IpytkFwN3YjcjVBDvnZT8W48dXwnO0A1M1SIdn0aRj APhW7W4r69is06elFhwUEbFqaBAo1ugplbcGKL0iFh+XgbdeYzS9jOvbe5YvfsWFnZAX CzFFjNDhwnTJ6U+o2QWGFCIUFDz3fTWlTU8NYSIWie6ZbKhTlFcaWvmBEHXmsvsiow55 sE6Mf65wG3/dHUQWa8Cg8rX8EVC7f7Sft1az6Z+RLkRdaKkJjdAD9NED4MHtC+Y8uhjX F+931E1Wj9Mp2OloEDSc2nUM644DVGjOYY8N44StOIC3Ygw9u/SJOkVcINPVVzr59zSF G0Jg== X-Gm-Message-State: ACgBeo1B7wA+qumptQhHBp9UnPoEkYtZpkD1TE82iVxrO2L62FtD2zBm kISJdylBXeiRxwMhQwC+qRg= X-Google-Smtp-Source: AA6agR5l5Ys/EDmhyCg8Juf8UCwiMp8ycodHEOJ8bWY9BtOPry5d7LiCM5MYy7cJi/xaGEIGSx4ANw== X-Received: by 2002:a37:43d4:0:b0:6b8:e3ba:ddfc with SMTP id q203-20020a3743d4000000b006b8e3baddfcmr15895790qka.192.1660015770137; Mon, 08 Aug 2022 20:29:30 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id i5-20020a05620a248500b006b5fc79427fsm11295532qkn.77.2022.08.08.20.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Aug 2022 20:29:29 -0700 (PDT) Message-ID: <3ec9470f-3cfb-dd16-7180-287c6b176df2@gmail.com> Date: Mon, 8 Aug 2022 20:29:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH 0/4] arm: bcmbca: add basic support for more Broadcom BCA SoCs Content-Language: en-US To: William Zhang , U-Boot Mailing List Cc: kursad.oney@broadcom.com, dan.beygelman@broadcom.com, joel.peshkin@broadcom.com, philippe.reynes@softathome.com, rafal@milecki.pl, anand.gore@broadcom.com, Andre Przywara , Christian Hewitt , Fabio Estevam , Marek Vasut , Samuel Holland , Simon Glass , Tom Rini , Tomer Yacoby , "Ying-Chun Liu (PaulLiu)" References: <20220806013403.1344-1-william.zhang@broadcom.com> From: Florian Fainelli In-Reply-To: <20220806013403.1344-1-william.zhang@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/5/2022 6:33 PM, William Zhang wrote: > Broadcom BCA (Broadband Carrier Access origin) chipset family includes > DSL, PON and WLAN access point and gateway SoC. Now that the ARCH_BCMBCA > architecture and its first SoC BCM47622 are supported in u-boot 2022.07, > this patch series add the basic support for following BCA chips under > ARCH_BCMBCA: BCM4908, BCM4912, BCM63146 and BCM6813. > > This patch series applies on top of the my previous patch [1]. > > [1] https://lists.denx.de/pipermail/u-boot/2022-August/491060.html Looks good to me, thanks William! On the mmu_table.c implementation maybe just a few nits: - should not we do an early parsing of the memory node for the given board(s) to ensure that we map no more than the amount of available DRAM? - the exact same file is currently being re-used, so it would make sense to make it a common object - you could create a memory mapping for the AXI bus region right away to avoid forgetting about it later if you start bringing up drivers that make use of that peripheral region Thanks! -- Florian