From: Marek Vasut <marek.vasut@mailbox.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
u-boot@lists.denx.de
Cc: Angus Ainslie <angus@akkea.ca>,
Eugen Hristev <eugen.hristev@collabora.com>,
Igor Prusov <ivprusov@salutedevices.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Nishanth Menon <nm@ti.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Simon Glass <sjg@chromium.org>,
Stefan Bosch <stefan_b@posteo.net>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Tom Rini <trini@konsulko.com>,
kernel@puri.sm
Subject: Re: [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget
Date: Wed, 20 Mar 2024 21:18:55 +0100 [thread overview]
Message-ID: <3fd317b9-6bbb-4ef2-b806-9e364b4e06de@mailbox.org> (raw)
In-Reply-To: <b20f5e01-d45c-402c-90e2-9593558bbeaa@linaro.org>
On 3/18/24 1:47 PM, Caleb Connolly wrote:
>
>
> On 17/03/2024 04:42, Marek Vasut wrote:
>> The dm_usb_gadget_handle_interrupts() has no place in board code. Move
>> this into DWC3 driver. The OMAP implementation is special, add new weak
>> dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt
>> handling should be called, and override it in OMAP DWC3 code, to repair
>> the special OMAP interrupt handling code until OMAP gets switched over
>> to DM UDC proper.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>
> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
Thank you. If you have a hardware with DWC3 , can you please also test
this series ? I am afraid this may break things, although it is likely
to break mostly select MX8M boards.
next prev parent reply other threads:[~2024-03-20 20:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 4:42 [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget Marek Vasut
2024-03-17 4:42 ` [PATCH 2/2] usb: udc: dwc3: Fold dwc3_uboot_handle_interrupt into dm_usb_gadget_handle_interrupts Marek Vasut
2024-03-21 10:02 ` Mattijs Korpershoek
2024-03-18 12:47 ` [PATCH 1/2] usb: udc: dwc3: Fold board dm_usb_gadget_handle_interrupts() into DWC3 gadget Caleb Connolly
2024-03-20 20:18 ` Marek Vasut [this message]
2024-03-21 17:05 ` Caleb Connolly
2024-03-21 19:38 ` Marek Vasut
2024-03-21 10:01 ` Mattijs Korpershoek
2024-03-21 19:38 ` Marek Vasut
2024-03-22 9:32 ` Mattijs Korpershoek
2024-04-02 9:13 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fd317b9-6bbb-4ef2-b806-9e364b4e06de@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=angus@akkea.ca \
--cc=caleb.connolly@linaro.org \
--cc=clamor95@gmail.com \
--cc=eugen.hristev@collabora.com \
--cc=ivprusov@salutedevices.com \
--cc=kernel@puri.sm \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mkorpershoek@baylibre.com \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=sjg@chromium.org \
--cc=stefan_b@posteo.net \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox