public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot-Users] small fix for cmd_mii
@ 2004-02-24 13:20 Steven Scholz
  2004-02-26 23:18 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Scholz @ 2004-02-24 13:20 UTC (permalink / raw)
  To: u-boot

Hi there,

Using the arguments from the last executed MII command (by just 
pressing ENTER) does not work. Please consider this trivial patch.

CHANGELOG:

* Patch by Steven Scholz, 24 Feb 2004:
   - fix MII commands to use values from last command

diff -p -u -r1.6 cmd_mii.c
--- common/cmd_mii.c    12 Feb 2004 00:47:13 -0000      1.6
+++ common/cmd_mii.c    24 Feb 2004 13:05:16 -0000
@@ -129,6 +129,7 @@ int do_mii (cmd_tbl_t * cmdtp, int flag,
         last_op = op;
         last_addr = addr;
         last_data = data;
+       last_reg = reg;

         return rcode;
  }

BTW: Wolfgang, is it ok to supply such trivial one line patches
      inline? Or do you want them as attached files to the email?

Thanks!

-- 
Steven Scholz

imc Measurement & Control               imc Me?systeme GmbH
Voltastr. 5                             Voltastr. 5
13355 Berlin                            13355 Berlin
Germany                                 Deutschland

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [U-Boot-Users] small fix for cmd_mii
  2004-02-24 13:20 [U-Boot-Users] small fix for cmd_mii Steven Scholz
@ 2004-02-26 23:18 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2004-02-26 23:18 UTC (permalink / raw)
  To: u-boot

In message <403B4F8F.2090405@imc-berlin.de> you wrote:
> 
> * Patch by Steven Scholz, 24 Feb 2004:
>    - fix MII commands to use values from last command

Thanks, added.

> BTW: Wolfgang, is it ok to supply such trivial one line patches
>       inline? Or do you want them as attached files to the email?

This is perfectly fine as long as your  mailer  does  not  wrap  long
lines  or  otherwise  corrupts  the  patch.  If  in doubt send a MIME
attachment.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"If you can, help others. If you can't, at least don't hurt  others."
- the Dalai Lama

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-26 23:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-24 13:20 [U-Boot-Users] small fix for cmd_mii Steven Scholz
2004-02-26 23:18 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox