[U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console

[U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console

[Pierre AUBERT]

Hi everybody,

The attached patch add bitmap (8bpp and 24bpp) support on cfb_console.

This patch has been tested on a Lite5200 board with a smiLynxEM+ evaluation
board on PCI.

Be carefull: this patch moves the environment location in flash for the 
Lite5200 board.
U-boot room became too small ...

CHANGELOG
* Pierre AUBERT 11 Mar 2004
    - add bitmap command and splash screen support in cfb console.
    - add [optional] origin in the bitmap display command.
    - move the environment location in flash for the Lite5200 board.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: u-boot-bmp.patch
Url: http://lists.denx.de/pipermail/u-boot/attachments/20040311/29f78d42/attachment.txt 

[U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console

[Wolfgang Denk]

In message <40509BDC.6060506@staubli.com> you wrote:
> 
> The attached patch add bitmap (8bpp and 24bpp) support on cfb_console.

It also does some other things which you  don't  bother  to  mention
here.

Please ALWAYS describe ALL extensions to the code.

> Be carefull: this patch moves the environment location in flash for the 
> Lite5200 board.
> U-boot room became too small ...

Thanks for the warning, but actually I would like to ask you to SPLIT
such modifications into separate, independend patches.


Also, it is not exactly nice to enable  non-standard  features  (like
CONFIG_VIDEO   or  CONFIG_CFB_CONSOLE,  CFG_CMD_BMP)  while  deleting
others   (CONFIG_DOS_PARTITION)   in   public   configuration   files
(IceCube.h).

THis is not your private board configuration, and you are NOT allowed
to bend or cripple it as you like.


Fineally, it is a VERY, VERY BAD idea to use code like this:

	#define VIDEO_KBD_INIT_FCT    (simple_strtol (getenv("console"), NULL, 10))

Guess what happens if "console" is not set in your environment?


Also, please stick with the coding style (indentation  by  TABs  =  8
characters wide);

> CHANGELOG
> * Pierre AUBERT 11 Mar 2004
>     - add bitmap command and splash screen support in cfb console.
>     - add [optional] origin in the bitmap display command.
>     - move the environment location in flash for the Lite5200 board.

Added [cursing a lot].


Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
"Intelligence without character is a dangerous thing."   - G. Steinem

[U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console

[Pierre AUBERT]

Hi Wolfgang

Wolfgang Denk wrote:

>In message <40509BDC.6060506@staubli.com> you wrote:
>  
>
>>The attached patch add bitmap (8bpp and 24bpp) support on cfb_console.
>>    
>>
>
>It also does some other things which you  don't  bother  to  mention
>here.
>
>Please ALWAYS describe ALL extensions to the code.
>
>  
>
>>Be carefull: this patch moves the environment location in flash for the 
>>Lite5200 board.
>>U-boot room became too small ...
>>    
>>
>
>Thanks for the warning, but actually I would like to ask you to SPLIT
>such modifications into separate, independend patches.
>
>
>Also, it is not exactly nice to enable  non-standard  features  (like
>CONFIG_VIDEO   or  CONFIG_CFB_CONSOLE,  CFG_CMD_BMP)  while  deleting
>  
>
Sorry, I've enabled this config for testing purpose and I've forgotten
to remove it.

>others   (CONFIG_DOS_PARTITION)   in   public   configuration   files
>(IceCube.h).
>  
>
I've deleted CONFIG_DOS_PARTITION because it's defined twice in 
Icecube.h !!!
(and it's always defined twice in the CVS ...)

>
>  
>
>Best regards,
>
>Wolfgang Denk
>
>  
>
Best regards

[U-Boot-Users] PATCH - add CMD_BMP and SPLASH_SCREEN support in cfb_console

[Wolfgang Denk]

In message <40557109.1070509@staubli.com> you wrote:
> 
> >others   (CONFIG_DOS_PARTITION)   in   public   configuration   files
> >(IceCube.h).
> >
> I've deleted CONFIG_DOS_PARTITION because it's defined twice in 
> Icecube.h !!!
> (and it's always defined twice in the CVS ...)

I see. Ok, it's removed now.

[You see why I ask for a description of such  changes  -  I  was  not
aware  that  this  definition  was  redundand  so I thought you would
actually disable this.]

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: wd at denx.de
For every complex problem, there is a solution that is simple,  neat,
and wrong.                                               - Mark Twain